This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31670 - make WelcomeComponent focusable for S1S welcome screen
Summary: make WelcomeComponent focusable for S1S welcome screen
Status: CLOSED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Welcome (show other bugs)
Version: -S1S-
Hardware: PC Windows XP
: P1 blocker (vote)
Assignee: Richard Gregor
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2003-03-05 00:08 UTC by Jeri Lockhart
Modified: 2003-07-16 20:52 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeri Lockhart 2003-03-05 00:08:12 UTC 
Please make WelcomeComponent focusable:

Suggested fix:
Add to constructor:

        this.setFocusable(true);

Please see IZ 31597.

The S1S-branded welcome screen cannot be focused
with keyboard because of a change to TopComponent.
 TopComponent is not focusable by default.  Unlike
the NetBeans 3.4 Welcome Screen, the S1S-branded
screen contains JButtons that can be CTRL-Tab'd
to, but first the TC must be focusable using CTRL-3.  

There is no circumvention and this is an
accessibility issue.
Comment 1 Richard Gregor 2003-03-05 08:18:28 UTC 
Fixed in trunk.
Checking in src/org/netbeans/modules/welcome/WelcomeComponent.java;
/cvs/ui/welcome/src/org/netbeans/modules/welcome/WelcomeComponent.java,v
 <--  WelcomeComponent.java
new revision: 1.16; previous revision: 1.15
done
Comment 2 Richard Gregor 2003-03-05 10:25:06 UTC 
I'm sorry. I had to revert this fix because setFocusable works only on
jdk1.4 not on jdk1.3.1. NB is build on jdk1.3.1 so it causes not
buildable state.
Comment 3 Jeri Lockhart 2003-03-05 17:51:43 UTC 
The change should be made in the release35 branch.  S1S Nevada is
built on JDK 1.4, so setFocusable() will compile.  S1S Nevada does not
support JDK 1.3.1.

The change should also be made in the trunk.  If NetBeans is still
being built on JDK 1.3.1, the correct method is
setRequestFocusEnabled(true).
Comment 4 Richard Gregor 2003-03-06 10:40:09 UTC 
Thanks Jeri! Fixed. 

There is setRequestFocusEnabled(true) used for both nb and release35
branch (it is also built on jdk1.3.1)

Checking in src/org/netbeans/modules/welcome/WelcomeComponent.java;
/cvs/ui/welcome/src/org/netbeans/modules/welcome/WelcomeComponent.java,v
 <--  WelcomeComponent.java
new revision: 1.15.2.1; previous revision: 1.15
done
Comment 5 Jeri Lockhart 2003-03-07 01:32:56 UTC 
Unfortunately I still have the problem in the Nevada Welcome Screen. 
It can only be fixed by setFocusable(true), not by
setRequestFocusEnabled(true).  The problem is that I need to get focus
through the keyboard (CTRL-3), not the mouse.  This is required for
A11Y.  

We need some way to get this fix for Nevada, which is built with JDK 1.4.
Comment 6 Richard Gregor 2003-03-07 17:52:26 UTC 
Fixed. It should work this way.

Checking in src/org/netbeans/modules/welcome/WelcomeComponent.java;
/cvs/ui/welcome/src/org/netbeans/modules/welcome/WelcomeComponent.java,v
 <--  WelcomeComponent.javanew revision: 1.19; previous revision: 1.18
done

release35
Checking in src/org/netbeans/modules/welcome/WelcomeComponent.java;
/cvs/ui/welcome/src/org/netbeans/modules/welcome/WelcomeComponent.java,v
 <--  WelcomeComponent.javanew revision: 1.15.2.2; previous revision:
1.15.2.1
done