This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31819 - Duplicate mnemonics in the "Add Tomcat 4.0 Installation"
Summary: Duplicate mnemonics in the "Add Tomcat 4.0 Installation"
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Tomcat (show other bugs)
Version: -S1S-
Hardware: Sun Solaris
: P3 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2003-03-10 12:35 UTC by ccv
Modified: 2003-04-03 06:17 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ccv 2003-03-10 12:35:13 UTC
Product Version = Sun ONE Studio 5, Standard
Edition (Build 030306)
IDE Versioning = IDE/1 spec=3.42 impl=030306
Operating System = SunOS version 5.8 running on
sparc
Java; VM; Vendor = 1.4.0; Java HotSpot(TM) Client
VM 1.4.0-b92; Sun Microsystems Inc.

- In the Explorer window select the pane "Runtime"
- Select popup Servlet Registry/Install
Server/Tomcat 4.0/Add Tomcat 4.0 Installation

 1. Components with potential mnemonics conflict:
 - components with mnemonic 'H' :
   Class: javax.swing.JButton {  Help |  Help
button } 
   Class: javax.swing.JLabel {  Home dir: |  } 
 2. I don't know may be it is expected behaviour,
but dialog not traversal with Tab key, with
Ctrl-Tab only, because there are two text areas in
the dialog.  
 Results of Accessibility test:
 No Accessible name :
   Class: javax.swing.JTextArea {  |  } 
   Class: javax.swing.JTextArea {  |  } 
 No Accessible description :
   Class: javax.swing.JTextArea {  |  } 
   Class: javax.swing.JTextArea {  |  } 
 Components with no LABEL_FOR pointing to it :
   Class: javax.swing.JTextArea {  |  } 
   Class: javax.swing.JTextArea {  |  }
Comment 1 Milan Kuchtiak 2003-03-10 15:21:24 UTC
The mnemonic for "Home Dir" was changed from "H" to "D".
The both JTextAreas were set to unfocusable.

Here is the proposed fix :

diff -c -r1.13 AddInstallationJPanel.java
*** AddInstallationJPanel.java	27 Feb 2003 23:42:18 -0000	1.13
--- AddInstallationJPanel.java	10 Mar 2003 15:16:38 -0000
***************
*** 44,49 ****
--- 44,51 ----
      /** Creates new form AddInstallationJPanel */
      public AddInstallationJPanel() {
          initComponents();
+         jTextArea1.setFocusable(false);
+         jTextArea2.setFocusable(false);
          // a11y part
         
homeTextField.getAccessibleContext().setAccessibleDescription(NbBundle.getMessage(AddInstallationJPanel.class,
"A11Y_DESC_homeDir"));
         
baseTextField.getAccessibleContext().setAccessibleDescription(NbBundle.getMessage(AddInstallationJPanel.class,
"A11Y_DESC_baseDir"));
Index: Bundle.properties
===================================================================
RCS file:
/cvs/tomcatint/tomcat40/src/org/netbeans/modules/tomcat/tomcat40/Bundle.properties,v
retrieving revision 1.35.4.1
diff -c -r1.35.4.1 Bundle.properties
*** Bundle.properties	5 Mar 2003 09:54:00 -0000	1.35.4.1
--- Bundle.properties	10 Mar 2003 15:16:38 -0000
***************
*** 107,113 ****
  
  LBL_baseDir_Mnem=B
  
! LBL_homeDir_Mnem=H
  
  A11Y_DESC_homeDir=Tomcat 4.0 installation home directory (For
instance: c:\tomcat\tomcat4.0)
  
--- 107,113 ----
  
  LBL_baseDir_Mnem=B
  
! LBL_homeDir_Mnem=D
  
  A11Y_DESC_homeDir=Tomcat 4.0 installation home directory (For
instance: c:\tomcat\tomcat4.0)

The code reviewer : Ales Kemr
Comment 2 Milan Kuchtiak 2003-03-10 15:46:38 UTC
Fixed in both 3.5 and trunk.
Comment 3 Milan Kuchtiak 2003-03-11 10:51:22 UTC
I broke the build with calling theJComponent.setFocuseble(boolean b)
method, which is available only from JDK1.4.

I made some corrections.

Both descriptive text areas were replaced by JLabels and
the accessible descriptions of radio buttons -  are pointing out to
these label texts.

See the diff ;
http://web.netbeans.org/source/browse/tomcatint/tomcat40/src/org/netbeans/modules/tomcat/tomcat40/AddInstallationJPanel.java.diff?r1=1.15&r2=1.16
Comment 4 Milan Kuchtiak 2003-03-11 13:33:07 UTC
Integrated to Netbeans3.5
Comment 5 Jason Rush 2003-04-03 06:17:19 UTC
Verified in Nevada build 030401.