This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33160 - add, update and commit includes class-files for GUI-files with additional form-files
Summary: add, update and commit includes class-files for GUI-files with additional for...
Status: VERIFIED DUPLICATE of bug 33141
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-23 13:07 UTC by arittner
Modified: 2007-01-04 17:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arittner 2003-04-23 13:07:39 UTC
I start with a clean install of nb3.5beta and imported 
settings from NB3.4.1.
The commit parameters are different to the commit
parameters under NB3.4.1 

NB3.5b add all class-Files and the form-Files to the
commit. Including the class files is wrong. I've no 
changes in the form files. But commit includes all files 
with the same name and different extensions.

My cvs-Server is: CVSNT--Concurrent Versions System 
v1.11.1.3 running under W2K.
Comment 1 arittner 2003-04-24 10:24:38 UTC
Ok, I start to reproduce this issue. With normal java-
files I get no problems. But with GUI-Files. It could be 
the inner classes or the special case of java/form-files.

Here is the full resolved command (single line):

cvs  commit -m "Dokumentation"  JFrmSearch.java 
JFrmSearch$9.class JFrmSearch$7.class 
JFrmSearch$ActionDispatcher.class JFrmSearch.class 
JFrmSearch$2.class JFrmSearch.form JFrmSearch$10.class 
JFrmSearch$6.class JFrmSearch$8.class JFrmSearch$1.class 
JFrmSearch$4.class JFrmSearch$12.class JFrmSearch$11.class 

Here is a sample error result:

cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$9.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$7.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$ActionDispatcher.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$2.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$10.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$6.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$8.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$1.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$4.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$12.class'
cvs server: nothing known about 
`AdmSoftware/App/JFrmSearch$11.class'
cvs [server aborted]: correct above errors first!

(Please note, "nothing known about `...'" is in the same 
line)

Same problem (but no error) with "update".

Resolved command-string (single line):

cvs  update  JFrmSearch.java JFrmSearch$9.class 
JFrmSearch$7.class JFrmSearch$ActionDispatcher.class 
JFrmSearch.class JFrmSearch$2.class JFrmSearch.form 
JFrmSearch$10.class JFrmSearch$6.class JFrmSearch$8.class 
JFrmSearch$1.class JFrmSearch$4.class JFrmSearch$12.class 
JFrmSearch$11.class 

I'll test a simple class with inner class.

greetings,
  josh.
Comment 2 arittner 2003-04-24 10:43:50 UTC
Ok, I've new results. Normal java files with (anonymous) 
inner classes are commited without any problem. But 
javacvs commit java/form-files with class-files (and add 
with class-files and update with class-files).

Add-command:

cvs  add -m "Test for NB35b commit"  
JFrmTestCommitNB35b.java JFrmTestCommitNB35b.class 
JFrmTestCommitNB35b$2.class JFrmTestCommitNB35b.form 

I hope this is exactly enough :)

greetings,
  josh.

IMHO it's now a P1 problem - javacvs is broken for gui-
programming.
Comment 3 arittner 2003-04-24 10:52:15 UTC
Same problem with remove. 

josh.
Comment 4 dmladek 2003-04-24 15:32:17 UTC
Hi Josh,

you perform commit on a directory, do you?

In this case (is valid for others commands as well)
the "CVS Ignor List" comes to play its role....

And this is quite commplicated issue. And probably all your files in
this directory will be proceeded.
I've already explained somewhere (on our mailling list or in some
bug)... I'll try to look for it and give you a note
about it....

But if I'm performing cvs commands on individual  DO
(DataObject,composes of various  number of FO=fileObject) then only
files belonging to DO
(typical is .form + .java) are proceeded.
By default "Locally Ignored Files" = ~$|^\.#
are ignored.

Also averything depends on the property "Process All Files" which is
by default set to false.

Please check your settings either of individual FS or in
Tools->Options-> Source Creation and Management-> ....


Comment 5 dmladek 2003-04-24 15:49:02 UTC
Uff;-) I found the mail where I explaining stuffs about CVS Ignore
lists" for you:-) It is on this URL:
http://www.netbeans.org/servlets/ReadMsg?msgId=433150&listName=nbusers

BTW: I wasn't able to reproduce such behaviour which you describing.
I'm sure you must have set the FS property
"Process All Files" to TRUE.

If this property was set to FALSE in NB3.4.1 and after import to
NB3.5b it changes to TRUE (which I don't believe it is possible. I'd
accept if you told us it is vice-versa:), please enter a new issue
(P2, P1) against javacvs module as bug for import settings

thanks
-daniel
Comment 6 Jiri Kovalsky 2003-04-24 16:03:25 UTC
I propose to waive this for Sun ONE Studio 5.0 based on recent
Daniel's comments.
Comment 7 Martin Entlicher 2003-04-24 16:07:31 UTC
I was not able to reproduce this behavior as well. So I'm resolving
this as "worksforme". Please make sure the Process All Files property
is not true.
Comment 8 arittner 2003-04-24 19:04:12 UTC
Hi ho :-)

No, I commit the single filenode in the explorer tree 
(with the popup-menu). I'll test tomorrow the 
property "Process All Files". At next I'll extend 
the .cvsignore list. But with 3.4.1 the same repository 
works without this problem. 

However, it does not explain the difference between 
standard java files and the java/form-files. A GUI-Frame-
node (with form-files) commits the class files, a standard 
java-file-node commits only the changed java-file. 

greetings,
  josh.
Comment 9 Martin Entlicher 2003-04-25 12:24:34 UTC
Josh, do you use some compilation target directory? If yes, that this
is IMHO a duplicate of issue #33141.
There's attached a binary patch in issue #33141. Would you please
apply that patch and let me know whether it fixed the problem? Thanks.
Comment 10 arittner 2003-04-25 13:15:15 UTC
Yes, yes, yes :D

I use a different compilation target and the patch works 
:-)

Verified for add, commit, update and remove with GUI-
Forms. This bug is a duplicate of issue #33141 (but hard 
to find out).

Thank you!

greetings,
  josh.

PS.: Please change this issue to an suitable state.
Comment 11 Martin Entlicher 2003-04-25 13:21:29 UTC
Than you Josh for your verification!
Comment 12 Martin Entlicher 2003-04-25 13:22:50 UTC
Resolving as a duplicate of issue #33141. You're right, it was hard to
find that these two are actually the same bugs.


*** This issue has been marked as a duplicate of 33141 ***
Comment 13 Jiri Kovalsky 2003-04-25 13:25:48 UTC
I agree. 10 people, 10 descriptions of the same problem ... ;-)