This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34023 - <makenbm> should exclude update_tracking/*.xml files
Summary: <makenbm> should exclude update_tracking/*.xml files
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: nbbuild-issues@ide
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-29 19:06 UTC by Jesse Glick
Modified: 2003-12-11 14:13 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed patch (just addition of the exclude ot fileset) (1.60 KB, patch)
2003-10-09 12:41 UTC, rbalada
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2003-05-29 19:06:36 UTC
As far as I can tell, there is no reason to
include the update_tracking/*.xml file in an NBM,
since org.netbeans.updater.UpdateTracking creates
such a file anyway (with more accurate contents)
when an NBM is unpacked. The tracking file is only
needed in the build tree as
$module/netbeans/update_tracking/*.xml so that a
distribution containing that module will have the
correct tracking info precomputed, but it need not
be part of the NBM.
Comment 1 rbalada 2003-10-09 12:41:54 UTC
Created attachment 11824 [details]
Proposed patch (just addition of the exclude ot fileset)
Comment 2 rbalada 2003-10-09 12:46:36 UTC
The proposed patch adds exclude for "netbeans/update_tracking/*.xml"
into getFileSet method of MakeNBM and MakeLNBM classes.

Tested with normal nbm and with translatedfiles (L10N) nbms a it looks
fine.
Comment 3 Jesse Glick 2003-10-09 19:44:49 UTC
Patch looks reasonable to me.
Comment 4 rbalada 2003-10-10 09:07:46 UTC
Fixed in trunk. Added //NOI18N tags.

Checking in MakeLNBM.java;
/cvs/nbbuild/antsrc/org/netbeans/nbbuild/MakeLNBM.java,v  <-- 
MakeLNBM.java
new revision: 1.8; previous revision: 1.7
done
Checking in MakeNBM.java;
/cvs/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java,v  <--  MakeNBM.java
new revision: 1.44; previous revision: 1.43
done
Processing log script arguments...
Mailing the commit message to cvs@nbbuild.netbeans.org (from
rbalada@netbeans.org)