This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 36041 - Buried popup window causes main IDE window to lock up.
Summary: Buried popup window causes main IDE window to lock up.
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 3.x
Hardware: PC Windows 95/98
: P3 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-11 15:55 UTC by twixter
Modified: 2004-10-07 09:47 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
bug fix (1.87 KB, patch)
2004-10-01 10:32 UTC, Stanislav Aubrecht
Details | Diff
Proper bug fix using DialogDescriptor (2.89 KB, patch)
2004-10-04 13:44 UTC, Stanislav Aubrecht
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description twixter 2003-09-11 15:55:12 UTC
NetBeans IDE 3.5.1 (Build 200307302351)
IDE Versioning: IDE/1 spec=3.42.2 
impl=200307302351

OS Windows 98 version 4.10 running on x86

Java: 1.4.2
VM: 1.4.2-b28

If I click on File->Open File... and the popup 
file dialog window is completely within the 
boundaries of the IDE window, then if I click 
on "Show Desktop" on my Windows screen, then I 
click on the taskbar icon for NetBeans, the main 
window reappears but the popup window is not 
visible. Clicking anywhere on the main window has 
no effect. I cannot even move it, or kill it by 
clicking on the X box at the top right. If I then 
invoke some window other than NetBeans and then 
mimimize that other window, the file dialog popup 
will reappear. 

This problem also occurs with these popups:

File->Print...
File->Page Setup...
Tools->Apply Patch...

Other popup windows apparently either stay on top 
or else the main window can be moved or resized.
Comment 1 adel 2003-12-11 12:52:16 UTC
Using the keyboard shortcut Alt+tab you cant have it but thats thats 
not really a solution. I think this happens when the window is in 
modular mode only. Should be fixed anyway. 
Comment 2 Jiri Mzourek 2004-02-17 11:31:13 UTC
Related to Win Sys? The problem: modal dialogs are not "on top", so
they block user input.
Comment 3 David Simonek 2004-02-24 15:09:50 UTC
Yes I'm able to reproduce, it indeed might be a problem with
inaccurate AWT parent setting.
Comment 4 Marian Mirilovic 2004-06-14 14:05:41 UTC
re-evaluate please ...
Comment 5 Stanislav Aubrecht 2004-10-01 10:32:07 UTC
Created attachment 17964 [details]
bug fix
Comment 6 Stanislav Aubrecht 2004-10-01 10:38:01 UTC
i fixed the problem with apply patch window (see the diff attached).

however the page setup and print dialogs are native os windows and
there's little i can do about it. on ms windows systems these dialogs
show their own separate icon on the task bar and clicking this icon
does restore the ide correctly. also when the page setup box is opened
then the ide does not repaint its contents (jdk 1.4 only). however
when using jdk 1.5 repainting is fine.

other popup windows (open file, open project, setup wizard, options
etc) seem to be fine.

dafe, pls review the bugfix
Comment 7 Milos Kleint 2004-10-01 10:46:51 UTC
having the dialog parent to mainWindow will work in MDI which has just
one window. However in SDI where a non-mainwindow is activated,
closing the dialog will result in the activation to be moved to the
main window. Thus stealing focus from the currently active window.
Using the DialogDescriptor class should be the way to go, it's trying
to parent the dialog to the currently activated window.

Martin E., why is the dialog not using DialogDescriptor API?

Comment 8 David Simonek 2004-10-01 13:04:04 UTC
Stando, Milos is right, I forgot that parenting to main window in any
case will cause troubles in SDI. Right fix should indeed be done by
vcs guys -  rewrite of "apply patch" dialog to use dialog descriptor.
So I don't recommend patch for integration now.
Comment 9 Stanislav Aubrecht 2004-10-04 13:44:03 UTC
Created attachment 18020 [details]
Proper bug fix using DialogDescriptor
Comment 10 Stanislav Aubrecht 2004-10-04 13:45:22 UTC
i added a new proper buf fix for the 'apply patch' using the
dialogdescriptor.
dafe, pls review
Comment 11 Milos Kleint 2004-10-04 14:13:50 UTC
looks ok to me.
Comment 12 David Simonek 2004-10-04 14:26:34 UTC
Jojo, OK, prepared to be given to vcs team.
Comment 13 Martin Entlicher 2004-10-06 18:23:34 UTC
Thanks for the patch! Moving to diff module, will apply the patch...
I do nor remember why did I use JDialog directly, I should use the
DialogDisplayer.
Comment 14 Martin Entlicher 2004-10-06 19:13:32 UTC
Slightly modified patch applied (only additional arguments added to
DialogDescriptor() in order not to display the options).

/cvs/diff/src/org/netbeans/modules/diff/PatchAction.java,v  <-- 
PatchAction.java
new revision: 1.20; previous revision: 1.19
Comment 15 Martin Entlicher 2004-10-06 19:19:24 UTC
Oops, saubrecht, what's your real name?? Did you sign JCA? Are you
listed at http://www.netbeans.org/about/legal/jca-approved.html??
If not, I have to revert the commit until you sign JCA!
Comment 16 Martin Entlicher 2004-10-06 19:24:47 UTC
It looks like you're not listed there, so I'm not allowed to apply the
patch :-(( I'm sorry, that the policy.
saubrecht, can you please sign the JCA? Thanks.
The patch is reverted for now:
/cvs/diff/src/org/netbeans/modules/diff/PatchAction.java,v  <-- 
PatchAction.java
new revision: 1.21; previous revision: 1.20
Comment 17 Milos Kleint 2004-10-07 07:51:43 UTC
standa is a new cdp-core colleague, working in sun.
Comment 18 Martin Entlicher 2004-10-07 09:47:00 UTC
:-) Thanks for the clarification Milos :-) It's a pity that there is
not displayed the full name.
Patch applied:

/cvs/diff/src/org/netbeans/modules/diff/PatchAction.java,v  <-- 
PatchAction.java
new revision: 1.22; previous revision: 1.21