This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 37809 - do not start the server when asking for list of targets
Summary: do not start the server when asking for list of targets
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: Nam Nguyen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-05 21:29 UTC by Pavel Buzek
Modified: 2006-06-05 00:39 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
diff (596 bytes, patch)
2003-12-05 21:30 UTC, Pavel Buzek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Buzek 2003-12-05 21:29:26 UTC
ServerInstance.start is called automatically
without checking needsStartForConfigure() when the
ServerInstance is asked for the list of available
targets. This is visible when you click on the
button in run profile customizer to select target
and expand the node.

The javadoc for
StartServer.needsStartForConfigure() says:
"Returns true if the admin server should be
started before configure."

it is not clear if "configure" includes getTargets
but I assume it could

I will attach a simple patch. If you like it let
me know and I will also fix Tomcat not to require
to be connected to return targets (that's easy).
Comment 1 Pavel Buzek 2003-12-05 21:30:29 UTC
Created attachment 12446 [details]
diff
Comment 2 Nam Nguyen 2003-12-05 22:05:11 UTC
Configure here is server configuration.  The change there is not
enough be cause it will miss start server to get targets for others
non-serverconfiguration purpose.  As part of solution for not starting
tomcat for admin configuration, I will be working on this now to
adding  another flag in StartServer: needsStartForAdminConfig default
true.  Tomcat need to return false.  Let me take care of this
startserver to get target lists too.
Comment 3 Nam Nguyen 2003-12-05 22:18:13 UTC
Since I am not sure needsStartForAdminConfig <=>
needsStartForTargetList I am going to do 2 separate attributes.
Comment 4 Nam Nguyen 2003-12-06 02:43:05 UTC
I have checkin the StartServer new methods to minimize the needs to
start server.  My test now show that for Tomcat only execution trigger
start tomcat server.
Comment 5 Pavel Buzek 2003-12-06 06:08:30 UTC
it really works, thanks!