Ann, please suggest a better name and reassign back to me. Tx.

If the proposal I had about how to display servers cannot be done in
time for 3.6, then let's take part of that proposal and apply it here.

Currently we have:
Server Registry ("<full name of default server instance>")
----Tomcat 5 server
--------Tomcat 5 server
(tomcat:home=jakarta-tomcatblahblahhttp://localhost:8080/manager/)

Here's a proposal (please comment if something wouldn't make sense)

Server Registry (<full name of default server instance)
----Tomcat 5 Server Instances
--------Tomcat 5 Server (http://localhost:8080)

Notice in this proposal
- no quotation marks in the Server Registry line
- Headline capitalization of "Tomcat 5 Server Instances" and "Tomcat 5
Server"
- no mention of "/manager" at the end of the url in localhost:8080
- Properties of a Tomcat 5 server instance should reflect the values
currently in the <full name> if it is understandable to the user. I'm
not sure what these values tell me about my installation, etc (pavel?)

The home dir and base dir tell you where the server is installed and
where is the base directory, this will be more interesting for servers
added by the user then the bundled server.

The node displays the URL of server. It looks like Radim used the URL
to store more information then one would expect in it because there is
no other way to pass the other parameters around in j2eeserver api.

Probably the easiest workaround would be to provide a node for tomcat
instance and provide a sensible name and properties for the home/base.
And then make sure server registry node uses the name of the instance
node and not the internal name of instance.

Tomcat instance name was set to "http://localhost:8080", not sure if
this was blessed by you, Ann.
The name of Server Registry node is in j2eeserver (i'm moving the bug
there). I am not sure if the suggestion:
"Server Registry (<full name of default server instance)" still
applies since it would not show the type of server.

Consistency with S1AS would be desirable. S1AS has:

+- Sun J Sys App Srv PE
  +- localhost:4848

I suggest to remove the word "Instances" from tomcat server node and
for registry use:

Server Registry ("<server name> - <instance name>")

*** Issue 38527 has been marked as a duplicate of this issue. ***

I'm ok with removing "Instances" from the name, though this I think
should also change the name of the associated action & dialog "Add New
Server Instance..." to just "Add New Server..." .  This is more in
lines with the AppSvr too, which has "Register Application Server" 

The ordering of the AppSvr name next to the Server Resgistry isn't
ideal, since that means the user has to scroll to the end to figure
out what the <host>:<port> is, which is prob the only distinguishing
feature between diff instances of the app server.

Given that, here's my take on how it should look: 

+ Server Registry (<host>:<port>, <server type name>)
---- + Tomcat 5 Servers 
-------- + <host>:<port>

So, populated with a real example, it would like like:

+ Server Registry (localhost:8080, Tomcat 5 Server)
---- + Tomcat 5 Servers 
-------- + localhost:8080

assign to pavel

Tomcat part fixed, Nam please fix the Server Registry node to use the
name of server instance node instad of the url. Maybe the
ServerInstance.getDisplayName could be changed from:

server.getDisplayName() + "(" + url + ")";

to something like:

getInstanceNodeName() + ", " + server.getDisplayName();

I am not sure how to get the instance node name in an elegant way
(rather then create it via server.getNodeProvider().createInstanceNode())

thanks

How about we check for InstanceProperties.PROP_DISPLAY_NAME =
"displayName".  If defined we will used it.  This probably better than
create a node just for display name.

 This sounds ok.
(we would have to add this property because it does not exist now and
servers would need to provide the value, right?).

Implemented ServerInstance.getDisplayName that would use value set for
InstanceProperties.DISPLAY_NAME_ATTR.

Now registry node display name is as suggested:
ServerRegistry(<manager node display name>, <server short-name>)
Tomcat5 <manager node displayname> currently is http://localhost:<port>/
I am not sure if it was decided to keep the "http://" part so I just
leave it as such.

Nobody objected to the "http://" part in the name. Fixed.

verified