This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Will attach the web module. It runs fine when executed from 3.5.1, or from standalone app. A request to the module is executed and reaches the server (judging from the monitor) but no response is generated. No exception is shown. I ran the server after disabling the monitor to ensure that it is not the culprit.
Created attachment 13169 [details] web module
ok, what I see is that the web module is started correctly but it does not show any page. In web.xml it has several welcome files but none of them are present in this .tar file. I wonder what that web module is supposed to show in broswer when executed in 3.5.1 or standalone.
This shouldn't have anything to do with the welcome files. If you check the deployment descriptor, there is a servlet that is mapped to "/". This servlet should be invoked. (The welcome files are irrelevant, they shouldn't be accessed - are you saying that the web module works if you take out that declaration?). Try executing it in 3.5.1 to see what happens. I can run this web module standalone with no problems - in fact it is part of a tutorial which is published on netbeans.org. I don't know exactly how you build the Tomcat used in the integration. Is there a bug in Tomcat which prevents this module from running?
It appears to be a problem with Tomcat. I have identified the following two issues that prevent the page from being drawn. Firstly, the attributes of the tag handlers were declared to be of type "String" in the TLD, it appears that they have to be declared to be "java.lang.String" now. I used the TLD editor to create the tag. I am not sure whether just "String" used to be an option. The second problem is with the dynamic includes. The include path is incorrectly created. I haven't been able to produce a path that does the right thing. While the first one is possibly a user error? the second one definitely isn't. I'm downgrading the bug to a P2 for now, because I think we can go to beta anyway (?) but we need to get this checked with Tomcat. Will pursue on Monday. We need to check the tutorial app also - the TLD can be easily fixed from our side and should be fixed before we release 3.6.
Created attachment 13173 [details] the log that shows the jasper exception
I have tested with the latest stable tomcat build - 5.0.18 - and there is the same error(and if I comment out the <type> the problem with <include> is also there).
Regarding the problem with type in the tld, this is an issue that Robert Gregor recently fixed in the taglib editor. Robert, do you know the bug number?
I reassign this to myself temporarily for tracking purposes. There are two problems: 1. The spec requires that containers be backwards compatible, so a JSP 2.0 container must be able to run JSP 1.2 taglibraries (and 1.1). The problem is that the JSP 1.2 spec did not require the type of tag attributes to be a fqn, so an attribute type of String (instead of java.lang.String would work). Such tag libraries do not work in JSP 2.0. Moreover, the error message from the container is such that it appears that the error is in the JSP that uses the library as opposed to in the TLD. 2. Scriptlets and scriptlet expressions do not work as values of the page attribute in jsp:include. They are not evaluated and the result is a compilation error. I have discussed the issue with an engineer on the RI JSP container. Issue 2 is definitely a bug, and it will be fixed ASAP. They will let us know so that we can update to a working version of Tomcat for the final release. I discussed issue 1 with the spec lead for the JSP specification, and we agree that such libraries should ideally be usable although this is a little shaky, given the (unlikely) possibility of name clashes. At a minimum the error message should be more helpful. We will have the following action items as a result: 1) Upgrade to a new version of Tomcat and possibly need to allocate resources to upgrade and retest the tutorial code (will affect any of our tutorials that involve a tag library created in the IDE). Further, if the tag libraries don't work, then we will need to take various actions to assist people who have previously developed taglibraries in the IDE. We should ideally verify that the TLDs are OK or offer users to help them. At least this should be part of upgrading a JSP 1.2 TLD to JSP 2.0
OK, I think I've done what I can in terms of tracking the particular issues with Tomcat, and we know they're getting addressed. There is one issue which needs to be fixed in the tutorial application (the evaluation of the scriptlet expression) and I will take that up with Chris separately. The source is not on collab.net. I reassign this to Pavel, who I assume will do the Tomcat upgrade when the time comes. We know what version to look for.
Integrate with TC 5.0.19 when it's out. Lowering the priority (this should technically be a task).
I upgraded to tomcat 5.0.19 and the tested. The issue with FQN's is fixed in tomcat. The other issue with includes was actually a bug in tomcat4: # According to JSP.2.13.2.3 ("Conversion from request-time # expressions") in JSP 1.2: # # Request-time expressions can be assigned to properties # of any type. # No automatic conversions will be performed. # # I think the fact that Tomcat 4 did not enforce this should be # considered a bug in Tomcat 4, not a spec backwards compatibility # issue.
VERIFIED