This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39957 - A regression in Internationalize dialog open time
Summary: A regression in Internationalize dialog open time
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: I18N (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@java
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2004-02-11 13:26 UTC by Antonin Nebuzelsky
Modified: 2004-03-02 15:08 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2004-02-11 13:26:28 UTC 
Performance tests consistently show a regression
in times of displaying Internationalize dialog
box. The absolute times together with the
percentages of comparison to NB351:

Internationalize dialog open (1st invocation)
linux:   1 200 ms (+80.0%)
solaris: 1 367 ms (+22.8%)
xp:      1 378 ms (+71.8%)

Internationalize dialog open (2nd and next) 
linux:     475 ms (+12.4%)
solaris:   693 ms (+11.6%)
xp:        383 ms (-52.4%)
Comment 1 Tomas Pavek 2004-02-24 15:46:53 UTC 
How does the test invoke the Internationalize dialog? With a java file
opened in editor, or just selected it in Explorer (editor closed)?
Comment 2 Antonin Nebuzelsky 2004-02-24 15:56:28 UTC 
A java file opened in the editor.
Invoking editor popup -> Tools|Internationalization|Internationalize...
Comment 3 Tomas Pavek 2004-02-24 18:15:38 UTC 
The profiler shows only that editor is repainting most of the time.
Nothing done in the i18n itself. The worse times are probably due to
the slower editor painting in NB 3.6 (with code folding). I'm going to
continue with the investigation.
Comment 4 Tomas Pavek 2004-02-25 10:27:38 UTC 
I haven't found any other significant difference from 3.5.1 than the
more intensive editor painting. BTW it is visible on all dialogs
invoked from the main menu - there is at least 150ms difference based
on whether there is a file opened in editor (so it is repainted) or not.

Anyway, I've made the i18n action synchronous, eliminated unnecessary
posting to AWT event queue and the whole thing now looks better. It
can be also better measured - not so many discrete paints are processed.

According to my current measuring on PIII 733MHz Win 2000 JDK
1.4.2_01, the 1st invocation time is around 750ms, subsequent
invocation about 300ms. So it should be ok. Let's wait what the perf.
tests will show...

/cvs/i18n/src/org/netbeans/modules/i18n/I18nAction.java
new revision: 1.15; previous revision: 1.14
/cvs/i18n/src/org/netbeans/modules/i18n/I18nManager.java
new revision: 1.23; previous revision: 1.22
Comment 5 ehucka 2004-03-02 14:43:36 UTC 
Could someone from performance team verified this issue?
Comment 6 Antonin Nebuzelsky 2004-03-02 15:08:20 UTC 
Performance test results reflect the fix you've made on 2/25. Since
then the numbers are better:

Internationalize dialog open (1st invocation)
linux:  1 092 ms (+37.9%)
solaris: 1 168 ms (+3.9%)
xp:     1 115 ms (+39.9%)

Internationalize dialog open (2nd and next)
linux:    314 ms (-26.9%)
solaris:  333 ms (-53.1%)
xp:       344 ms (-56.9%)

Though there is still a regression with the first invocation, the
numbers are now close to the 1s UI limit and the next invocations are
much better. IMO this is not a stopper anymore. Verifying.