This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 40710 - F1 does not bring up help when configuration editor nodes are selected
Summary: F1 does not bring up help when configuration editor nodes are selected
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 3.x
Hardware: PC Windows XP
: P1 blocker (vote)
Assignee: Nam Nguyen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-03 02:50 UTC by _ pcw
Modified: 2004-03-10 14:50 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
ConfigBeanTopComponent.diff (3.10 KB, patch)
2004-03-04 14:39 UTC, Nam Nguyen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ pcw 2004-03-03 02:50:25 UTC
Start NetBeans
Create a web app
Open the sun-web.xml configuration editor
Select a node in the left hand side of the editor
Hit F1
-- If you follow these steps exactly, I think
you'll get generic IDE help.
-- If you select other fields and hit F1, then
come back here, what you'll get is the "previous
help context".

-- What you should be getting is a context
sensitive help screen for the current displayed
customizer (the corresponding to the selected node.)

F1 does work if you select a field within the
customizer itself and then hit it.
Comment 1 Milan Kuchtiak 2004-03-03 12:49:00 UTC
Doesn't this issue depend on 40685 ?
The ContextDataObject should proovide the help ID for sun-web.xml.

After issue 40685 is fixed, the help ID "sun-web_help" can be used
both for sun-web.xml node in the (main)explorer and for the root node
in config editor.
Comment 2 _ pcw 2004-03-03 17:17:59 UTC
You're right, perhaps this is a dup of 40685.  However, the proposed
fix for 40685 wrt/ the plugin bypasses an API put together by George &
myself to provide distinct help contexts for each configuration node.

Each node can have a help id provided by it's DConfigBean and
retrieving this is already implemented in ConfigBeanNode.getHelpCtx().
 When a node is the selected object, that is the API I would be
expected to see used. 
Comment 3 Nam Nguyen 2004-03-04 00:55:43 UTC
The fix is to have the getHelpCtx() override in TwoPanelComponentPanel
class.
Comment 4 Nam Nguyen 2004-03-04 14:36:44 UTC
Fixed in trunk.  Will attach diff and request reviewers@netbeans.org
as specified by HR procecedure.
Comment 5 Nam Nguyen 2004-03-04 14:39:29 UTC
Created attachment 13825 [details]
ConfigBeanTopComponent.diff
Comment 6 Pavel Buzek 2004-03-05 21:25:10 UTC
I reviewed the fix and I agree with it. 
Thanks Nam!
Comment 7 Milan Kubec 2004-03-08 12:26:11 UTC
Is this really issues with the highest (P1) priority?
Comment 8 Nam Nguyen 2004-03-08 14:17:33 UTC
Probably not P1, but certainly, I think this is a fix we would want to
have for platforms with richer configuration editor like Sun WebServer. 
Comment 9 L Martinek 2004-03-08 17:49:54 UTC
Is help for sun-web.xml already integrated? I tried the fix and I got
other page than I got before the fix, but the page is almost empty. It
contains this:

Some Header there
Some Text here - WebApp - General
Comment 10 Nam Nguyen 2004-03-08 18:00:41 UTC
The last time I tried (last Wed.) it is only frame with placeholder
contents.  So if you have servlet node selected you would get help
indexed on servlet not the "WebApp General" one.
Comment 11 _ pcw 2004-03-09 00:00:59 UTC
I verified this against NetBeans trunk build of 3/7 21:57 and it works
fine.
Comment 12 Milan Kubec 2004-03-10 09:21:44 UTC
Why this issue is still NEW, when it's already fixed in trunk. It
should be RESOLVED/FIXED, with target milestone set to promo-D and
after all aprovals are finished (code review and QE aproval) it can be
integrated (if there is not objection on from reviewers@) and target
milestone set to 3.6.
Comment 13 Nam Nguyen 2004-03-10 14:50:14 UTC
Maybe my interpretation of step 6 in HR is different:

"A bug fixed only in the trunk should have the target milestone set to
promo-D. If a bug is fixed in the release36 branch as well, the target
milestone should be set to 3.6."

My interpretation is to keep the target to 3.6 as originally evaluated
and only change status to resolved after the fix is in the targeted
codeline.  IMO, this make more sense than changing the target.
  
The fix is now in release36.