This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 45396 - "LogicalViews" an inappropriate name for this class
Summary: "LogicalViews" an inappropriate name for this class
Status: CLOSED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Infrastructure (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: API
Depends on:
Blocks: 40703
  Show dependency tree
 
Reported: 2004-06-23 01:14 UTC by Jesse Glick
Modified: 2006-03-24 10:10 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-06-23 01:14:01 UTC 
In the Project UI API, there is a class called
LogicalViews, but it now does nothing except
return actions. I know they are intended for the
context menu in the logical view, but the class
name is still poor. It should be renamed to e.g.
SpecialProjectActions (?).
Comment 1 Jesse Glick 2004-06-23 16:26:10 UTC 
Suggestions: StandardProjectActions.

Probably used only by project type modules?
Comment 2 Jesse Glick 2004-06-23 16:26:34 UTC 
CommonProjectActions?
Comment 3 Jesse Glick 2004-06-23 16:51:23 UTC 
Would like to do soon. Can first copy the class to a new name and
deprecate the original, then delete the original soon thereafter.
Comment 4 Jesse Glick 2004-06-23 19:46:15 UTC 
Have patch prepared to make it CommonProjectActions, leaving old
LogicalViews behind but deprecated.

Hey, the Rename refactoring actually works!
Comment 5 Jesse Glick 2004-06-24 21:05:07 UTC 
committed 1.4 
ant/freeform/src/org/netbeans/modules/ant/freeform/Actions.java
committed 1.3 
ant/freeform/src/org/netbeans/modules/ant/freeform/ui/View.java
committed 1.18
apisupport/project/src/org/netbeans/modules/apisupport/project/Actions.java
committed 1.24
java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/J2SEPhysicalViewProvider.java
committed 1.4 
java/project/src/org/netbeans/spi/java/project/support/ui/PackageRootNode.java
committed 1.2 
latex/guiproject/src/org/netbeans/modules/latex/guiproject/LaTeXGUIProject.java
committed 1.2 
latex/guiproject/test/unit/src/org/netbeans/modules/latex/guiproject/LaTeXGUIProjectTest.java
committed 1.6 
projects/projectui/src/org/netbeans/modules/project/ui/PhysicalView.java
committed 1.22
projects/projectui/src/org/netbeans/modules/project/ui/ProjectsRootNode.java
committed 1.13
projects/projectui/src/org/netbeans/modules/project/ui/actions/Actions.java
added     1.1 
projects/projectuiapi/src/org/netbeans/spi/project/ui/support/CommonProjectActions.java
committed 1.8 
projects/projectuiapi/src/org/netbeans/spi/project/ui/support/LogicalViews.java
committed 1.11
web/project/src/org/netbeans/modules/web/project/ui/WebPhysicalViewProvider.java
committed 1.6 
web/project/src/org/netbeans/modules/web/project/ui/WebViews.java
Comment 6 Jaromir Uhrik 2005-07-14 16:19:16 UTC 
Verified.