This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51074 - Java toolbar disappeared after AssertionError from NavigationView
Summary: Java toolbar disappeared after AssertionError from NavigationView
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: Dusan Balek
URL:
Keywords:
: 51088 51613 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-02 13:49 UTC by Jan Becicka
Modified: 2007-11-05 13:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
AssertionError (1.51 KB, text/plain)
2004-11-02 13:49 UTC, Jan Becicka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2004-11-02 13:49:16 UTC
NbJavaJMIFastOpen$1.run(NbJavaJMIFastOpen.java:83)
does it's job outside AWT Event Queue.

Is it possible to call it inside AWT?
P2, because java toolbar disappeared after this
AssertionError.
Comment 1 Jan Becicka 2004-11-02 13:49:56 UTC
Created attachment 18668 [details]
AssertionError
Comment 2 Martin Roskanin 2004-11-03 10:31:24 UTC
*** Issue 51088 has been marked as a duplicate of this issue. ***
Comment 3 Dusan Balek 2004-11-03 10:53:15 UTC
I will look at it.
Comment 4 Dusan Balek 2004-11-03 13:51:08 UTC
Fixed in [maintrunk].

EditorSupport.getOpenedPanes() is called from AWT as requested.

Checking in src/org/netbeans/modules/editor/java/JMIUtils.java;
/cvs/editor/src/org/netbeans/modules/editor/java/JMIUtils.java,v  <--
 JMIUtils.java
new revision: 1.63; previous revision: 1.62
done

Mila, could you please review the fix.

Visual diff:
http://editor.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/JMIUtils.java.diff?r1=1.62&r2=1.63
Comment 5 Miloslav Metelka 2004-11-03 14:50:12 UTC
The fix should be OK although I've seen that there are certain
operations e.g.

int caretPos = pane.getCaretPosition();
             Container parent = pane.getParent();	            
Container parent = pane.getParent();

that should be run in AWT thread as those are operations on Swing/AWT
components.
Comment 6 Jaromir Uhrik 2004-11-04 13:46:37 UTC
The fix works fine in maintrunk build #200411031900; jdk1.5.0_01b05.
Ready for integration to release40.
Comment 7 Dusan Balek 2004-11-04 14:25:22 UTC
Integrated into [release40].

Checking in JMIUtils.java;
/cvs/editor/src/org/netbeans/modules/editor/java/JMIUtils.java,v  <--
 JMIUtils.java
new revision: 1.61.2.2; previous revision: 1.61.2.1
done
Comment 8 Jaromir Uhrik 2004-11-05 14:19:26 UTC
Verified in release40 branch build #200411041919; jdk1.5.0_01-b05.
Comment 9 Jaromir Uhrik 2004-11-05 14:20:10 UTC
v
Comment 10 Dusan Balek 2004-11-18 08:41:05 UTC
*** Issue 51613 has been marked as a duplicate of this issue. ***