51099 – Code completion does not work for arrays

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51099 - Code completion does not work for arrays

Summary: Code completion does not work for arrays

Status:	CLOSED FIXED

Alias:	None

Product:	editor
Classification:	Unclassified
Component:	Completion & Templates (show other bugs)
Version:	4.x
Hardware:	PC Windows ME/2000

Importance:	P1 blocker (vote)
Assignee:	Dusan Balek

URL:
Keywords:

Duplicates (2):	51513 52043 (view as bug list)
Depends on:
Blocks:

Reported:	2004-11-02 19:57 UTC by Tim Lebedkov
Modified:	2007-11-05 13:38 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Lebedkov 2004-11-02 19:57:18 UTC

String[] values = new String[10];
        for (int i = 0; i < values.length; i++) {
            values[i].<Ctrl+Space hier does not work>
        }

Comment 1 Dusan Balek 2004-11-03 07:56:44 UTC

I will look at it.

Comment 2 Dusan Balek 2004-11-03 09:12:31 UTC

Actually, there were two independent bugs that prevented code
completion to work correctly on the above mentioned example:
1) JavaDeclarationProcessor didn't propagate local variables declared
as a part of for statement to the statement body.
2) NbJavaJMICompletionQuery had a minor bug in array dereferencing.
 
Fixed in [maintrunk].

Checking in JavaDeclarationProcessor.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaDeclarationProcessor.java,v
 <--  JavaDeclarationProcessor.java
new revision: 1.13; previous revision: 1.12
done

Checking in NbJavaJMICompletionQuery.java;
/cvs/editor/src/org/netbeans/modules/editor/java/NbJavaJMICompletionQuery.java,v
 <--  NbJavaJMICompletionQuery.java
new revision: 1.44; previous revision: 1.43
done

Comment 3 Dusan Balek 2004-11-03 14:41:07 UTC

After a discussion with QA, setting priority to P3 and target
milestone to 4.1

Comment 4 Miloslav Metelka 2004-11-12 15:41:32 UTC

This issue was identified as a serious usability problem and should be
fixed in the relase40 branch. I have raised priority.

I have reviewed Dusan's fix and I approve it.

Comment 5 Miloslav Metelka 2004-11-12 18:44:28 UTC

Visual diffs for completness:
http://www.netbeans.org/source/browse/editor/libsrc/org/netbeans/editor/ext/java/JavaDeclarationProcessor.java.diff?r1=1.12&r2=1.13
http://www.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/NbJavaJMICompletionQuery.java.diff?r1=1.43&r2=1.44

Comment 6 Dusan Balek 2004-11-15 09:03:39 UTC

Checking in
libsrc/org/netbeans/editor/ext/java/JavaDeclarationProcessor.java;
Integrated into [release40].

/cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaDeclarationProcessor.java,v
 <--  JavaDeclarationProcessor.java
new revision: 1.12.4.1; previous revision: 1.12
done
Checking in
src/org/netbeans/modules/editor/java/NbJavaJMICompletionQuery.java;
/cvs/editor/src/org/netbeans/modules/editor/java/NbJavaJMICompletionQuery.java,v
 <--  NbJavaJMICompletionQuery.java
new revision: 1.43.2.1; previous revision: 1.43
done

Comment 7 Dusan Balek 2004-11-15 12:36:02 UTC

*** Issue 51513 has been marked as a duplicate of this issue. ***

Comment 8 Dusan Balek 2004-12-03 11:21:00 UTC

*** Issue 52043 has been marked as a duplicate of this issue. ***

Comment 9 Miloslav Metelka 2004-12-03 11:37:20 UTC

*** Issue 52043 has been marked as a duplicate of this issue. ***

Comment 10 Tim Lebedkov 2004-12-20 11:45:57 UTC

OK