This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51565 - CC in JSP scriptlet of methods/constructors doesn't work
Summary: CC in JSP scriptlet of methods/constructors doesn't work
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: All All
: P1 blocker (vote)
Assignee: Martin Roskanin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-16 14:00 UTC by zikmund
Modified: 2007-11-05 13:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zikmund 2004-11-16 14:00:50 UTC 
Build 200411150946 (pre-RC1)

1) Have a WebApp with a JSP
2) Type into JSP and invoke CC at | position
      <% String s; s.charAt(| %>
   or:
      <% throw new IllegalArgumentException(| %>
3) ERROR:
no CC is invoked.

BTW: modifying examples to:
      ...charAt(|)
   or
      ...Exception(|)
shows that an argument is passed for matching
method signature.
Comment 1 Petr Pisl 2004-11-16 14:09:59 UTC 
Reproducible on linux as well.
Comment 2 Petr Pisl 2004-11-16 14:12:05 UTC 
So the cc only doesn't work when the brackets are not closed. Do you
think that it's really P2?
Comment 3 zikmund 2004-11-16 14:27:23 UTC 
I forgot to mention the reason for P2, sorry:
IllegalArgumentException has 4 constructors, but you will see only 1
in the step 2 :( -- no way how to get javadoc to the rest constructors.

It's regression against Beta2.
Comment 4 Petr Pisl 2004-11-16 14:29:12 UTC 
Now I understand and agree  with P2.
Comment 5 zikmund 2004-11-16 15:13:12 UTC 
It has been broken up between builds 200409081800 and 09091800.
Comment 6 Martin Roskanin 2004-11-16 15:18:12 UTC 
editor problem, reassigning
Karel, thanks for investigating broken build_scope
Comment 7 Martin Roskanin 2004-11-16 15:57:16 UTC 
fixed in [maintrunk]

visual diff:
http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/editor/ext/java/JCResultItem.java.diff?r1=1.5&r2=1.6

Dusan, could you please review the fix?
Karel, could you please test and verify it?

thanks.
Comment 8 Martin Schovanek 2004-11-16 17:52:56 UTC 
I was tested continuous build #20041116-1628, invoking CC is fixed but
the problem with missing constructors remains.
Comment 9 Martin Schovanek 2004-11-16 18:37:55 UTC 
To missing constructors:
- can reproduce only on classes from java.lang package
- queery string in CC title is strange e.g. for 'new Exception(|)' it
is: 'Exception(Exception, *)'
Comment 10 Martin Roskanin 2004-11-16 21:54:40 UTC 
Aha. I have tested it on "new IllegalArgumentException(|"
I will look at it...
Comment 12 Dusan Balek 2004-11-17 15:42:06 UTC 
Both fixes look OK.
Comment 13 Martin Schovanek 2004-11-18 09:51:44 UTC 
I've tested it in #200411171900 (trunk build), both fixes look OK.
Comment 14 Jan Chalupa 2004-11-18 15:43:04 UTC 
Please prepare a fix for 4.0.
Comment 15 Martin Roskanin 2004-11-19 15:53:32 UTC 
integrated into [release40]

/cvs/editor/libsrc/org/netbeans/editor/ext/java/JCResultItem.java,v 
<--  JCResultItem.java
new revision: 1.5.4.1; previous revision: 1.5

/cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaCompletionQuery.java,v
 <--  JavaCompletionQuery.java
new revision: 1.50.6.1; previous revision: 1.50

/cvs/editor/src/org/netbeans/modules/editor/java/MDRFinder.java,v  <--
 MDRFinder.java
new revision: 1.8.2.1; previous revision: 1.8