This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 52164 - Adding API methods to support verify action
Summary: Adding API methods to support verify action
Status: CLOSED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: Pavel Buzek
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2004-12-07 16:32 UTC by Nam Nguyen
Modified: 2006-03-24 12:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
new plugin SPI VeriferSupport (1.71 KB, text/plain)
2004-12-07 22:16 UTC, Nam Nguyen 		Details
ValidationException.java (836 bytes, text/plain)
2004-12-07 22:18 UTC, Nam Nguyen 		Details
J2eeModuleProvider.java diff (2.22 KB, patch)
2004-12-07 22:23 UTC, Nam Nguyen 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nam Nguyen 2004-12-07 16:32:40 UTC 
To support verify action, added method:
o.n.m.j2ee.deployment.plugins.spi.ConfigurationSupport
{
    void verify(FileObject target);
}

ConfigurationSupport is a new plugin SPI in NB
4.1, no incompatibility issue with NB 4.0.
Comment 1 Pavel Buzek 2004-12-07 18:03:17 UTC 
To give more context for reviewers:

The goal of this API change is to enable calling app server verifier
from j2ee module projects (web/project, j2ee/ejbjarproject,
j2ee/earproject). This is an optional API, not all servers need to
have a verifier but some do. After talking to Nam we decided to change
the API to a separate interface:

o.n.m.j2ee.deployment.plugins.api.VerificationSupport {
    void verify(FileObject target);
}

The implementation will be registered in layer file as other plugin
implementation classes. If it is not there the plugin does not support
verification.

The action to call the verifier will be implemented in the modules
that implement j2ee projects. We will provide an ant task nbverify in
j2eeserver/ant. The ant task will have one parameter - the location of
module archive (the verification runs on archive) and the j2ee module
projects are responsible for setting dependency on their respective
"dist" targets. The nbverify task will just call the verify method.

Modules that implement j2ee projects will be able to test if the
verification is supported. For this we will add a new method in
org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment:

public boolean supportsVerification (String serverId);

Nam will attach a diff.
Comment 2 Nam Nguyen 2004-12-07 22:16:09 UTC 
Created attachment 19187 [details]
new plugin SPI VeriferSupport
Comment 3 Nam Nguyen 2004-12-07 22:18:26 UTC 
Created attachment 19188 [details]
ValidationException.java
Comment 4 Nam Nguyen 2004-12-07 22:23:03 UTC 
Created attachment 19189 [details]
J2eeModuleProvider.java diff
Comment 5 Pavel Buzek 2004-12-10 19:10:23 UTC 
implemented, merged to trunk
Comment 6 zikmund 2005-03-31 18:47:44 UTC 
v