This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 52532 - Need to deprecate duplicate API DeploymentPlanSplitter.getDeploymentPlanFileNames
Summary: Need to deprecate duplicate API DeploymentPlanSplitter.getDeploymentPlanFileN...
Status: CLOSED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: apireviews
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-16 02:10 UTC by Nam Nguyen
Modified: 2006-03-24 12:47 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
apichanges.xml diff (1.71 KB, text/plain)
2004-12-20 23:05 UTC, Nam Nguyen
Details
checkin log for recommended unit test (779 bytes, text/plain)
2004-12-21 07:13 UTC, Nam Nguyen
Details
checkin of apichanges, arch docs and deprecation mark in DeploymentPlanSplitter (568 bytes, text/plain)
2004-12-21 07:52 UTC, Nam Nguyen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nam Nguyen 2004-12-16 02:10:13 UTC
Originally j2eeserver plugin SPI has this method:
o.n.m.j2ee.deployment.plugins.api.DeploymentPlanSplitter.getDeploymentPlanFileNames().
Later on, we need a data loader for
ConfigDataObject to allow both graphical and xml
editing of the configuration files.  The loader
are registered and active very early at IDE boot
and there are changes that
DSP.getDeploymentPlanFileNames service is not
ready yet.  This entail a duplicate declaration in
plugin module layer.xml.
Duplication is bad in itself, but now it is worse
because the DSP implementation could be part of
the J2EE Platform which might not be set at all,
yet the service is invoke through out.  

Consolidating the service into the single
declaration in layer.xml not only solve this
problem but also avoid confusion for new plugin
writer.
Comment 1 Jaroslav Tulach 2004-12-16 08:09:15 UTC
If people with bigger insight to the problem agree, then it is
probably good change. I'd just like to remind that the j2eeserver review
http://openide.netbeans.org/tutorial/reviews/opinions_40771.html
requested test coverage of XML apis:
http://www.netbeans.org/issues/show_bug.cgi?id=42721
Please keep that direction and make sure your changes are covered by
tests and documented in arch*xml using <api group="layer" .../>
Comment 2 Nam Nguyen 2004-12-20 23:05:13 UTC
Created attachment 19372 [details]
apichanges.xml diff
Comment 3 Nam Nguyen 2004-12-21 07:13:33 UTC
Created attachment 19376 [details]
checkin log for recommended unit test
Comment 4 Nam Nguyen 2004-12-21 07:52:38 UTC
Created attachment 19377 [details]
checkin of apichanges, arch docs and deprecation mark in DeploymentPlanSplitter
Comment 5 Nam Nguyen 2004-12-21 07:54:29 UTC
Completed in all recommended actions.
Comment 6 Jesse Glick 2004-12-22 16:42:49 UTC
Please update the Target Milestone whenever closing any issue.
Comment 7 zikmund 2005-03-31 18:48:01 UTC
v