This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53550 - Review metamodel changes
Summary: Review metamodel changes
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Matula
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 49855
  Show dependency tree
 
Reported: 2005-01-18 10:03 UTC by Martin Matula
Modified: 2007-09-26 09:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff of the change to the API. (7.64 KB, patch)
2005-01-18 10:09 UTC, Martin Matula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matula 2005-01-18 10:03:51 UTC
Another set of Java model changes is prepared in
javacore41 branch. The changes include:
1) ConstructorInvocation now extends Invocation
(this makes it more intuitive and fixes the
problem that ConstructorInvocation was not
identified as usage of the constructor - since it
did not extend ElementReference) - this change
affects parameters of ConstructorInvocation's
factory method.
2) Invocation is no longer an Expression - since
ConstructorInvocation is not an Expression -
subclasses of Invocation that are expressions now
extend also PrimaryExpression.
3) packageAnnotations attribute was added to the
Resource class (affecting factory method for the
Resource) - this is necessary because one can
define package annotations in a file (attach them
to the package declaration in the resource).

Relevant diffs will be attached. Thanks in advance
for your review.
Comment 1 Martin Matula 2005-01-18 10:09:06 UTC
Created attachment 19738 [details]
Diff of the change to the API.
Comment 2 Martin Matula 2005-01-24 13:39:51 UTC
I am going to merge the javacore41 to the maintrunk tomorrow.
Comment 3 Martin Matula 2005-01-25 14:32:36 UTC
Commited to the main trunk.

Checking in www/models/java/java.xml;
/cvs/java/www/models/java/java.xml,v  <--  java.xml
new revision: 1.16; previous revision: 1.15
done
Processing log script arguments...
More commits to come...
Checking in javamodel/manifest.mf;
/cvs/java/javamodel/manifest.mf,v  <--  manifest.mf
new revision: 1.17; previous revision: 1.16
done
Processing log script arguments...
More commits to come...
Checking in javamodel/src/org/netbeans/jmi/javamodel/ClassDefinition.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/ClassDefinition.java,v
 <--  ClassDefinition.java
new revision: 1.10; previous revision: 1.9
done
Checking in
javamodel/src/org/netbeans/jmi/javamodel/ConstructorInvocation.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/ConstructorInvocation.java,v
 <--  ConstructorInvocation.java
new revision: 1.5; previous revision: 1.4
done
Checking in
javamodel/src/org/netbeans/jmi/javamodel/ConstructorInvocationClass.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/ConstructorInvocationClass.java,v
 <--  ConstructorInvocationClass.java
new revision: 1.5; previous revision: 1.4
done
Checking in javamodel/src/org/netbeans/jmi/javamodel/Invocation.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/Invocation.java,v 
<--  Invocation.java
new revision: 1.6; previous revision: 1.5
done
Checking in javamodel/src/org/netbeans/jmi/javamodel/JavaPackage.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/JavaPackage.java,v
 <--  JavaPackage.java
new revision: 1.9; previous revision: 1.8
done
Checking in
javamodel/src/org/netbeans/jmi/javamodel/MethodInvocation.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/MethodInvocation.java,v
 <--  MethodInvocation.java
new revision: 1.5; previous revision: 1.4
done
Checking in
javamodel/src/org/netbeans/jmi/javamodel/NewClassExpression.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/NewClassExpression.java,v
 <--  NewClassExpression.java
new revision: 1.5; previous revision: 1.4
done
Checking in javamodel/src/org/netbeans/jmi/javamodel/Resource.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/Resource.java,v 
<--  Resource.java
new revision: 1.5; previous revision: 1.4
done
Checking in javamodel/src/org/netbeans/jmi/javamodel/ResourceClass.java;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/ResourceClass.java,v
 <--  ResourceClass.java
new revision: 1.5; previous revision: 1.4
done
Processing log script arguments...
More commits to come...
Checking in
javamodel/src/org/netbeans/jmi/javamodel/resources/java-model.xml;
/cvs/java/javamodel/src/org/netbeans/jmi/javamodel/resources/java-model.xml,v
 <--  java-model.xml
new revision: 1.14; previous revision: 1.13
done
Processing log script arguments...
More commits to come...
Checking in
javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ConstructorInvocationClassImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ConstructorInvocationClassImpl.java,v
 <--  ConstructorInvocationClassImpl.java
new revision: 1.3; previous revision: 1.2
done
Checking in
javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ConstructorInvocationImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ConstructorInvocationImpl.java,v
 <--  ConstructorInvocationImpl.java
new revision: 1.5; previous revision: 1.4
done
Checking in
javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceClassImpl.java;
/cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceClassImpl.java,v
 <--  ResourceClassImpl.java
new revision: 1.8; previous revision: 1.7
done
Processing log script arguments...
More commits to come...
Checking in
javacore/test/unit/src/org/netbeans/jmi/javamodel/regenerator/Cloner.java;
/cvs/java/javacore/test/unit/src/org/netbeans/jmi/javamodel/regenerator/Cloner.java,v
 <--  Cloner.java
new revision: 1.7; previous revision: 1.6
done
Processing log script arguments...
Mailing the commit message to cvs@java.netbeans.org (from
mmatula@netbeans.org)
U models/java/java.xml
Comment 4 Quality Engineering 2007-09-20 10:00:24 UTC
Reorganization of java component