This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53777 - Deployment should provide a property change listener
Summary: Deployment should provide a property change listener
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: All Other
: P1 blocker (vote)
Assignee: Sherold Dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-20 20:41 UTC by Sherold Dev
Modified: 2005-01-27 16:40 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
J2EEServerAPI javadoc (325.24 KB, application/octet-stream)
2005-01-20 20:44 UTC, Sherold Dev 		Details
j2eeserver diff (8.09 KB, patch)
2005-01-20 20:46 UTC, Sherold Dev 		Details | Diff
J2EEServerAPI.zip updated (330.18 KB, application/octet-stream)
2005-01-25 08:39 UTC, Sherold Dev 		Details
j2eeserver diff - updated (17.84 KB, patch)
2005-01-25 08:40 UTC, Sherold Dev 		Details | Diff
Commit log (1.94 KB, text/plain)
2005-01-27 16:39 UTC, Sherold Dev 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sherold Dev 2005-01-20 20:41:29 UTC 
Please review these suggested changes of the 
j2eeserver API. 
 
Web and other types of projects need be notified 
when the server instance which they use is 
removed so that appropriate steps (like 
reporting "missing server problem") could be 
taken. To make this possible a property change 
listener should be added to the Deployment 
class. 
 
Methods for listing registered server instances 
that meet some requirements (supported module 
types, J2EE specification versions and tools) 
should be also added to the same class. This 
will be used by wizards and customizers that 
need to list server instances based on certain 
criterias. 
 
The only class affected by this change is 
org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment.
Comment 1 Sherold Dev 2005-01-20 20:44:05 UTC 
Created attachment 19837 [details]
J2EEServerAPI javadoc
Comment 2 Sherold Dev 2005-01-20 20:46:05 UTC 
Created attachment 19838 [details]
j2eeserver diff
Comment 3 Sherold Dev 2005-01-20 20:47:44 UTC 
This is a trivial and compatible change -> API_REVIEW_FAST.
Comment 4 Jaroslav Tulach 2005-01-21 13:12:08 UTC 
DeploymentAccessor reminds me my trick from
http://openide.netbeans.org/tutorial/api-design.html#design.less.friend
I am flattered. 

And yes, adding something to final class looks compatible enough.
Comment 5 Sherold Dev 2005-01-25 08:38:03 UTC 
Changes made to follow Nam's suggestions. Thank you Nam. 
 
InstanceListener will be used instead of the PropertyChangeListener 
and will be registered not in the Deployment class but in the 
J2eeModuleProvider. 
 
Affected API classes/interfaces: 
 
org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment 
org.netbeans.modules.j2ee.deployment.devmodules.spi.J2eeModuleProvider 
org.netbeans.modules.j2ee.deployment.devmodules.spi.InstanceListener 
- added
Comment 6 Sherold Dev 2005-01-25 08:39:07 UTC 
Created attachment 19924 [details]
J2EEServerAPI.zip updated
Comment 7 Sherold Dev 2005-01-25 08:40:37 UTC 
Created attachment 19925 [details]
j2eeserver diff - updated
Comment 8 Pavel Buzek 2005-01-26 19:50:43 UTC 
I agree with the proposed changes. Go ahead and integrate them.
Comment 9 Sherold Dev 2005-01-27 16:39:31 UTC 
Created attachment 20003 [details]
Commit log
Comment 10 Sherold Dev 2005-01-27 16:40:35 UTC 
Fixed.