This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 54479 - j2ee/utilities API review
Summary: j2ee/utilities API review
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 4.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Pavel Buzek
URL:
Keywords:
Depends on:
Blocks: 52155
  Show dependency tree
 
Reported: 2005-02-03 14:48 UTC by Jaroslav Tulach
Modified: 2006-09-01 12:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2005-02-03 14:48:45 UTC
The state of j2ee/utilities API during j2ee review
(issue 52155) was horrible so much that the
reviewers agreed on a separate review for this
module, which in opinion of several reviewers acts
as a trashcan for everything that does not fit
anywhere else and as such should not be exposed to
public.

As the module is already in codebase, the review
shall happen as soon as possible.
Comment 1 Vince Kraemer 2005-02-03 18:23:52 UTC
Agreed.

The module should not have any public packages.

Could we make the modules that have used these "public packages"
implementation dependedent on j2ee/utilities as a short term solution.

Is there any other solution, that doesn't involve a lot of file copy
operations?
Comment 2 Pavel Buzek 2005-02-03 18:31:07 UTC
One other comment we go in the review was to try to either eliminate
the impl dependecies or at least isolate the code that other modules
depend on into separate package -- to make it clear what is the
private contract and what really should not be used (see 54471).

I would prefer to create friend API for anything that is used by
multiple clients and should stay there (perhaps some UI code) and
remove/refactor the rest (move it in the modules that use it). 

If we (me, Vince, ?) do not find time for this in the next 2-3 weeks
or so then I agree with Vince to use impl dep as a backup solution
(54471 is not TCR, only TCA).
Comment 3 Pavel Buzek 2005-03-01 21:23:42 UTC
Jarda and devrev agrees with P2. The friend API is not targeted for
external users (outside enterprise cluster).
Comment 4 Pavel Buzek 2005-03-04 19:24:15 UTC
Asking for waiver for 4.1.
Friend API, not targeted for users outside of enterprise cluster.
Needs significant work before parts of it can become a valid API, the
rest should not be an API.
Comment 5 Marek Fukala 2005-04-06 17:07:33 UTC
I have submitted a separated api review Issue #57556 regarding the api cleanup.
Comment 6 Pavel Buzek 2005-07-20 16:53:43 UTC
57556 is fixed so the only thing that remains is to change the public packages
to friend and list the users explicitly.
Comment 7 Pavel Buzek 2005-08-24 05:11:14 UTC
fixed - see commit log in issue 54471
Comment 8 Dan Kolar 2006-09-01 12:38:26 UTC
v.