This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55081 - API to set target server on module
Summary: API to set target server on module
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Sherold Dev
URL:
Keywords:
Depends on:
Blocks: 52974
  Show dependency tree
 
Reported: 2005-02-16 17:07 UTC by Pavel Buzek
Modified: 2005-03-18 10:19 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
j2eeserver.diff (2.45 KB, patch)
2005-03-16 17:10 UTC, Sherold Dev 		Details | Diff
J2EEServerAPI.zip (333.15 KB, application/octet-stream)
2005-03-16 17:11 UTC, Sherold Dev 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Buzek 2005-02-16 17:07:20 UTC 
When adding module to j2ee application the target
server needs to be set to the same as for the app. 

To make this possible we need to add one method
into J2eeModuleProvider:

void setServerInstanceId (String severInstanceId);

This is an incompatible API change. It will be
implemented in all modules the implement the API.
Comment 1 Vince Kraemer 2005-02-16 23:49:50 UTC 
Please evaluate this and set the target milestone.  I need the info so I can update/evaluate 
the blocked issue.
Comment 2 Sherold Dev 2005-02-17 16:40:24 UTC 
Setting the TM to 4.1.
Comment 3 Vince Kraemer 2005-02-22 17:30:09 UTC 
please integrate before March 25, 2005 (if possible).
Comment 4 Sherold Dev 2005-03-16 17:10:40 UTC 
Created attachment 20904 [details]
j2eeserver.diff
Comment 5 Sherold Dev 2005-03-16 17:11:32 UTC 
Created attachment 20906 [details]
J2EEServerAPI.zip
Comment 6 Sherold Dev 2005-03-16 17:20:17 UTC 
Please review this API change. Setting the API_REVIEW_FAST keyword since the
change is trivial, although incompatible.

This change affects the following interface:

org.netbeans.modules.j2ee.deployment.devmodules.spi.J2eeModuleProvider

See attached j2eeserver.diff and J2EEServerAPI.zip for more details.
Comment 7 Pavel Buzek 2005-03-17 06:20:43 UTC 
Obviously, I agree with this change. Stepane, pls wait for one more reviewer to
approve before you integrate.
Comment 8 Jaroslav Tulach 2005-03-17 17:57:03 UTC 
When Pavel says so...
Comment 9 Sherold Dev 2005-03-18 10:19:48 UTC 
Integrated

Commit log:

Checking in
src/org/netbeans/modules/j2ee/deployment/devmodules/spi/J2eeModuleProvider.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/spi/J2eeModuleProvider.java,v
 <--  J2eeModuleProvider.java
new revision: 1.47; previous revision: 1.46
done
Checking in apichanges.xml;
/cvs/j2eeserver/apichanges.xml,v  <--  apichanges.xml
new revision: 1.13; previous revision: 1.12
done

Checking in earproject/src/org/netbeans/modules/j2ee/earproject/ProjectEar.java;
/cvs/j2ee/earproject/src/org/netbeans/modules/j2ee/earproject/ProjectEar.java,v
 <--  ProjectEar.java
new revision: 1.9; previous revision: 1.8
done
Checking in
ejbfreeform/src/org/netbeans/modules/j2ee/ejbfreeform/EJBFreeformProvider.java;
/cvs/j2ee/ejbfreeform/src/org/netbeans/modules/j2ee/ejbfreeform/EJBFreeformProvider.java,v
 <--  EJBFreeformProvider.java
new revision: 1.4; previous revision: 1.3
done
Checking in
ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/EjbJarProvider.java;
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/EjbJarProvider.java,v
 <--  EjbJarProvider.java
new revision: 1.22; previous revision: 1.21
done
Checking in project/src/org/netbeans/modules/web/project/ProjectWebModule.java;
/cvs/web/project/src/org/netbeans/modules/web/project/ProjectWebModule.java,v 
<--  ProjectWebModule.java
new revision: 1.33; previous revision: 1.32
done