This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57166 - Server.getDeploymentManager() is called when creating a server instance
Summary: Server.getDeploymentManager() is called when creating a server instance
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Pavel Buzek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-30 08:51 UTC by Kirill Sorokin
Modified: 2006-08-30 11:09 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Sorokin 2005-03-30 08:51:53 UTC 
When adding an instance or recreating it after NB restart the
ServerRegistry.addInstanceImpl() calls Server.getDeploymentManager() method in
order to obtain a DeploymentManager object for that instance. But what if
the server is not started? This works for jboss, which does not seem to care
whether the server is started or not, but, for example, WebLogic throws a
DeploymentManagerCreationException if one tries to get a connected
DeploymentManager while the server is stopped. Thus the instance fails to be
(re-)created.
Comment 1 Sherold Dev 2005-03-30 13:59:59 UTC 
I've removed the needless getDeploymentManager() call from the addInstanceImpl()
method, however, this won't most likely solve your problem completely since the
connected DeploymentManager is being used from other places as well.

I don't think we should try to fix this few days before 4.1 branching, since it
would be quite risky. Plugins can and most likely do currently rely on reuse of
the same deployment manager instance.

Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java,v
 <--  ServerInstance.java
new revision: 1.50; previous revision: 1.49
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v
 <--  ServerRegistry.java
new revision: 1.41; previous revision: 1.40
done
Comment 2 Sherold Dev 2005-03-30 16:22:16 UTC 
Setting the NO41 keyword, since this issue does not directly affects the NB 4.1
release.
Comment 3 Pavel Buzek 2005-07-29 18:38:37 UTC 
There are several other places when j2eeserver tries to create connected manager
when the server is not running (registry nodes, server instance, configuration).
I think I have them all fixed in my codebase.
Comment 4 Pavel Buzek 2005-07-29 18:44:15 UTC 
Checking in
src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java,v
 <--  ConfigurationStorage.java
new revision: 1.43; previous revision: 1.42
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/Server.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/Server.java,v  <--
 Server.java
new revision: 1.29; previous revision: 1.28
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java,v
 <--  ServerInstance.java
new revision: 1.55; previous revision: 1.54
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v
 <--  ServerRegistry.java
new revision: 1.43; previous revision: 1.42
done
Checking in
src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java,v
 <--  RegistryNodeProvider.java
new revision: 1.10; previous revision: 1.9
done
Comment 5 Pavel Buzek 2005-07-31 18:08:51 UTC 
just found another place:

/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java,v
 <--  ServerInstance.java
new revision: 1.56; previous revision: 1.55
Comment 6 Sherold Dev 2005-08-01 14:26:16 UTC 
fixing problems with multiple servers of the same type caused by incorrect
chaching of disconnected deployment manager

Checking in src/org/netbeans/modules/j2ee/deployment/config/ConfigSupportImpl.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigSupportImpl.java,v
 <--  ConfigSupportImpl.java
new revision: 1.37; previous revision: 1.36
done
Checking in
src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java,v
 <--  ConfigurationStorage.java
new revision: 1.44; previous revision: 1.43
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/Server.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/Server.java,v  <--
 Server.java
new revision: 1.30; previous revision: 1.29
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java,v
 <--  ServerInstance.java
new revision: 1.57; previous revision: 1.56
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v
 <--  ServerRegistry.java
new revision: 1.44; previous revision: 1.43
done
Checking in
src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java,v
 <--  RegistryNodeProvider.java
new revision: 1.11; previous revision: 1.10
done
Checking in
test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistryTest.java;
/cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistryTest.java,v
 <--  ServerRegistryTest.java
new revision: 1.6; previous revision: 1.5
done
Comment 7 Pavel Buzek 2005-08-03 17:25:01 UTC 
after the rollback I added the changes again with one more change in ServerInstance:

Checking in src/org/netbeans/modules/j2ee/deployment/config/ConfigSupportImpl.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigSupportImpl.java,v
 <--  ConfigSupportImpl.java
new revision: 1.39; previous revision: 1.38
done
Checking in
src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigurationStorage.java,v
 <--  ConfigurationStorage.java
new revision: 1.46; previous revision: 1.45
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/Server.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/Server.java,v  <--
 Server.java
new revision: 1.32; previous revision: 1.31
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java,v
 <--  ServerInstance.java
new revision: 1.59; previous revision: 1.58
done
Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v
 <--  ServerRegistry.java
new revision: 1.46; previous revision: 1.45
done
Checking in
src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ui/RegistryNodeProvider.java,v
 <--  RegistryNodeProvider.java
new revision: 1.13; previous revision: 1.12
done
Checking in
test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistryTest.java;
/cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistryTest.java,v
 <--  ServerRegistryTest.java
new revision: 1.8; previous revision: 1.7
done

additional fix in app server:

Checking in
appsrv81/src/org/netbeans/modules/j2ee/sun/ide/dm/SunDeploymentManager.java;
/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/dm/SunDeploymentManager.java,v
 <--  SunDeploymentManager.java
new revision: 1.5; previous revision: 1.4
done
Comment 8 Dan Kolar 2006-08-30 11:09:47 UTC 
v.