This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57381 - save cookie not enabled on changes
Summary: save cookie not enabled on changes
Status: CLOSED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 8 (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ pcw
URL:
Keywords:
: 257380 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-03 04:00 UTC by _ ludo
Modified: 2016-01-20 15:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
context diff of the patch for this fix. (5.58 KB, text/plain)
2005-04-09 00:55 UTC, _ pcw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ ludo 2005-04-03 04:00:04 UTC
Using the  BP j2ee doc oriented sample: any edit in the sun web.xml port
information for service ref does not trigger the save cookie: lost of
info: P2
Comment 1 _ ludo 2005-04-07 01:56:30 UTC
We need an update on this P2 now.
Thanks,
Comment 2 _ ludo 2005-04-08 04:01:02 UTC
Still no update...Please, we need an update, as I told you today by phone.
Comment 3 _ pcw 2005-04-09 00:54:36 UTC
The code for the sub panel that allows port information editing was not setting
the dirty flag on the bean when it was persisting the data.

Port information at this detail level is not a property on the DConfigBean so
the dirty flag needs to be set explicitly when the data is changed.
Comment 4 _ pcw 2005-04-09 00:55:22 UTC
Created attachment 21508 [details]
context diff of the patch for this fix.
Comment 5 Nitya Doraisamy 2005-04-12 23:11:27 UTC
Fix reviewed in trunk.
Comment 6 L Martinek 2005-04-13 09:51:58 UTC
verified in trunk
Comment 7 L Martinek 2005-04-13 09:52:49 UTC
verified in trunk
Comment 8 L Martinek 2005-04-13 09:56:39 UTC
status should be RESOLVED when it's fix only in trunk
Comment 9 L Martinek 2005-04-13 09:57:13 UTC
status should be RESOLVED when it's fix only in trunk
Comment 10 _ ludo 2005-04-14 19:30:51 UTC
Added in the 4.1 branch of the plugin
Comment 11 L Martinek 2005-04-15 13:28:24 UTC
It's not in latest build. When you will put plugin code to build?
Comment 12 _ ludo 2005-04-15 16:05:37 UTC
it is for me... Which steps do you follow?
org-netbeans-modules-j2ee-sun-ide-nbms.zip.scrambled 
Revision : 1.14.2.7
Date : 2005/4/14 23:11:57
Author : 'ludo'
State : 'Exp'
Lines : +7689 -7579
Description :
Fix in 4.1 for 57381 - in ServiceRef customizer, port info panel, changing port
information
of an existing port did not set the dirty flag on the bean.  This prevented
sun-web.xml
from being saved because the IDE did not know it needed to be saved.

Comment 13 _ ludo 2005-04-15 16:06:42 UTC
I also just tested my personal 41 build and it;s ok.
Comment 14 Petr Jiricka 2005-04-15 16:22:56 UTC
I think the question is whether this fix made it into the branch before the
daily build. Daily builds of release41 run at 9:30pm PRG time (12:30pm
California time).
Comment 15 _ ludo 2005-04-15 16:28:10 UTC
I did the change in branch at:
Tag: release41
User: ludo    
Date: 05/04/14 16:12:14   (This is Pacific Time)

Modified:
 /j2ee/external/
  org-netbeans-modules-j2ee-sun-ide-nbms.zip.scrambled

Log:
 Fix in 4.1 for 57381 - in ServiceRef customizer, port info panel, changing port
information
 of an existing port did not set the dirty flag on the bean.  This prevented
sun-web.xml
 from being saved because the IDE did not know it needed to be saved.

File Changes:

Directory: /j2ee/external/
==========================

File [changed]: org-netbeans-modules-j2ee-sun-ide-nbms.zip.scrambled
Url:
http://j2ee.netbeans.org/source/browse/j2ee/external/org-netbeans-modules-j2ee-sun-ide-nbms.zip.scrambled?rev=1.14.2.7&content-type=text/vnd.viewcvs-markup

so I guess it is not in you daily build
Comment 16 L Martinek 2005-04-18 13:10:35 UTC
verified in 4.1 RC1 build
Comment 17 Jiri Prox 2016-01-20 15:44:26 UTC
*** Bug 257380 has been marked as a duplicate of this bug. ***