This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57466 - Sun specific DD is marked as changed after moving cursor
Summary: Sun specific DD is marked as changed after moving cursor
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 8 (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: _ pcw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-05 08:16 UTC by Petr Blaha
Modified: 2007-07-20 21:16 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
stack trace (2.10 KB, text/plain)
2005-04-05 08:17 UTC, Petr Blaha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Blaha 2005-04-05 08:16:25 UTC
[Build 20050403]
Steps:
1) open visual editor sun-ejb-jar.xml
2) select e.g. Jndi name text field
3) press left arrow, the file is marked as changed
4) press Ctrl+S
5) DD isn't saved
I tried to save file about 10 times and then get exception.
Comment 1 Petr Blaha 2005-04-05 08:17:14 UTC
Created attachment 21369 [details]
stack trace
Comment 2 _ ludo 2005-04-05 15:53:25 UTC
Evaluate if this is a p3 or really a p2....
Criteria: changes in the editor should be saved...if there are changes of course.
Comment 3 Rajeshwar Patil 2005-04-05 23:21:56 UTC
I am not able to reproduce the exception part of it.  Ctrl+S is saving the DD
without any exception. save is also harmless i.e DD entries are same as before.
Need to fix the first part. We should not mark the file as changed on cursor
movement.

Comment 4 skyscrap 2005-12-02 20:48:07 UTC
there's something similar strange, you don't even need to move the curser. just
place it in the field for the mapping properties for a CMP entity bean, and the
"*" immedeatly comes back, after saving with ctrl-s. 

if you click the toolbar "save all" it's fine though.
Comment 5 _ pcw 2005-12-02 22:53:36 UTC
I'll take a look at how this is behaving in the current builds and what is left
to do.

1) 4.1 had lots of unnecessary or just flat out incorrect property change events
being propagated.  This is fixed in 5.0 Beta 2 and later dev builds.

2) I recently identified a bug with how the Sun Configuration DataObject is
handling SaveCookies that could explain this bug, as well as some other save
related bugs that have been filed.
Comment 6 _ pcw 2006-01-05 00:40:24 UTC
There are two bugs here:

1) The assertion described in this bug in the second comment
("java.lang.AssertionError: SaveCookie found for ... ConfigBeanNode@17dd37f") is
a duplicate of issue 66778.

2) The config editor is marked changed when only the arrow key is pressed
because the code behind this says something to the effect of "if ANY key is
pressed, do stuff and mark the file changed".  Regardless of whether a change
actually happened.  This bug should not appear in any panel of the config
editors for Web Applications or EARS, nor in any of the shared customizers
(resource-refs, ejb-refs, service-refs, etc.)

Fixing #2 is too invasive at this point in the schedule and should be deferred
to next version.
Comment 7 _ pcw 2006-08-05 02:41:34 UTC
I have fixed the causes of #2 that were specific to the top sun-ejb-jar
customizer panel.  You can still find this behavior on the individual EJB panels
though.
Comment 8 _ pcw 2006-09-11 19:41:12 UTC
Fix available, not to be committed for 5.5.  I'll commit after 5.5. and this
will be fixed in 6.0.
Comment 9 Vince Kraemer 2007-05-15 17:48:00 UTC
setting TM to match comment
Comment 10 _ pcw 2007-07-20 21:16:37 UTC
Fixed by virtue of new editor design (also true fix to 5.5.1 design committed to 6.0 codebase before redesign in case
anyone ever wanted to backport it.)