This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 61248 - Properties dialog messes up manifest formatting
Summary: Properties dialog messes up manifest formatting
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-21 16:45 UTC by Jesse Glick
Modified: 2005-10-21 11:28 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2005-07-21 16:45:11 UTC 
I opened the properties dialog on the ant module and changed the spec version.
Later I looked at the diff of manifest.mf.

-OpenIDE-Module-Specification-Version: 3.20
+OpenIDE-Module-Specification-Version: 3.21

is fine. But

-OpenIDE-Module-Requires: 
-  org.openide.execution.ExecutionEngine,
-  org.openide.windows.IOProvider
+OpenIDE-Module-Requires:  org.openide.execution.ExecutionEngine, 
org.openide.windows.IOProvider

is not fine. The properties dialog should not try to change this value unless I
actually added or removed a token, which I did not.
Comment 1 Jesse Glick 2005-07-29 04:20:20 UTC 
I can see two problems, at least:

1. ManifestManager.parseTokens uses StringTokenizer(..., ",") but the delimiters
should be ", " instead.

2. SingleModuleProperties.storeManifestChanges should check to see if the old
value of OIDE-M-R was the same as the new value (ignoring delimiters and
ordering) and if so, do not change the line.
Comment 2 Martin Krauskopf 2005-09-02 11:33:33 UTC 
Yes changes are stored everytime. Started...
Comment 3 Martin Krauskopf 2005-09-02 13:25:43 UTC 
Fixed.

Checking in ui/customizer/ComponentFactory.java; 1.35 --> 1.36
Checking in ui/customizer/SingleModuleProperties.java; 1.20 --> 1.21
Checking in test/project/ui/customizer/SingleModulePropertiesTest.java; 1.12 -->
1.13
Comment 4 pzajac 2005-10-21 11:28:00 UTC 
verified