This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 61882 - Properties dialog usage made invalid project.xml
Summary: Properties dialog usage made invalid project.xml
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Krauskopf
URL: http://collab.netbeans.org/source/bro...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-05 18:58 UTC by Jesse Glick
Modified: 2005-11-08 16:19 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2005-08-05 18:58:25 UTC 
See diff. I assume Petr just used the GUI dialog to edit project.xml. But now
<class-path-extension> is at the top, which is wrong - won't validate.
Comment 1 Petr Nejedly 2005-08-05 21:24:20 UTC 
Not only that, it have also added artifical /1 to my org.openide.filesystems
dependency, which made my module unavailable at runtime.
Comment 2 Jesse Glick 2005-08-05 22:57:46 UTC 
I have never known it to add a major release version without your instructions.
Can you reproduce that?
Comment 3 Martin Krauskopf 2005-08-08 09:56:32 UTC 
I've also never noticed the case with an artifical major release version.
Started for the rest....
Comment 4 Petr Nejedly 2005-08-08 10:44:23 UTC 
Strange, I tried reproducing the problem by starting over from
collab/output/nbproject/project.xml,v1.4
and unchecking/checking impl dependency on core/output2
and it generated the project.xml exactly the same as v1.8, that is, completly
correct.
Comment 5 Jesse Glick 2005-08-08 17:36:15 UTC 
Well, WORKSFORME unless a test case can be found.

BTW Martin it is a good idea in unit tests for the code that writes project.xml
to validate against schema. Cf. dkonecny's tests for ant/freeform.
Comment 6 Petr Nejedly 2005-08-09 09:13:20 UTC 
OK, works even for me now.
Comment 7 Martin Krauskopf 2005-08-09 09:44:58 UTC 
But the problem with class-path-extension is still there. Easily reproduced.

1) open j2eeserver/j2eeapis project
2) add some friend
3) xml becomes invalid

I'll add a validation check to all ProjectXMLManager tests and fix this.
Comment 8 Martin Krauskopf 2005-09-12 14:02:48 UTC 
Starting... means also complete rewriting of the ProjectXMLManagerTest and also
hopefully completely getting rid of example-external-projects - which can be
deteled then. Or are they needed for something else Jesse? (I'll ensure that
none of other tests are using them, ProjectXMLTest is the last heavily dependend
test AFAIK)
Comment 9 Martin Krauskopf 2005-09-12 21:00:52 UTC 
Fixed.

Checking in ProjectXMLManager.java; 1.37 --> 1.38
Checking in project/ProjectXMLManagerTest.java; 1.23 --> 1.24
Comment 10 pzajac 2005-11-08 16:19:01 UTC 
v