This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
[#200508091800] The difference between edited/saved file from cvs is just in color in its name. There should be some next difference - not only color (maybe icon badging?)- because it breaks accessibility rules. There is impact to disabled users that are not able to distinguish colors correctly. See attached screenshot of current state.
Created attachment 23656 [details] Screenshot attached...
This is as designed, we do not want to have unnecessary things in important views (see old VCS support with statuses, revisions, badges). If someone is unable to distinguish default colors, we plan to make these colors customizable. Assigning to Jano for evaluation.
I was not able to see difference between blue and black on some LCD displays while running on WinXP (although I don't have problems with my eyes). Customizable colors could be fine, but it is not enough IMHO (color should not be the only attribute to differentiate statuses). Jano, please evaluate this issue.
IMHO Versioning view is enough for satisfying A11Y.
Jara is right. There has to be some way (except the colors) to know that the file the user selected either in the editor or in Projects window is modified, new or contains local conflict. This is mostly for A11Y reasons but also for new users. We can do one of the following (or its combination): * show file status in node and editor tab labels for modified, new and conflict files. By default this would not be turned on, the user should be able to do it through View menu. Something like: "View | Show CVS Status Labels". This would be helpful for color blind users. * make the colors customizeable in the options dialog. This would help color blind but also people with certain monitors where default colors are not recognized. * show the status text description in tooltips, which means it will also appear in a11y description of nodes and editor tabs. This is also needed for explaining what the colors mean for all new users. This is not very useful for color blind users, I guess. I tend to say that we should implement all options at some point. I don't know what the priority is, though.
And more: Default color settings should be selected in such way that on majority of devices users will be able to distinguish the colors. I wasn't able to distinguish blue color from black color on my laptop.
Milan: How can we choose good set of default colors if laptops have problems displaying blue and black differently?! Jano: 1) Great for disabled users but pain for others. An option is good, where to put it? Would -J-D option be enough in this case? 2) Great for users, no time to implement this from our side. 3) Not sure if tooltip is the right place and also if this can be done now.
Waiting for more feedback.
If we cannot select such set of colors for all devices that our users are using we need something more to show the status. What kind of "more feedback" are you expecting? I think we should do something with this issue. Not just wait.
Implementation-wise, none of the suggested solution seem to be ideal nor doable for this release. Too much for the first version, not speaking about being too late in the dev. cycle. A user can use the 'Show Changes' action to get accessible information on statuses, this action is context-sensitive and works on the project(s) level as well as for the individual folders / files. Agreed to need to reconsider this for future --> changing to RFE.
> Too much for the first version, not speaking about being too late in the dev. cycle. Disagree, there is no exception for first/last version, it has to be accessible. This issue was reported two weeks after merging new CVS support to the trunk, more than a month ago, so I disgree with the time issue. > Agreed to need to reconsider this for future --> changing to RFE. This isn's reason to change it to RFE. This issue as a defect. Just to be sure you understand, the priority of this type of problem is P1 (look at http://qa.netbeans.org/processes/bug_priority_guidelines.html) -------- P1 A11Y defect: Color is being used as the only cue to the user and the bug would affect a large group of color-blind users, e.g. a green button changes to red as a warning ------- So we agreed to decrees priority to P2, but we disagree with changing the type (I can say speaking for QA at all).
>>Disagree, there is no exception for first/last version, it has to be accessible. Not sure we are on the same page here -- like Maros said, we do not currently have a good solution for the problem and we need to gather more user data to know what would be the right one (that's why the 'INCOMPLETE' keyword). Can't solve everything in the first version. In the meantime, 'Show Changes' action provide accessible information on the statuses. We can either have the current solution for showing statuses in explorer / editor tabs, or we can cancel this feature completely for this release. I do not believe the last option would follow the spirit of the A11Y guidelines, though it would probably satisfy the letter of those.
About jrojcek's remarks: I think we should implement all proposals but I'm not sure what is easy to do for this release. Is someone able to give me some estimate for the following "solutions"? 1. show file status in node and editor tab labels for modified, new and conflict files Is to possible to get the code and icons from 4.1 and use them for this release? If so how much work will it be to use them? 2. make the colors customizeable in the options dialog Does doesn't really sound like too much work, but it will never satisfy the A11Y I guess. I think this is a nice to have for this release. 3. show the status text description in tooltips Seems like little work(?) Satisfies A11Y I think and is a great help for new users. Why not implement this for the current release and put the other two in an RFE? Is someone able to point out if no. 3 will satisfy A11Y? If so I'm willing to take a look at it. Sincerely, Patrick Holthuizen
Thanks Patrick for your help. We have this issue on radar and we're looking for the right solution for NetBeans 5.0 release. We would like to fix this one tohether with issue #65583 like this: Show (optional) status labels next to file and folder nodes in Project, File and Favorite windows. The labels would look like in the attached image showing info about file status (New, Modified, Conflict, Ignored) and branch name if it's not trunk. Same labels would also show up in editor tabs. Please comment the proposed solution.
Created attachment 25572 [details] CVS status labels - proposal
Proposal by Jano sounds great for me.
Textual CVS annotations can now be turned on/off in the View menu. /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/syncview/SyncTable.java,v <-- SyncTable.java new revision: 1.17; previous revision: 1.16 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/syncview/SyncFileNode.java,v <-- SyncFileNode.java new revision: 1.8; previous revision: 1.7 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/util/Utils.java,v <-- Utils.java new revision: 1.31; previous revision: 1.30 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/commit/CommitTable.java,v <-- CommitTable.java new revision: 1.10; previous revision: 1.9 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/Bundle.properties,v <-- Bundle.properties new revision: 1.22; previous revision: 1.21 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/FileInformation.java,v <-- FileInformation.java new revision: 1.10; previous revision: 1.9 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/FileStatusProvider.java,v <-- FileStatusProvider.java new revision: 1.9; previous revision: 1.8 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/Annotator.java,v <-- Annotator.java new revision: 1.17; previous revision: 1.16 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/resources/layer.xml,v <-- layer.xml new revision: 1.14; previous revision: 1.13 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/diff/Setup.java,v <-- Setup.java new revision: 1.12; previous revision: 1.11 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/settings/CvsModuleConfigBeanInfo.java,v <-- CvsModuleConfigBeanInfo.java new revision: 1.4; previous revision: 1.3 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/settings/CvsModuleConfig.java,v <-- CvsModuleConfig.java new revision: 1.6; previous revision: 1.5 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/ShowTextAnnotationsAction.java,v <-- ShowTextAnnotationsAction.java initial revision: 1.1 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/Bundle.properties,v <-- Bundle.properties new revision: 1.7; previous revision: 1.6
Adding annotations to package nodes. /shared/data/ccvs/repository/java/project/src/org/netbeans/spi/java/project/support/ui/PackageViewChildren.java,v <-- PackageViewChildren.java new revision: 1.64; previous revision: 1.63
Maros & Jano, I see your implementation in NB5.0(200510201800) and I have to say: - it's fine in Explorer, there is a space for long line names - it doesn't look nice and useful on editor tabs. The other days I was able to have opened 7 files at the same time with all tabs visible, but there are only 3 visible tabs now. I think this will be highly commented and it isn't improvement. So please think about another solution for the editor tabs. I think the toolltip would be good and fast solution. Or just add badging to the icons ....
I do not know WHERE this annotation will appear. So from my point of view, it will either exist on both (all) places or nowhere.
I have turned CVS annotations back off by default. I also consider this A11Y bug fixed so if you feel like there should be no [Modified] labels in editor tabs, please file a separate issue. /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/settings/CvsModuleConfig.java,v <-- CvsModuleConfig.java new revision: 1.8; previous revision: 1.7 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/Annotator.java,v <-- Annotator.java new revision: 1.24; previous revision: 1.23 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/ShowTextAnnotationsAction.java,v <-- ShowTextAnnotationsAction.java new revision: 1.4; previous revision: 1.3
Verified.