This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Please review the following changes of the j2eeserver API. These changes are necessary in order to implement the Server UI changes (see http://j2eeserver.netbeans.org/j2ee-server-ui-spec-promof.html) and issue 55640. Impacted interfaces: org.netbeans.modules.j2ee.deployment.devmodules.api.ServerManager - class added org.netbeans.modules.j2ee.deployment.plugins.api.UISupport - class added org.netbeans.modules.j2ee.deployment.plugins.api.StartServer - method added
Created attachment 23708 [details] javadoc
Since the change is trivial and compatible using the API_REVIEW_FAST keyword.
Pavel, Jarda, Radim can you please be the reviewers?
I agree with these additions to j2eeserver api.
Looks OK to me. Perhaps an adition about threading for the methods that deals with UI can be added. I'd guess that supportsStartDebugging should return false by default to be more defensive but have no strong opinion here.
UISupport looks ok to me. I have no clue/opinion about the rest as I cannot imagine how to use the methods and for what, so I cannot verify if the API is the best for potential usecases. Sorry.
Stepane, I understend Jarda's concern about use cases. Radim, Petr and I all know j2eeserver problems too well :-) but it would be worth describing for Jarda.
Created attachment 23724 [details] updated javadoc
I have updated the javadoc based on Radim's comments. I agree that the supportsStartDebugging method should return false by default (I will update all the plugins accordingly). Here is what the other methods are good for: ServerManager.showCustomizer() will be used from various places outside the j2eeserver to access the Server Manager. Some of these places are: new web/j2ee project wizards, web/j2ee project properties, missing server dialog. StartServer.supportsStartDebugging() will be used to disable/enable the "Start in Debug Mode" menu item in the server instance context menu.
If there are no farther comments or objections, I am going to commit these changes to trunk.
F. Checking in apichanges.xml; /cvs/j2eeserver/apichanges.xml,v <-- apichanges.xml new revision: 1.16; previous revision: 1.15 done Checking in nbproject/project.xml; /cvs/j2eeserver/nbproject/project.xml,v <-- project.xml new revision: 1.11; previous revision: 1.10 done Checking in src/org/netbeans/modules/j2ee/deployment/devmodules/api/ServerManager.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/api/ServerManager.java,v <-- ServerManager.java new revision: 1.2; previous revision: 1.1 done Checking in src/org/netbeans/modules/j2ee/deployment/plugins/api/StartServer.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/StartServer.java,v <-- StartServer.java new revision: 1.8; previous revision: 1.7 done Checking in src/org/netbeans/modules/j2ee/deployment/plugins/api/UISupport.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/UISupport.java,v <-- UISupport.java new revision: 1.2; previous revision: 1.1 done