This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 62824 - Suite properties are not reloaded after second invocation
Summary: Suite properties are not reloaded after second invocation
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-23 02:18 UTC by _ tboudreau
Modified: 2005-12-02 15:01 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2005-08-23 02:18:53 UTC
I created a new module in a suite.  When I opened properties for the suite, the
new module was not in the list of libraries.  So I added it.  After that, it
appeared once in the list.  However, it was really added twice here is the
project.properties:

modules=\
    ${project.JDom}:\
    ${project.Rome}:\
    ${project.FeedReader}:\
    ${project.FeedReader}
project.FeedReader=FeedReader
project.JDom=JDom
project.Rome=Rome

This resulted in a rather confusing error message:

C:\space\netbeans\harness\build.xml:45: java.io.IOException: Duplicated module
org.netbeans.modules.feedreader: found in
C:\feedreader\FeedReaderSuite\FeedReader and
C:\feedreader\FeedReaderSuite\FeedReader

Probably it should handle this situation somehow more intelligently.
Comment 1 Rich Unger 2005-08-23 02:23:29 UTC
I'm just a few hours ahead of you, Tim :)

*** This issue has been marked as a duplicate of 62819 ***
Comment 2 Martin Krauskopf 2005-08-23 08:20:13 UTC
Yup. Problem is that suite properties doesn't reload themself when they are
called second time. The same problem was already fixed for a module's
properties. It is... ehm... known bug in our office, Rakek already told me about
it... ok, I'll fix it soon :)

Also let's keep issue #62819 for "prevent dupes" case as its subject says.
Comment 3 Martin Krauskopf 2005-08-25 01:03:35 UTC
I'll unify a behaviour of suite and single-module customizers. Also have to
consider what have to be refreshed. Let's say started.
Comment 4 Martin Krauskopf 2005-08-25 14:57:14 UTC
Fixed. See commit log bellow for details. Please Jardo and Radku check your
panels (SuiteCustomizerBasicBranding and SuiteCustomizerModuleList). There is
"new" method refresh(). Also check SuiteProperties.refresh() is you need so.

Commit log message:
 \#62824: Suite properties are not reloaded after second invocation
 1. bigger refactoring of both customizers, i.e. there is now BasicCustomizer
which do most of the work - I hope nothing got broken
 2. suite panels are informed when they are reloaded
 3. suite customizer automatically gain an ability to remember lastly selected
category
 4. all panels are ready for validation task (ability to enable/disable OK button)
 (still some ugly places to be refactored.... later)

Checking in ui/customizer/BasicCustomizer.java; new
Checking in ui/customizer/ComponentFactory.java; 1.32 --> 1.33
Checking in ui/customizer/CustomizerCompiling.java; 1.3 --> 1.4
Checking in ui/customizer/CustomizerDisplay.java; 1.20 --> 1.21
Checking in ui/customizer/CustomizerDocumenting.java; 1.4 --> 1.5
Checking in ui/customizer/CustomizerLibraries.java; 1.27 --> 1.28
Checking in ui/customizer/CustomizerPackaging.java; 1.6 --> 1.7
Checking in ui/customizer/CustomizerProviderImpl.java; 1.38 --> 1.39
Checking in ui/customizer/CustomizerSources.java; 1.10 --> 1.11
Checking in ui/customizer/CustomizerVersioning.java; 1.23 --> 1.24
Checking in ui/customizer/ModuleProperties.java; 1.5 --> 1.6
Checking in ui/customizer/NbPropertyPanel.java; 1.8 --> 1.9
Checking in ui/customizer/SingleModuleProperties.java; 1.18 --> 1.19
Checking in ui/customizer/SuiteCustomizer.java; 1.6 --> 1.7
Checking in ui/customizer/SuiteCustomizerBasicBranding.java; 1.2 --> 1.3
Checking in ui/customizer/SuiteCustomizerLibraries.java; 1.8 --> 1.9
Checking in ui/customizer/SuiteCustomizerModuleList.java; 1.2 --> 1.3
Checking in ui/customizer/SuiteProperties.java; 1.7 --> 1.8

Comment 5 pzajac 2005-12-02 15:01:29 UTC
verified