This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 63226 - Some nodes from layers are not localized
Summary: Some nodes from layers are not localized
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-29 11:07 UTC by Martin Krauskopf
Modified: 2005-12-23 10:54 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
bad localized names (136.72 KB, image/png)
2005-08-29 20:05 UTC, Martin Krauskopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2005-08-29 11:07:46 UTC
Expand for example XML Layer node -> <this layer in context> -> Menu Bar ->
Edit. I believe that by solving this issue you will also solve the same problem
in Action wizard (and may be others). Also may be bad component, since this
could be problem of FS module. CCing Radek....
Annoying (mainly) in Action wizard -> P2.
Comment 1 Jesse Glick 2005-08-29 18:22:37 UTC
"Edit" *is* the localized name of this menu (as well as its code name). Compare
e.g. Menu/GoTo which is displayed (for me anyway) as "Go To", as expected.
Comment 2 Martin Krauskopf 2005-08-29 20:04:55 UTC
> "Edit" *is* the localized name of this menu (as well as its code name).

I didn't talk about "Edit" menu itself, but about items it contains. See the
attached screenshot.

Files under "Go To" (or under "Edit", or...) folder are not localized - the same
problem as with the wizard on the screenshot. I don't know but I think it is the
same problem. Names should be localized in the same manner when user goes to "Go
To" menu in the ide.

> Menu/GoTo which is displayed (for me anyway) as "Go To", as expected.

"GoTo" under <this layer> vs. "Go To" under <this layer in context> - should be
the same.

Comment 3 Martin Krauskopf 2005-08-29 20:05:57 UTC
Created attachment 24321 [details]
bad localized names
Comment 4 Jesse Glick 2005-08-29 21:29:09 UTC
It's just .shadow files, I guess. Can probably put in a special hack for those.

Re. Edit/GoTo: it's correct that it's not localized when under "<this layer>"
because this layer does not define the Edit/ menu and does not set its localized
name. Without some platform module being enabled, the display name of that menu
would in fact be "GoTo".
Comment 5 Jesse Glick 2005-08-29 23:21:17 UTC
OK, will fix for *.shadow.
Comment 6 Jesse Glick 2005-08-29 23:37:12 UTC
Fixed in BadgingSupport + LayerUtilsTest. Seems to work appropriately for the
New Action wizard, but verification would be appreciated.
Comment 7 Martin Krauskopf 2005-08-30 01:16:18 UTC
95% better (as well in action wizard, thanks). But it seems that there are still
some problem - with inner classes. See e.g. XML Layer node --> <this layer in
context> --> Menu Bar --> Edit (or View or Go To) and its underlaying files.
Comment 8 Martin Krauskopf 2005-08-30 01:17:47 UTC
Hmmm, not only inner classes. e.g.
org-netbeans-modules-editor-NbCodeFoldingAction under view menu (show its
hashcode as a suffix.)
Comment 9 Jesse Glick 2005-08-30 02:02:39 UTC
NbCodeFoldingAction: need to deal with Presenter.Menu.

Jump Next etc. - seem to be masked somewhere? May need to deal with _hidden
files (means sorting modules).
Comment 10 Jesse Glick 2005-08-30 05:32:22 UTC
Will deal with Presenter.Menu. I filed a separate issue #63295 to address the
failure of _hidden files to work.
Comment 11 Jesse Glick 2005-08-30 05:37:02 UTC
Failed to write a unit test for it, but anyway, it works now:

committed   * Up-To-Date  1.8        
project/src/org/netbeans/modules/apisupport/project/layers/BadgingSupport.java
committed   * Up-To-Date  1.11       
project/test/unit/src/org/netbeans/modules/apisupport/project/layers/LayerUtilsTest.java
Comment 12 Tomas Danek 2005-12-23 10:54:21 UTC
browsed in XML layer for a while and  did not found any problem with unlocalized
name  -> verified 5.1 trunk