This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 65713 - Too many conversions in o.n.m.w.debug.utils.Utils
Summary: Too many conversions in o.n.m.w.debug.utils.Utils
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Debugger (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Libor Kotouc
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2005-10-03 14:20 UTC by _ rkubacki
Modified: 2005-12-14 13:59 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2005-10-03 14:20:23 UTC 
org.netbeans.modules.web.debug.util.Utils.getFileObjectFromUrl() that is often
called from property change listeners translates URL to File and than File ->
FO. It should be easier to employ URLMapper for this purpose.

It can be more efficient and we can maintain only one piece of code. Also the
normalization performed in URL->File conversion is not fast and we should avoid it.
Comment 1 _ rkubacki 2005-11-04 10:04:54 UTC 
http://web.netbeans.org/source/browse/web/jspdebug/src/org/netbeans/modules/web/debug/actions/JspToggleBreakpointActionProvider.java?r1=1.10&r2=1.11
makes it even worse. we will do the conversion several times in this action
provider.
Comment 2 Libor Kotouc 2005-12-06 08:53:14 UTC 
Fixed.

Checking in util/Utils.java;
/cvs/web/jspdebug/src/org/netbeans/modules/web/debug/util/Utils.java,v  <-- 
Utils.java
new revision: 1.34; previous revision: 1.33
done
Checking in actions/JspToggleBreakpointActionProvider.java;
/cvs/web/jspdebug/src/org/netbeans/modules/web/debug/actions/JspToggleBreakpointActionProvider.java,v
 <--  JspToggleBreakpointActionProvider.java
new revision: 1.12; previous revision: 1.11
done
Comment 3 Jiri Skrivanek 2005-12-14 13:59:05 UTC 
Seems to be fixed.