Also broken on solaris10, maybe depends on LnF?!

Tomasi can you check this again. We tried it yesterday with Zajo and it seems to
work for him. If it doesn't work try to e.g. refresh the screen, or the tree, or
restart the IDE and provide more info. Thanks. Maybe this one is relative to
those test problems on Solaris, just for my information ;).

Still reproducible, but seems like random issue. Now appeared even on WIN XP.
Like "refresh" helped that I set module suite to be an application (by
radiobutton in customizer), after this module node appeared. Attaching
screenshot that proves i'm not kidding:) anyway, not 100% reproducible:(

Created attachment 26126 [details]
MOdule in suite not displayed

Hopefully will be solved together with 67314 issue, thanks to Radek.

Was actually fixed as part of issue 67314. At least I hope. Feel free to reopen
if it happens again.

*** This issue has been marked as a duplicate of 67314 ***

I didn't spot this problem in recent past.. V.

At build 200601052030 it is 100% reproductble (both: at work 1.5.0_06 WinXP and
at home 1.5.0_02 WinXP):



1. New suite
2. New library wrapper

see attachment

Created attachment 28271 [details]
screenshot

How did you actually exactly reproduced? There are more ways to add a module to
your suite. Also if you are adding a module by the help of properties dialog of
a suite, module is effectivelly added until after you click the OK button. And
if the subnode really doesn't appear does it appear at least later. If so, when?
I need more info to solve this. Thanks.

wulgar, you have to add yourself to the CC list if you want to see future
comments. Seem my previous comment (need more info)

Hello

I've generated snapshots by Wink. See attachment

Created attachment 28272 [details]
Wink presentation

Better to attach a generated .swf. But on the otherside you forced me to
download wink which was on my TODO list for some time ;)
Anyway I see the problem and I'm able to reproduce now. Thanks.

I think that the problem is that after we stores nbproject/project.properties
in NbModuleProjectGenerator we will in the end fire an AntProjectEvent and
call SuiteLogicalView.ModuleChildren.propertiesChanged(). Here we will call
SuiteSubprojectProviderImpl.getSubprojects() which finally calls
SuiteProject.eval.getProperty("modules") which is *not* refreshed yet - still
returns old value (empty or null in this case).

First question is whether this is not the bug in PropertyEvaluator. I don't
know that code well yet. But probably depends on the order of firing by
FileSystem?

If it is not a bug (which is presuambly true) what should be the solution?

- listening to SuiteProject.eval "modules" property change instead of
  AntProjectListener

- listining on our SuiteSubprojectProviderImpl - but it never fires a change
  in the current implementation. So we would have to fix it to listen on the
  "modules" property and fire changes accordingly first.

Any hints Jesse. The last seems to me more reasonable, but don't know if the
currect behaviour of SuiteSubprojectProviderImpl is not intentional - i.e.
PropertyEvaluator will not fire change anyway, or...

Last solution (listen to SubprojectProvider) would be ideal; should be simple to
make it fire changes, I was just too lazy to do it before. Listening to change
in ${modules} directly would be OK too, but no easier than making SubprjProv do
the right thing. The current code - attaching an AntProjectListener directly -
is not very good; the events it gets are too low-level.

Ok. I'll do so (last solution).

*** Issue 71090 has been marked as a duplicate of this issue. ***

Should be fixed now. wulgar, could you verify this? Thanks.

NbModuleProjectGenerator.java; 1.43 -> 1.44;
suite/SuiteSubprojectProviderImpl.java; 1.2 -> 1.3;
ui/SuiteLogicalView.java; 1.24 -> 1.25;
test/unit/suite/SuiteSubprojectProviderImplTest.java; 1.1
test/unit/ui/SuiteLogicalViewTest.java; 1.7 -> 1.8;

It's working at Nb5.1 build 200601092030

Just improving summary.

*** Issue 72567 has been marked as a duplicate of this issue. ***