This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67124 - ModuleList.getModuleList() is parsing NB project XML when getting actions for project popup
Summary: ModuleList.getModuleList() is parsing NB project XML when getting actions for...
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2005-10-19 14:19 UTC by Antonin Nebuzelsky
Modified: 2005-12-20 14:18 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
OptimizeIt screenshot (34.30 KB, image/png)
2005-10-19 14:20 UTC, Antonin Nebuzelsky 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2005-10-19 14:19:13 UTC 
See the attached OptimizeIt screentshot. I see there that a lot time is spent in
ModuleList.getModuleList() calling into parseData() and parsing project's XML. I
remember I saw this call sequence and a lot of time spent here at NB project
opening. Is it really necessary to spend the valuable time when popup has to be
created ASAP (within 100ms) here parsing project's XML??? I think this should be
cached somehow or the list of project actions should be already known at the
moment popup wants them.
Comment 1 Antonin Nebuzelsky 2005-10-19 14:20:03 UTC 
Created attachment 26127 [details]
OptimizeIt screenshot
Comment 2 Jesse Glick 2005-10-20 20:04:53 UTC 
Sure, we can cache all sorts of things, the question is under which
circumstances the cache will be invalidated. Right now I don't see a very safe
way to cache this.
Comment 3 Antonin Nebuzelsky 2005-10-21 10:08:43 UTC 
> the question is under which circumstances the cache will be invalidated

How about simply checking timestamp of the XML file?

Or a harder way, listening on filesystem change of the XML file, and
invalidating at file change event?
Comment 4 Jesse Glick 2005-10-24 16:53:26 UTC 
A timestamp check might work.
Comment 5 Antonin Nebuzelsky 2005-11-01 11:43:34 UTC 
Jesse, will you have time to write the caching using the timestamp check soon?
Comment 6 Jesse Glick 2005-12-11 04:11:30 UTC 
The call to NbModuleProject.getModuleList from ModuleActions.getProjectActions
was removed a while ago, as part of the fix of issue #59550.
Comment 7 Antonin Nebuzelsky 2005-12-20 14:18:37 UTC 
Verified in profiler.