This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67306 - [50cat] Commit should be enabled if at least one of the items selected has changed
Summary: [50cat] Commit should be enabled if at least one of the items selected has ch...
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 5.x
Hardware: PC Windows XP
: P3 blocker with 4 votes (vote)
Assignee: issues@versioncontrol
Keywords: UI
Depends on:
Reported: 2005-10-21 15:19 UTC by misterm
Modified: 2007-01-04 17:14 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description misterm 2005-10-21 15:19:09 UTC
[ BUILD # : 20051013 ]
[ JDK VERSION : 1.4.2_xx ]

Currently, the Commit action only is enabled if all nodes selected have changed. This is confusing to users and goes against the PLA (principle of least astonishment), especially when the selected node is a form (which contains two files) or a internationalized properties file. These are just implementation details that are usually not perceived by the end user.

Therefore, the Commit action should be enabled whenever one of the selected nodes can actually be commited.
Comment 1 Patrick Keegan 2005-10-21 16:33:45 UTC
Switching to defect. I agree with Michael. I don't care if this is implemented
as designed, it's a defect, unless someone can convince me that most people
really would prefer a different workflow to commit changes to a multi-file node. 
Comment 2 Maros Sandor 2005-10-24 09:27:35 UTC
I do not know for the whole IDE, but CVS actions are enabled on a selection of
files only if they are enabled for every single file in the selection. Here we
try co make Commit an exception (others will follow?). HIE, can you please
comment on this?
Comment 3 Jiri Kovalsky 2005-10-24 09:55:30 UTC
To add my point of view, I understand the idea to count enabled actions as
intersection based on all nodes but IDE should help developer and not teach
him/her logic.
Comment 4 Michel Graciano 2005-10-28 13:27:57 UTC
Other thing that occur, is that you just change the .java file with has a .form
file too. The tab page for this file and node appear with blue color, but the
"Commit" action is disabled.
Comment 5 Michel Graciano 2005-10-28 13:30:53 UTC
I can simulate these problem with .properties files too. If I just change one of
all Locales of this properties file, the "Commit" action is disabled too.
Comment 6 Maros Sandor 2005-11-02 11:05:55 UTC
Commit, Diff, Resolve Conflicts and Revert Modifications actions are now enabled
only if they will have some files to process when invoked on the selected
context. This means that these actions will now be enabled on Project nodes only
if there really are some modified (or conflicting) files inside the project.
This also means that Commit/Diff/Revert will be enabled if users select 10 files
and only one of them is modified.

new revision: 1.9; previous revision: 1.8
new revision: 1.15; previous revision: 1.14
new revision: 1.21; previous revision: 1.20
new revision: 1.23; previous revision: 1.22