This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68892 - Target build-launchers in suite.xml
Summary: Target build-launchers in suite.xml
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 5.x
Hardware: PC Windows XP
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-17 11:44 UTC by gaucho72
Modified: 2005-11-18 09:04 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gaucho72 2005-11-17 11:44:35 UTC
${build.launcher.dir}/etc/${app.name}.clusters has incomplete content using a 
relative path for the platform (as described in the README).

Both pathconvert tasks (zip.platform.clusters.duplicates, 
zip.platform.clusters) should use an absolute path in the regexp of the mapper.

That's how it works for me:

<property name="netbeans.dest.dir.hack.absolute" 
location="${netbeans.dest.dir}"/>

        <pathconvert property="zip.platform.clusters.duplicates" pathsep=",">
            <path>
                <fileset dir="${netbeans.dest.dir}">
                    <selector refid="zip.platform.included.files"/>
                </fileset>
            </path>
            <mapper type="regexp" from="^\Q${netbeans.dest.dir.hack.absolute}\E
[/\\]([^/\\]+)" to="\1"/>
        </pathconvert>
        
        <dirset dir="${netbeans.dest.dir}" id="platform.clusters" 
includes="${zip.platform.clusters.duplicates}"/>
        
        <pathconvert property="zip.platform.clusters" 
pathsep="${line.separator}">
            <path>
                <dirset refid="platform.clusters"/>
            </path>
            <mapper type="regexp" from="^\Q${netbeans.dest.dir.hack.absolute}\E
[/\\]([^/\\]+)" to="\1"/>
        </pathconvert>
Comment 1 Jesse Glick 2005-11-17 19:18:28 UTC
Good point. BTW the best way to suggest fixes is a formal patch against CVS sources:

http://www.netbeans.org/community/contribute/patches.html

This ensures that there is no ambiguity in what you are suggesting, and makes it
easy in most cases to apply the fix even if other unrelated fixes have been made
to the same file.

Looks like run.xml needs to be patched as well for the same reason.
Comment 2 Jesse Glick 2005-11-18 05:51:13 UTC
Please verify fix.

committed   * Up-To-Date  1.13        apisupport/harness/release/run.xml
committed   * Up-To-Date  1.24        apisupport/harness/release/suite.xml
Comment 3 gaucho72 2005-11-18 09:04:21 UTC
Works for me.