This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I was wondering why Find Usages even for private methods is that slow. I found out, that it is J2EE refactoring plugins, which introduced this regression. See thread dump. I don't use Find Usages with J2EE projects.
Created attachment 27964 [details] Thread dump
The problem seems to be in getRelevantEjbModules(), which goes through all source roots from GlobalPathRegistry a tries to find relevant EjbModules. Can J2SE project have any relevant EjbModules? Can NbModule project have any relevant EjbModules. I hope, that performance getRelevantEjbModules() can be easily improved.
Honzo, do you know the exact impact of this performance issue? We discussed within the J2EE team and we think this could be waived. Would you agree?
J2SE module can act as library for J2EE modules. Anyway, we should fix it at least for private methods.
Fixed in trunk. Honzo, Martin, please review. Its fixed as we discussed, but fix itself is finally much simplier than I presented before. /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/Utility.java,v <-- Utility.java; new revision: 1.27; previous revision: 1.26
Fix looks fine.
Fix verified in trunk build. Please, merge the fix in release50 branch.
Fixed in release50 branch. /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/Utility.java,v <-- Utility.java; new revision: 1.26.2.1; previous revision: 1.26