This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70619 - J2EE refactoring plugins unacceptably degrades performance of Find Usages and probably other refactorings
Summary: J2EE refactoring plugins unacceptably degrades performance of Find Usages and...
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Adamek
URL:
Keywords: PERFORMANCE, REGRESSION
Depends on:
Blocks:
 
Reported: 2005-12-20 09:30 UTC by Jan Becicka
Modified: 2006-01-06 13:21 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Thread dump (2.92 KB, text/plain)
2005-12-20 09:31 UTC, Jan Becicka 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2005-12-20 09:30:21 UTC 
I was wondering why Find Usages even for private methods is that slow. I found
out, that it is J2EE refactoring plugins, which introduced this regression. See
thread dump. I don't use Find Usages with J2EE projects.
Comment 1 Jan Becicka 2005-12-20 09:31:58 UTC 
Created attachment 27964 [details]
Thread dump
Comment 2 Jan Becicka 2006-01-03 10:35:00 UTC 
The problem seems to be in getRelevantEjbModules(), which goes through all
source roots from GlobalPathRegistry a tries to find relevant EjbModules. Can
J2SE project  have any relevant EjbModules? Can NbModule project have any
relevant EjbModules. I hope, that performance getRelevantEjbModules() can be
easily improved.
Comment 3 Petr Jiricka 2006-01-03 13:18:19 UTC 
Honzo, do you know the exact impact of this performance issue? We discussed
within the J2EE team and we think this could be waived. Would you agree?
Comment 4 Martin Adamek 2006-01-03 13:37:16 UTC 
J2SE module can act as library for J2EE modules. Anyway, we should fix it at
least for private methods.
Comment 5 Martin Adamek 2006-01-04 15:26:58 UTC 
Fixed in trunk. Honzo, Martin, please review. Its fixed as we discussed, but fix
itself is finally much simplier than I presented before.
/cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/Utility.java,v 
<--  Utility.java; new revision: 1.27; previous revision: 1.26
Comment 6 Jan Becicka 2006-01-04 15:43:23 UTC 
Fix looks fine.
Comment 7 Petr Blaha 2006-01-05 13:58:18 UTC 
Fix verified in trunk build. Please, merge the fix in release50 branch.
Comment 8 Martin Adamek 2006-01-06 13:21:33 UTC 
Fixed in release50 branch.
/cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/Utility.java,v 
<--  Utility.java; new revision: 1.26.2.1; previous revision: 1.26