71154 – FindBugs tool issues in source code

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71154 - FindBugs tool issues in source code

Summary: FindBugs tool issues in source code

Status:	RESOLVED FIXED

Alias:	None

Product:	serverplugins
Classification:	Unclassified
Component:	Tomcat (show other bugs)
Version:	5.x
Hardware:	All All

Importance:	P3 blocker (vote)
Assignee:	Sherold Dev

URL:
Keywords:

Depends on:
Blocks:

Reported:	2006-01-09 08:38 UTC by Lukasz Grela
Modified:	2006-08-30 15:36 UTC (History)
CC List:	0 users

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
findbugs report (54.41 KB, text/xml) 2006-01-09 09:01 UTC, Lukasz Grela	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lukasz Grela 2006-01-09 08:38:57 UTC

#09012006 look at attachment

Comment 1 Lukasz Grela 2006-01-09 09:01:37 UTC

Created attachment 28287 [details]
findbugs report

Comment 2 Pavel Buzek 2006-01-10 03:10:39 UTC

findbugs issue do not need to be fixed in 5.0

Comment 3 Sherold Dev 2006-01-10 10:49:07 UTC

tm -> 5.1

Comment 4 Sherold Dev 2006-08-30 15:36:09 UTC

Cleaning up the code based on the PMD report, closing the issue as FIXED

Checking in tomcat5/src/org/netbeans/modules/tomcat5/TomcatManager.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/TomcatManager.java,v 
<--  TomcatManager.java
new revision: 1.76.6.2.2.7; previous revision: 1.76.6.2.2.6
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/TomcatManagerImpl.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/TomcatManagerImpl.java,v
 <--  TomcatManagerImpl.java
new revision: 1.41.10.2.2.7; previous revision: 1.41.10.2.2.6
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/TomcatModuleConfig.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/TomcatModuleConfig.java,v
 <--  TomcatModuleConfig.java
new revision: 1.1.92.4; previous revision: 1.1.92.3
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/customizer/Customizer.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/customizer/Customizer.java,v
 <--  Customizer.java
new revision: 1.3.10.2.2.4; previous revision: 1.3.10.2.2.3
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/customizer/CustomizerDataSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/customizer/CustomizerDataSupport.java,v
 <--  CustomizerDataSupport.java
new revision: 1.2.12.2.2.4; previous revision: 1.2.12.2.2.3
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/customizer/CustomizerSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/customizer/Attic/CustomizerSupport.java,v
 <--  CustomizerSupport.java
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/ide/DebugSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/ide/DebugSupport.java,v
 <--  DebugSupport.java
new revision: 1.6.30.2; previous revision: 1.6.30.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/ide/MonitorSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/ide/MonitorSupport.java,v
 <--  MonitorSupport.java
new revision: 1.14.30.2; previous revision: 1.14.30.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/ide/StartTomcat.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/ide/StartTomcat.java,v 
<--  StartTomcat.java
new revision: 1.72.6.4.2.7; previous revision: 1.72.6.4.2.6
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/ide/TomcatIncrementalDeployment.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/ide/TomcatIncrementalDeployment.java,v
 <--  TomcatIncrementalDeployment.java
new revision: 1.7.30.3; previous revision: 1.7.30.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/jsps/FindJSPServletImpl.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/jsps/FindJSPServletImpl.java,v
 <--  FindJSPServletImpl.java
new revision: 1.5.30.2; previous revision: 1.5.30.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatInstanceNode.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatInstanceNode.java,v
 <--  TomcatInstanceNode.java
new revision: 1.48.6.2.2.2; previous revision: 1.48.6.2.2.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatRegistryNodeFactory.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatRegistryNodeFactory.java,v
 <--  TomcatRegistryNodeFactory.java
new revision: 1.6.68.2; previous revision: 1.6.68.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatTargetNode.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatTargetNode.java,v
 <--  TomcatTargetNode.java
new revision: 1.6.26.3; previous revision: 1.6.26.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatWebModule.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/TomcatWebModule.java,v
 <--  TomcatWebModule.java
new revision: 1.11.86.2; previous revision: 1.11.86.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/ContextLogAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/ContextLogAction.java,v
 <--  ContextLogAction.java
new revision: 1.2.98.2; previous revision: 1.2.98.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/EditServerXmlAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/EditServerXmlAction.java,v
 <--  EditServerXmlAction.java
new revision: 1.2.62.1.2.3; previous revision: 1.2.62.1.2.2
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/OpenServerOutputAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/OpenServerOutputAction.java,v
 <--  OpenServerOutputAction.java
new revision: 1.1.62.1.2.3; previous revision: 1.1.62.1.2.2
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/OpenURLAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/OpenURLAction.java,v
 <--  OpenURLAction.java
new revision: 1.2.98.2; previous revision: 1.2.98.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/RefreshWebModulesAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/RefreshWebModulesAction.java,v
 <--  RefreshWebModulesAction.java
new revision: 1.1.140.2; previous revision: 1.1.140.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/SharedContextLogAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/SharedContextLogAction.java,v
 <--  SharedContextLogAction.java
new revision: 1.3.68.1.2.3; previous revision: 1.3.68.1.2.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/StartAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/StartAction.java,v
 <--  StartAction.java
new revision: 1.1.140.2; previous revision: 1.1.140.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/StopAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/StopAction.java,v
 <--  StopAction.java
new revision: 1.1.140.2; previous revision: 1.1.140.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/TomcatWebModuleCookie.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/TomcatWebModuleCookie.java,v
 <--  TomcatWebModuleCookie.java
new revision: 1.4.92.2; previous revision: 1.4.92.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/UndeployAction.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/nodes/actions/UndeployAction.java,v
 <--  UndeployAction.java
new revision: 1.2.140.3; previous revision: 1.2.140.2
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/progress/MultiProgressObjectWrapper.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/progress/MultiProgressObjectWrapper.java,v
 <--  MultiProgressObjectWrapper.java
new revision: 1.1.42.2; previous revision: 1.1.42.1
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/progress/ProgressEventSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/progress/ProgressEventSupport.java,v
 <--  ProgressEventSupport.java
new revision: 1.5.140.3; previous revision: 1.5.140.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/EditableProperties.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/EditableProperties.java,v
 <--  EditableProperties.java
new revision: 1.1.4.1.2.2; previous revision: 1.1.4.1.2.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java,v 
<--  LogManager.java
new revision: 1.4.6.2.2.2; previous revision: 1.4.6.2.2.1
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/LogSupport.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/LogSupport.java,v 
<--  LogSupport.java
new revision: 1.1.92.3; previous revision: 1.1.92.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/LogViewer.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/LogViewer.java,v 
<--  LogViewer.java
new revision: 1.7.62.1.2.3; previous revision: 1.7.62.1.2.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/ServerLog.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/ServerLog.java,v 
<--  ServerLog.java
new revision: 1.3.26.3; previous revision: 1.3.26.2
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/TomcatInstallUtil.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/TomcatInstallUtil.java,v
 <--  TomcatInstallUtil.java
new revision: 1.16.30.5; previous revision: 1.16.30.4
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/TomcatProperties.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/TomcatProperties.java,v
 <--  TomcatProperties.java
new revision: 1.2.12.4.2.10; previous revision: 1.2.12.4.2.9
done
Checking in tomcat5/src/org/netbeans/modules/tomcat5/util/Utils.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/util/Utils.java,v  <-- 
Utils.java
new revision: 1.2.12.2.2.4; previous revision: 1.2.12.2.2.3
done
Checking in
tomcat5/src/org/netbeans/modules/tomcat5/wizard/AddInstanceIterator.java;
/cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/wizard/AddInstanceIterator.java,v
 <--  AddInstanceIterator.java
new revision: 1.2.32.3; previous revision: 1.2.32.2
done