This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 73195 - If your project defines the module.javadoc.packages property, build always gets warning
Summary: If your project defines the module.javadoc.packages property, build always ge...
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-02 22:22 UTC by _ tball
Modified: 2006-11-03 19:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch to ParseProjectXml.java to fix issue (1.19 KB, patch)
2006-03-02 22:23 UTC, _ tball 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ tball 2006-03-02 22:22:06 UTC 
If your project defines public packages as well as the module.javadoc.packages
property, its build always gets a warning that the property was changed from the
default.  This makes sense if the property is different than the set of public
packages, but not if they are the same.  The problem is that the package list
builder in nbbuild/antsrc/org/netbeans/nbbuild/ParseProjectXml.java prepends a
comma and adds spaces after each list item.  The attached patch changes the
javadoc packages list builder to be the same as the public packages list builder.

Workaround:  delete the module.javadoc.packages property, but I cannot find
where that is documented.
Comment 1 _ tball 2006-03-02 22:23:39 UTC 
Created attachment 29104 [details]
Patch to ParseProjectXml.java to fix issue
Comment 2 Martin Krauskopf 2006-03-03 03:14:08 UTC 
It both property specify the same package you do not need to specify
module.javadoc.packages at all. It is documented in this way $NB_BIN/harness/README.
Comment 3 _ tball 2006-03-03 03:54:42 UTC 
Not everyone develops modules using the harness...
Comment 4 Jesse Glick 2006-03-03 17:44:52 UTC 
If you're not developing modules using the harness, then what's the problem?
None of these properties are then relevant. And if you are, then as Martin said
you do not need to specify the list of Javadoc packages since it is computed for
you, unless you want to document non-public packages, in which case a warning is
in order. So I still fail to understand the purpose of this patch.

Anyway I agree with the first diff line - initial sep should in fact be "";
current code was a (harmless) typo. But not the second. The public packages list
uses ", " so why should the Javadoc list use ","? I will therefore apply just
the first line.
Comment 5 _ tball 2006-03-03 19:25:13 UTC 
> If you're not developing modules using the harness, then what's the problem?

I'm developing the jackpot module as a "top component", meaning its source tree
is part of (but not yet committed to) the IDE source tree.  You can duplicate
this bug by going to the ant module, for example, and defining a
modules.javadoc.packages property that matches its list of public packages.

> The public packages list uses ", " so why should the Javadoc list use ","? 

The modules I emulated didn't include spaces in their modules.javadoc.packages
properties, so I didn't either.  However I agree with the P5 change, since I
deleted the modules.javadoc.packages property from my project.
Comment 6 Jesse Glick 2006-03-03 23:49:21 UTC 
committed     Up-To-Date  1.40       
nbbuild/antsrc/org/netbeans/nbbuild/ParseProjectXml.java