Problems in:

windows-launcher-src/app.cpp
release/run.xml
release/launchers/app.sh
release/launchers/app.exe
release/launchers/app_w.exe

Really it's a bug in the harness that it hardcoded the platform6 name, so maybe
it can be merged for forward compatibility. Already have run.xml patch working.

Have app.sh patch now too. Awaiting Windows patches.

I can provide the Windows launchers shortly.

I tend to agree re "hardcoded platform6 name". I can change it in the Windows
launcher to look for "platform*", but am not sure it's the solution you're
proposing for the Unix launcher. What do you mean by "merged for forward
compatibility"?

Created attachment 29156 [details]
Updated Windows .exe launchers.

Created attachment 29157 [details]
Windows portion of the launcher patch.

No, I am looking for an analogue of this Unix patch:

-nbexec="$progdir/../platform6/lib/nbexec"
+nbexec=`echo "$progdir"/../platform*/lib/nbexec`

Re. forward compatibility: I mean that today if you use 5.0 + 5.0u1 as your
development environment, you cannot use a dev build as your target platform,
since the platform6 dir will not be found. If we merge the fix, it should work.

Created attachment 29158 [details]
Windows launcher binaries (Take 2).

Created attachment 29159 [details]
Windows launcher diff (Take 2).

Ok, a new patch (Take 2) attached. Not tested exhaustively. I made the same
change to the NB IDE launcher (not integrated yet) and it worked as expected. I
can do more testing tomorrow.

Mergeable fixes:

Checking in apisupport/harness/release/run.xml;
/shared/data/ccvs/repository/apisupport/harness/release/run.xml,v  <--  run.xml
new revision: 1.19; previous revision: 1.18
done
Checking in apisupport/harness/release/launchers/app.exe;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app.exe,v  <--
 app.exe
new revision: 1.4; previous revision: 1.3
done
Checking in apisupport/harness/release/launchers/app.sh;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app.sh,v  <--
 app.sh
new revision: 1.7; previous revision: 1.6
done
Checking in apisupport/harness/release/launchers/app_w.exe;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app_w.exe,v 
<--  app_w.exe
new revision: 1.4; previous revision: 1.3
done
Checking in apisupport/harness/windows-launcher-src/app.cpp;
/shared/data/ccvs/repository/apisupport/harness/windows-launcher-src/app.cpp,v 
<--  app.cpp
new revision: 1.3; previous revision: 1.2
done

Minor changes:

Checking in
apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/csh/proj_props/SuiteCustomizerLibraries.html;
/shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/csh/proj_props/SuiteCustomizerLibraries.html,v
 <--  SuiteCustomizerLibraries.html
new revision: 1.9; previous revision: 1.8
done
Checking in
apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/distribute_plugin/remove_unwanted_modules.html;
/shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/distribute_plugin/remove_unwanted_modules.html,v
 <--  remove_unwanted_modules.html
new revision: 1.3; previous revision: 1.2
done
Checking in
apisupport/project/src/org/netbeans/modules/apisupport/project/universe/NbPlatform.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/universe/NbPlatform.java,v
 <--  NbPlatform.java
new revision: 1.35; previous revision: 1.34
done
Checking in
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/universe/NbPlatformTest.java;
/shared/data/ccvs/repository/apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/universe/NbPlatformTest.java,v
 <--  NbPlatformTest.java
new revision: 1.21; previous revision: 1.20
done

Sample changes which probably don't need to be merged:

Checking in apisupport/samples/PaintApp-suite/nbproject/platform.properties;
/shared/data/ccvs/repository/apisupport/samples/PaintApp-suite/nbproject/platform.properties,v
 <--  platform.properties
new revision: 1.6; previous revision: 1.5
done
Checking in apisupport/samples/feedreader-suite/nbproject/platform.properties;
/shared/data/ccvs/repository/apisupport/samples/feedreader-suite/nbproject/platform.properties,v
 <--  platform.properties
new revision: 1.5; previous revision: 1.4
done

I am sorry, but I have to disagree with use of "platform*". It just is not 
right. It works reliably only if you have just one platformXYZ directory among 
the clusters, but the installation structure expects that there can be more 
than one (for example https://www.jpackage.org/bugzilla/show_bug.cgi?id=197)

Imho the correct solution would be if the build script correctly inserted the 
name of the platform cluster into the launcher.

There was an intend to specify the name of the platform in more general way, 
but it was refused at 4.0 as it make not much sense, that is why I think we 
should not try to introduce that into launchers of our products.

IMO, "platform*" should be fine for the generic app launcher. We don't support
deployment into an existing NB installation structure and API Support packages a
complete app with all clusters included. I'm pretty sure the generic launcher
(with "platform*") should work for 99.9% of users. If anyone needs anything more
sophisticated they should write a custom launcher anyway.

Right, the issue is what happens if you are running apisupport on a hypothetical
NB installation which contains, say, both a platform6 and a platform7 dir. I
guess we won't know for sure until we try it, but I expect it will not work so
smoothly. The default cluster config is to use all clusters detected in the
platform so when making a suite you will need to manually exclude all but one
revision of each cluster you want to use.

Having done that, the launcher should be fine because there should be one and
only one platform* cluster in the app ZIP.

There will be a problem with run.xml since as written it will not work with
multiple platform* clusters even if you have selected only one. I could patch it
to work correctly assuming you have excluded all but one, but it won't help much
because other parts of the harness will croak anyway: <parseprojectxml> does not
ignore excluded clusters yet, so it will give an error when building. Also
apisupport/project is not written to support overlapping clusters, so the GUI
won't work well. Some future rev of apisupport could support such installations
but there's no demand for it at the moment (since there are no such
installations in the field) so it can be deferred.

Ok. We do not have real native packages yet, so there is no need to take care 
about such layout in current version. One day we hopefully will...

Has anyone tested this fix? I would like to merge it, I think, but would
appreciate some more review.

Created attachment 29285 [details]
Proposed minimal patch for apisupport_50u1

I've already tested it in trunk last week. I don't see any problem with unix
version. I'll test it also on Windows today.  

Tried it on Win, IDE 5.0+u1, (+patched launchers-2.zip, and run.xml from trunk)

1) created app in 5.0 against 5.0, build zip, unpack, launch -> works
2) created app in 5.0 against trunk, build zip, unpack, launch -> works

fix seems to me ok (are there more ways how to test launchers?)

I also didn't see any problem on windows. There is only minor Issue #73706. 

Merged:

Checking in apisupport/harness/release/run.xml;
/shared/data/ccvs/repository/apisupport/harness/release/run.xml,v  <--  run.xml
new revision: 1.18.2.2; previous revision: 1.18.2.1
done
Checking in apisupport/harness/release/launchers/app.exe;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app.exe,v  <--
 app.exe
new revision: 1.3.6.1; previous revision: 1.3
done
Checking in apisupport/harness/release/launchers/app.sh;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app.sh,v  <--
 app.sh
new revision: 1.6.2.1; previous revision: 1.6
done
Checking in apisupport/harness/release/launchers/app_w.exe;
/shared/data/ccvs/repository/apisupport/harness/release/launchers/app_w.exe,v 
<--  app_w.exe
new revision: 1.3.6.1; previous revision: 1.3
done
Checking in apisupport/harness/windows-launcher-src/app.cpp;
/shared/data/ccvs/repository/apisupport/harness/windows-launcher-src/app.cpp,v 
<--  app.cpp
new revision: 1.2.8.1; previous revision: 1.2
done

tested again, now updated only by nbms, on windows ok, on solaris9 works too.
Definitly verified.