This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
- there's too big gap betwen the radio buttons and combo boxes. The big gap is also in the next wizard step. - colons are missing in the radio button labels. Should be "Data Source:", not "Data Source". - "Add Connection" should never be selected in combo box. It is selected when the user cancels the "Add Connection" dialog. - "Generate Named Query Annotations for Persistent Fields" is not in the spec. Either should be added to the spec or removed from the implementation. - all created classes should be selected in project window. - the persistence unit warning needs to be placed in the panel, not in the inline error bar. - "Include Related Classes" should be "Include Referenced Classes" according to the spec.
Re. "Add Connection" should never be selected in combo box: I agree with this. What should be selected? The last selected connection or nothing? If the last selected connection, note that selecting a connection causes the wizard to try to connect to it, which displays the Connect dialog (unless, of course, the connection is already connected). So the result of the user pressing Cancel in the New Connection dialog would be a new dialog to popping up...
If the connection was already selected, then the wizard was already connected, right? It doesn't need to connect again.
Not necessarily. I suggest to try it out yourself: select a connection, pretend to realize it's not the one you wanted, so click Cancel in the Connect dialog, choose New Database Connection from the combo box and click Cancel. The previous connection is selected and the Connect dialog displayed. I'm not sure, maybe this is just a corner case. If you are satisfied with how it works, I'm ok with it too and let's leave it the way it is, that is select the previously selected connection when the New Connection dialog is cancelled.
Updated the UI spec. Checking in persistence-ui-spec.html; /cvs/j2ee/www/docs/promog/persistence-ui-spec.html,v <-- persistence-ui-spec.html new revision: 1.11; previous revision: 1.10 done
Fixed. Not possible to select the generated classes in the Projects view, filed issue 80016 for that. Checking in src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Bundle.properties; /cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Attic/Bundle.properties,v <-- Bundle.properties new revision: 1.1.2.3.2.21; previous revision: 1.1.2.3.2.20 done Checking in src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.form; /cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Attic/EntityClassesPanel.form,v <-- EntityClassesPanel.form new revision: 1.1.2.4; previous revision: 1.1.2.3 done Checking in src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.java; /cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Attic/EntityClassesPanel.java,v <-- EntityClassesPanel.java new revision: 1.1.2.15; previous revision: 1.1.2.14 done
The fix for this causes a regression in the fix for issue 74112.