This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 75544 - bluej shall not depend on nbX.Y cluster
Summary: bluej shall not depend on nbX.Y cluster
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: BlueJ (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Antonin Nebuzelsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-26 11:46 UTC by Jaroslav Tulach
Modified: 2007-02-22 10:49 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2006-04-26 11:46:08 UTC
There seems to be serious architecture flaw that puts NetBeans into bad light - we 
require other products based on NetBeans to not use anything that is part of nbX.Y 
cluster and surprisingly our own product bluej is violating this rule.

This has been discussed in thread:
http://ide.netbeans.org/servlets/BrowseList?list=cvs&by=thread&from=441243
Here is the excerpt:

> > > Just a curious question: Why bluej launcher includes nb5.0 cluster? I
> > > believed that the intention was that nb5.0 is "NetBeans Product
> > > Cluster" and as such it shall not be shared with any other product,
> > > like bluej, studio, creator, etc.
> >
> > I think Tonda knows the anwser.
> >
> > -H
>
> If I include only the nbbluej+ide6 clusters, the IDE simply does not
> start. I don't know the reason, but when including nbbluej+ide6+nb5.0
> clusters, it starts as expected.

I see. That shall be easy to fix. This kind of failure happens when you 
specify netbeans.licenseclass and netbeans.importclass in your launcher and 
they do not exist. So just remove these two properties from your nbbluej 
launcher or change them to point to some other class in nbbluej cluster.
Comment 1 Antonin Nebuzelsky 2006-04-26 12:09:28 UTC
This will be fixed after NB/BJ 5.0 BETA.
Comment 2 Antonin Nebuzelsky 2006-05-17 15:04:42 UTC
Removing netbeans.licenseclass and netbeans.importclass from the launcher is
easy and NB/BJ starts without nbX.Y cluster without any problems then.

I think we can do without settings import in the first release of NB/BJ.

But, the accept license dialog is mandatory for a NetBeans product I guess. So,
I should copy the license dialog code to the branding code provided with
nbbluejX.Y cluster, right?
Comment 3 Jaroslav Tulach 2006-05-17 18:53:11 UTC
In ideal world the license dialog would be a bit different, as I expect the 
bluej to not include all the 3rd party libraries NetBeans IDE does. That would 
mean we would have to copy and modify the dialog. Anyway, even if we decided 
to keep the same license, copying is the right approach as that is what we 
suggest to every other product.

Just copy whatever you find interesting in nbX.Y cluster, please.
Comment 4 Antonin Nebuzelsky 2006-05-18 09:34:19 UTC
> In ideal world the license dialog would be a bit different...

Yes, the license will be different. Not necessarily the code.

In future it could make sense to move some things from nbX.Y to platformP.Q -
license dialog, settings import, welcome screen...

For now, I will copy the license dialog code, as well as I already did with the
welcome screen.
Comment 5 Antonin Nebuzelsky 2006-05-18 16:01:09 UTC
Fixed.

Log:
 Eliminating the need for nb5.0 cluster.

Modified:
 /ide/bluej-suite/launcher/
  nbbluej.clusters
 /ide/bluej-suite/launcher/unix/
  nbbluej
 /ide/bluej-suite/launcher/windows/
  nbbluej.cpp, nbbluej.exe, nbbluej_w.exe

Added:
 /ide/bluej-suite/bluej-upgrade/nbproject/
  project.xml, .cvsignore, project.properties
 /ide/bluej-suite/bluej-upgrade/src/org/netbeans/bluej/upgrade/
  AutoUpgradePanel.form, copy5.0, Bundle.properties, layer5.0.xml, Copy.java,
  AutoUpgradePanel.java, IncludeExclude.java, AutoUpgrade.java
 /ide/bluej-suite/bluej-upgrade/
  .cvsignore, build.xml, manifest.mf
 /ide/bluej-suite/bluej-upgrade/src/org/netbeans/bluej/util/
  Util.java
 /ide/bluej-suite/bluej-upgrade/src/org/netbeans/bluej/license/
  AcceptLicense.java, LicensePanel.java, Bundle.properties, LicensePanel.form
 /ide/bluej-suite/bluej-upgrade/test/
  .cvsignore