This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 77026 - Clean profiler flags too aggressive.
Summary: Clean profiler flags too aggressive.
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: _ ludo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-29 16:11 UTC by _ ludo
Modified: 2006-08-26 01:21 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ ludo 2006-05-29 16:11:15 UTC 
Read the post:
>
> Hi! I've got a question concerned with NetBeans SJSAS (GlassFish) integration.
I'm currently developing a profiling plugin for NetBeans IDE and trying to
support SJSAS profiling from NetBeans (like NetBeans Profiler does).
> But I've encountered some problems here - to enable profiling I need to make
some changes to server configuration .xml file - but when I start server the
NetBeans internal startup algorithm cleans all changes to .xml I've made (via
ConfigureProfiler.remove... call).

> The only way I see it can work - is the way the NetBeans Profiler works, but
it is unsatisfactory, because I'll always have my profiler named "NetBeans
Profiler" inside the SJSAS configuration. (see implementation of
ConfigureProfiler.instrument... method).
> Maybe I've missed something?
Comment 1 vladimirkondratyev 2006-06-09 17:16:42 UTC 
What is the status of this request? We are developing YourKit Java Profiler, and
we want to write plug-in to support profiling of SJSAS server whitin NetBenans.

NetBeans contains the code which intentionally removes all profiler tags
excepting JFluid's.

Best regards,
Vladimir Kondratyev
Co-founder, Vice President
YourKit, LLC
http://www.yourkit.com
"Don't get lost in data, get information!"
Comment 2 _ ludo 2006-06-09 21:49:55 UTC 
We will clean the entries that are only relevant to the Nb profiler.

To better fix the bug, it would be nice to get the entries you are adding with
your profiler so that I'll make sure we do not delete them.

Also, FYI, profiling of any server won't work correctly if more than one
profiler is registered as spi. AFAIK whole J2EE profiling API was designed for
*one* installed profiler only. 
I am not sure how you are plugin into NetBeans, and/or want to reuse the same
'Profile' actions or menu items, but your integration might not be as seamless
as the one from Profiler pack.
Comment 3 vitaly_pimenov 2006-06-13 12:17:27 UTC 
We add only one entry to domain.xml, this entry looks like 

<profiler name="NAME" enabled="true">
<jvm-options>-agentpath:somepath</jvm-options>
<jvm-options>-Doption=value</jvm-options>
</profiler>

By the way, we don't reuse 'Profile' actions and menus, and
NetBeans Profiler works fine with YourKit Java Profiler installed
together.

Vitaly Pimenov.
YourKit, LLC
Comment 4 _ ludo 2006-07-31 00:48:12 UTC 
for 5.5
Comment 5 _ ludo 2006-08-26 01:21:11 UTC 
Fix today.
Thanks for verifying soon:-)

The NetBeans profiler name is "NetBeansProfiler"
and this is the only one we delete if the entry is there.


/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ConfigureProfiler.java,v
 <--  ConfigureProfiler.java
new revision: 1.4.2.5.2.6; previous revision: 1.4.2.5.2.5
done
Checking in DomainEditor.java;
/cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/Attic/DomainEditor.java,v
 <--  DomainEditor.java
new revision: 1.1.2.9; previous revision: 1.1.2.8