This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 88302 - fix-test-dependecies does not work for standalone module
Summary: fix-test-dependecies does not work for standalone module
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: pzajac
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-31 08:20 UTC by _ rkubacki
Modified: 2006-11-16 15:31 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2006-10-31 08:20:44 UTC 
I trying to update PMD plugin but 'ant fix-test-dependecies' fails:

java.io.IOException: You must declare either <suite-component/> or <standalone/>
for an external module in /opt/devel/sf/pmd-netbeans
        at org.netbeans.nbbuild.ModuleListParser.<init>(ModuleListParser.java:568)
        at
org.netbeans.nbbuild.FixTestDependencies.getModuleList(FixTestDependencies.java:212)
        at
org.netbeans.nbbuild.FixTestDependencies.execute(FixTestDependencies.java:118)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:275)


If I fix FixTestDependencies:96 to refer to TYPE_STANDALONE I get NPE later
because 'project' property is not set:

--- Nested Exception ---
java.lang.NullPointerException
        at java.io.File.<init>(File.java:194)
        at
org.netbeans.nbbuild.ModuleListParser.scanStandaloneSource(ModuleListParser.java:516)
        at org.netbeans.nbbuild.ModuleListParser.<init>(ModuleListParser.java:562)
        at
org.netbeans.nbbuild.FixTestDependencies.getModuleList(FixTestDependencies.java:212)
        at
org.netbeans.nbbuild.FixTestDependencies.execute(FixTestDependencies.java:118)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:275)

If you want to try you can take sources of PMD plugin either as binary or using
anonymous CVS chechout from pmd.sf.net
Comment 1 _ rkubacki 2006-11-10 08:34:20 UTC 
/shared/data/ccvs/repository/nbbuild/antsrc/org/netbeans/nbbuild/FixTestDependencies.java,v
 <--  FixTestDependencies.java
new revision: 1.12; previous revision: 1.11
Comment 2 pzajac 2006-11-10 10:14:56 UTC 
Thanks
Comment 3 Jesse Glick 2006-11-10 21:27:57 UTC 
Didn't you mean M5? Is this FIXED or not?
Comment 4 pzajac 2006-11-13 14:42:41 UTC 
Yes, it's probably fixed. I have to only test it and write (reuse) test.
Comment 5 pzajac 2006-11-16 15:29:59 UTC 
Verified by test.

RCS file:
/cvs/nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesProjectStandalonePass.xml,v
done
Checking in FixTestDependenciesProjectStandalonePass.xml;
/cvs/nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesProjectStandalonePass.xml,v
 <--  FixTestDependenciesProjectStandalonePass.xml
initial revision: 1.1
done
Checking in FixTestDependenciesTest.java;
/cvs/nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesTest.java,v 
<--  FixTestDependenciesTest.java
new revision: 1.6; previous revision: 1.5
done
RCS file:
/cvs/nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesProjectStandalone.xml,v
done
Checking in FixTestDependenciesProjectStandalone.xml;
/cvs/nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesProjectStandalone.xml,v
 <--  FixTestDependenciesProjectStandalone.xml
initial revision: 1.1
done
Comment 6 pzajac 2006-11-16 15:31:48 UTC 
v