This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 90595 - Corrupted sequence diagram after font change/reload
Summary: Corrupted sequence diagram after font change/reload
Status: VERIFIED FIXED
Alias: None
Product: uml
Classification: Unclassified
Component: Diagram Sequence (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Sergey Petrov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-05 14:32 UTC by Sergey Petrov
Modified: 2008-07-29 21:56 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
good diagram (242.96 KB, image/png)
2006-12-05 14:34 UTC, Sergey Petrov
Details
corrupted diagram/data loss (495.16 KB, image/png)
2006-12-05 14:35 UTC, Sergey Petrov
Details
open sequecnce diagram, select all, change font size to 36 (70.01 KB, application/octet-stream)
2007-02-14 14:57 UTC, Sergey Petrov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Petrov 2006-12-05 14:32:35 UTC
reproducible with 061201

steps: 
1. create diagram from first screenshot
2. select all lifelines and change font size to 36
3. close diagram with save
4. reload ide
5. open the diagram
see screenshot 2
Comment 1 Sergey Petrov 2006-12-05 14:34:10 UTC
Created attachment 36477 [details]
good diagram
Comment 2 Sergey Petrov 2006-12-05 14:35:14 UTC
Created attachment 36478 [details]
corrupted diagram/data loss
Comment 3 Peter Lam 2006-12-06 02:53:40 UTC
This should not be a high use case scenario. Doing zooming would be a more
common way usage. Lowering priority to P3.
Comment 4 Sergey Petrov 2006-12-06 10:57:30 UTC
P1, after discussion with Peter(data loss), but not a stopper for coco (may be
not common usecase), I'm not sure if we still need to add coco_waived after
cut-off date
Comment 5 Trey Spiva 2007-01-30 22:38:29 UTC
I was never able to get the diagram to corrupt like the issue.  However, I was able to find what I thought 
corrupted the diagram.  Basically, when you change the font of the lifeline, you change the size of the 
lifeline top.  Therefore, all of the messages need to be adjusted.  This seem to be really important when 
have a create message.  Because the create message also moves, which moves the entire lifeline.  Just the 
create lifeline are no longer matching the opposite end of the message.

An additional fix is moving create message.  The same problem existed.  

So, I think this problem is fixed, but again I was never able to actually replicate the same problem.
Comment 6 Sergey Petrov 2007-01-31 08:00:59 UTC
yes, the main cause is relayout after font change and best solution is to fix
relayout to expand combined fragments, move lifelines and messages correctly,
but a mimimum solution is to relayout right after font change rather then after
reload (so user will be able to close diagram without saving, we'll have at
least some workaround)
Did you try quite complex diagram similar to one on attachments? most layout
problems on sequence diagram occurs with "real" diagram which is quite big and
complex and aren't reproducible on "test" diagrams with 2-3 lifelines and 2-3
messages.
I'll try to replicate a bit later, but it will take a significant amount of time
to create something "real".
Comment 7 Sergey Petrov 2007-02-12 12:06:57 UTC
still corrupted after font change, but diagram is changed right after font
change so now there is a workaround to close the diagram without saving, may be
the issue should be rephrased to something like "relayout has problems... "
Comment 8 Trey Spiva 2007-02-12 14:43:16 UTC
please attach your model, so I can use your model in my testing.
Comment 9 Sergey Petrov 2007-02-14 14:56:28 UTC
able to reproduce messages mixing
but even if "mixing" will be fixed we still will have data loss if proper
handling of combined fragment borders won't be implemeted.
Comment 10 Sergey Petrov 2007-02-14 14:57:38 UTC
Created attachment 38492 [details]
open sequecnce diagram, select all, change font size to 36
Comment 11 Sergey Petrov 2007-02-14 15:33:25 UTC
corruption seems dependent on current zoom level,
diagram became corrupted even with change to 18px font size.
Comment 12 Trey Spiva 2007-02-14 15:40:54 UTC
What was the zoom level that you used.
Comment 13 Sergey Petrov 2007-02-14 15:49:36 UTC
for size 36: something about 50%
for size 18: with zoom 100% corruption is enormous, with zoom about 50%
corruption  isn't big but exists
Comment 14 Sergey Petrov 2007-02-14 15:58:17 UTC
sorry, in previous comment 100 should be replaced with 51 and 50 with 26 
Comment 15 Peter Lam 2007-03-20 20:13:58 UTC
low use case not currently impacting our installed user base.
Comment 16 George Vasick 2007-05-17 18:49:34 UTC
Planned for drawing area upgrade after NB 6.0.
Comment 17 George Vasick 2007-05-18 00:50:26 UTC
Should not use resolved/later status.
Comment 18 George Vasick 2007-06-28 21:42:16 UTC
Targeted in the drawing area redesign.
Comment 19 George Vasick 2007-07-04 00:44:14 UTC
REstoring the original priority and using the NB 6.0 waiver process.
Comment 20 George Vasick 2008-01-02 16:54:30 UTC
Diagram area bugs waived for 6.0 will also be waived for 6.1.
Comment 21 Joanne Lau 2008-05-22 22:53:50 UTC
Verification currently blocked by font issue filed in bug #135640 for 6.5
Comment 22 George Vasick 2008-06-10 17:11:40 UTC
Removing obsolete assignments.  Bugs will be reassigned for M2.
Comment 23 Sergey Petrov 2008-07-02 06:05:12 UTC
some parts are fixed already with redesign, need to test more and fix remaining issues with font changes
Comment 24 Sergey Petrov 2008-07-02 08:27:16 UTC
http://hg.netbeans.org/uml-main/rev/397757e5498c

should work now, after font change messages and lifelines are updated without reloading.
Comment 25 Peter Lam 2008-07-29 21:56:34 UTC
verified in build 20080728