This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The algorithm for determining where the server bits might be ingores the com.sun.aas.installRoot property. it should not. this issue is related to issue 93053
if the install root isn't writable, we probably want the user to create a personal domain... make that the default choice.
Checking in appsrv/src/org/netbeans/modules/j2ee/sun/api/ServerLocationManager.java; /cvs/serverplugins/sun/appsrv/src/org/netbeans/modules/j2ee/sun/api/ServerLocationManager.java,v <-- ServerLocationManager.java new revision: 1.7; previous revision: 1.6 done Checking in appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddInstanceVisualPlatformPanel.java; /cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddInstanceVisualPlatformPanel.java,v <-- AddInstanceVisualPlatformPanel.java new revision: 1.9; previous revision: 1.8
diffs: http://serverplugins.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=2319
Verified in trunk build 070126.
This is usability issue for users that use the server that is installed with root privileges. This is important for NB+AS bundle on Unix systems where the bundle is installed as root
this is not ready for integration... needs reviews, etc. I will put the '5.5.1_candidate' flag in the whiteboard once the fix is ready to integrate...
better fix... don't change the ServerLocationManager.java. change AddDomainPlatformPanel.java diffs: http://www.netbeans.org/source/browse/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddDomainPlatformPanel.java?r1=1.10&r2=1.11
don't forget this change http://www.netbeans.org/source/browse/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddInstanceVisualPlatformPanel.java?r1=1.8&r2=1.9
needs to be reverified
new fix in the trunk
I tested this in the latest build and works fine. Marking as verified. The fix could be merged in release551 branch.
latest set of diffs reviewed by me, looks great.
Checking in AddInstanceVisualPlatformPanel.java; /cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddInstanceVisualPlatformPanel.java,v <-- AddInstanceVisualPlatformPanel.java new revision: 1.1.2.3.2.2.24.1; previous revision: 1.1.2.3.2.2 done Checking in AddDomainPlatformPanel.java; /cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/ui/AddDomainPlatformPanel.java,v <-- AddDomainPlatformPanel.java new revision: 1.1.2.3.2.5.18.2; previous revision: 1.1.2.3.2.5.18.1
*** Issue 89528 has been marked as a duplicate of this issue. ***
Based on this issue i have created a patch which creates a personal domain in the user's home dir when he uses sjsas + nb bundle which is installed as root. I attach the patch.
Created attachment 38180 [details] patch file
I did not read the patch thoroughly, but I think I noticed that you are using fixed port numbers there. This is wrong. What if the installation is multi-user environment on a Sun Ray server? Not sure if we want such a complex change in 5.5.1. Should be very carefully reviewed and tested.
I don't assume that this change should be in NB 5.5.1 as well. I guess that we can check ports before domain is created.
> check ports before domain is created Could we actually recheck ports every time we are starting the domain and change them for the domain if they are occupied by someone else at the particular moment? Still thinking about the SunRay scenario - several students in a class starting their IDEs one after another and creating the domain at random moments. If we only check the ports before domain creation, there could still be two IDEs trying to use the same ports for their domains.
Changing ports every time we are starting domain is problem. All ports are stored in the xml config files in domain. We would have to parse and serialize them. What we can do is to check ports before domain is created. I will attach updated patch in a few minutes.
Created attachment 38190 [details] patch file
Please move the patch and discussion over to issue 93053 I left that issue open for changes similar to those that you have proposed here... I am concerned that somebody will not be able to follow the thread and commit code incorrrectly...