This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 93168 - Use relative paths for links in group shadow file
Summary: Use relative paths for links in group shadow file
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Group (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marian Petras
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-25 08:30 UTC by _ moser
Modified: 2007-02-28 17:07 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Patch fixing the problem (4.31 KB, patch)
2007-01-25 08:31 UTC, _ moser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ moser 2007-01-25 08:30:42 UTC
The "Group Of Files" module is a useful possibility to logically organize files
with is worth to be shared by versioning. Unfortunately it does not make much
sense to put the corresponding shadow file (textfile with the file names of the
links) under CVS as long as the file names of the links are saved as absolute files.

I have modified the module (and attached a patch) to save the links with
relative file names (if possible) and of course also to accept relative file
names. For this the location (parent of) the GroupNode is used as the starting
reference. Links now only will be saved with absolute file names, if the link
and the GroupNode have different file system roots. The patch in particular also
works for files with ".." in the path.

I would be glad if someone would consider to review and hopefully accept my
patch or otherwise start a discussion on it.

Best wishes,
Frank-Michael
Comment 1 _ moser 2007-01-25 08:31:42 UTC
Created attachment 37652 [details]
Patch fixing the problem
Comment 2 Marian Petras 2007-02-28 17:07:31 UTC
Committed to the trunk, with some minor modifications.

Modified files:
   utilities/group/src/org/netbeans/modules/group/GroupShadow.java   (1.9)
   utilities/group/manifest.mf   (1.9)

Diffs:
http://utilities.netbeans.org/source/browse/utilities/group/src/org/netbeans/modules/group/GroupShadow.java?r1=1.8&r2=1.9&diff_format=u
http://utilities.netbeans.org/source/browse/utilities/group/manifest.mf?r1=1.8&r2=1.9&diff_format=u