This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 94915 - can't add module to suite, if module's current suite not found
Summary: can't add module to suite, if module's current suite not found
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-08 06:13 UTC by err
Modified: 2007-02-09 01:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Log file (25.30 KB, text/plain)
2007-02-09 00:08 UTC, Jesse Glick
Details
log file from nb55 (2.71 KB, application/octet-stream)
2007-02-09 01:15 UTC, err
Details

Note You need to log in before you can comment on or make changes to this bug.
Description err 2007-02-08 06:13:18 UTC
Given a module called nbvi, I created nbvi-suite under nbvi. When I attempt to
add the module nbvi to nbvi-suite (by bringin up Project Properties -
nbvi-suite, clicking add, selecting nbvi, clicking open), nothing happens. No
error, nothing. I tried putting nbvi-suite in a subdirectory of nbvi, still no
luck. I expected to see the nbvi module in the "Suite Modules" list.

Further investigation indicates that not all cases fail. The only failing case I
have seen is if nbvi is already in a module suite. Typically if adding a module
to a module suite and the module is already in a suite, then there is a dialog
that asks if you really want to put it into a different suite (or some such
message). But in this case, when nbvi-suite is under nbvi, you get no message
and nothing happens.

(I know this structure is backwards, there are historical reasons)
Comment 1 Jesse Glick 2007-02-08 21:11:42 UTC
Using a 6.0 development build, I create a suite in some dir, say /test. I then
create a module to add to that suite, in a subdir, say /test/module. I then
create another suite beneath that module, say in /test/module/suite2. I then
open suite2's properties and ask to add /test/module to it. The IDE asks whether
I want to remove it from /test and add it to /test/module/suite2; I confirm, and
the IDE does so.

So how do you reproduce your problem? Please be specific.
Comment 2 err 2007-02-08 22:04:18 UTC
I changed the summary to reflect what I believe is going on.

These steps reproduce the issue (don't know if you think its a bug, or a screwed
up user)

- new module
- new suite
- add module to suite
- close all projects
- with a shell command, delete the suite
- new suite
- add module to suite
  nothing happen, no error

I ran into this by 'cp -rp module different_directory' then try to add it to a
newly created suite.
Comment 3 Jesse Glick 2007-02-09 00:08:17 UTC
Created attachment 38270 [details]
Log file
Comment 4 Jesse Glick 2007-02-09 00:09:30 UTC
An exception is thrown. You should have gotten a flashing red error icon in your
status bar. At a minimum the stack trace should be in your log file. Please
always check for errors in your log file when reporting a bug.
Comment 5 err 2007-02-09 01:15:49 UTC
Created attachment 38271 [details]
log file from nb55
Comment 6 err 2007-02-09 01:19:10 UTC
Tried it again, saw the icon. Never noticed it before. The exception is quite
different in 55, that's progress.

In the future I'll keep an eye open for the icon, and remember to check the log
file. Doh!
Comment 7 Jesse Glick 2007-02-09 01:41:00 UTC
Made it more robust, along with some other miscellaneous code cleanups. By the
way, it is generally a better idea to use the IDE's Delete Project action than
to delete project files from a shell.

Checking in src/org/netbeans/modules/apisupport/project/ui/UIUtil.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/UIUtil.java,v
 <--  UIUtil.java
new revision: 1.34; previous revision: 1.33
done
Checking in src/org/netbeans/modules/apisupport/project/Util.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/Util.java,v
 <--  Util.java
new revision: 1.43; previous revision: 1.42
done
Checking in
test/unit/src/org/netbeans/modules/apisupport/project/ui/UIUtilTest.java;
/shared/data/ccvs/repository/apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/ui/UIUtilTest.java,v
 <--  UIUtilTest.java
new revision: 1.7; previous revision: 1.6
done
Checking in
src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteUtils.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteUtils.java,v
 <--  SuiteUtils.java
new revision: 1.31; previous revision: 1.30
done
Checking in
src/org/netbeans/modules/apisupport/project/ui/wizard/wizard/NameIconLocationPanel.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/wizard/wizard/NameIconLocationPanel.java,v
 <--  NameIconLocationPanel.java
new revision: 1.20; previous revision: 1.19
done