This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 95374 - Toolbar rollovers so not look nice on CVS->Show Changes window
Summary: Toolbar rollovers so not look nice on CVS->Show Changes window
Status: RESOLVED WONTFIX
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: issues@ide
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2007-02-13 10:28 UTC by Kirill Sorokin
Modified: 2009-12-21 05:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot (5.43 KB, image/png)
2007-02-13 10:29 UTC, Kirill Sorokin 		Details
WIN Classics L&F (107.90 KB, application/octet-stream)
2007-02-15 14:06 UTC, Josef Pavlicek 		Details
Improving of the buttons border (179.50 KB, application/octet-stream)
2007-02-15 15:04 UTC, Josef Pavlicek 		Details
proposed patch (2 pixel inset) (10.85 KB, text/plain)
2007-02-28 19:04 UTC, pholthuizen 		Details
screenshot with 2 pixel inset (130.31 KB, image/png)
2007-02-28 19:07 UTC, pholthuizen 		Details
as requested (56.92 KB, image/png)
2007-03-05 13:33 UTC, pholthuizen 		Details
margins in rollover (167.55 KB, image/png)
2007-03-06 19:01 UTC, pholthuizen 		Details
1px-to-the-bottom (11.37 KB, image/png)
2007-03-07 03:46 UTC, Kirill Sorokin 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Sorokin 2007-02-13 10:28:28 UTC 
See the attached screen shot. There should be some spacing around the button's
icon and the rollover'ed border.
Comment 1 Kirill Sorokin 2007-02-13 10:28:50 UTC 
NetBeans IDE Dev (Build 200702071900)
1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105
Windows XP version 5.1 running on x86
ru_RU (nb); Cp1251
Comment 2 Kirill Sorokin 2007-02-13 10:29:36 UTC 
Created attachment 38422 [details]
Screenshot
Comment 3 novakm 2007-02-14 12:17:39 UTC 
Reassigning to CVS UI for evaluation
Comment 4 Maros Sandor 2007-02-15 13:38:30 UTC 
jpavlicek: is it a bug? Is so, please attach correct image.
Comment 5 Josef Pavlicek 2007-02-15 14:02:07 UTC 
Hi, that is not a bug. That is (unfortunately strange) behavior of WIN Classics
L&F components.
Comment 6 Josef Pavlicek 2007-02-15 14:06:25 UTC 
Created attachment 38545 [details]
WIN Classics L&F
Comment 7 Kirill Sorokin 2007-02-15 14:10:15 UTC 
Well, shouldn't this "strange" behavior be fixed or worked around?
Comment 8 Josef Pavlicek 2007-02-15 15:04:32 UTC 
Created attachment 38551 [details]
Improving of the buttons border
Comment 9 Josef Pavlicek 2007-02-15 15:04:59 UTC 
Hi,
we can place between edge of the IDE and edge of buttons put 1pix wide line. It
looks much better. See on the picture.
Thank you  for contribution.
Josef
Comment 10 pholthuizen 2007-02-28 19:03:00 UTC 
Added 2 pixel inset. Screenshot and patch attached.
Comment 11 pholthuizen 2007-02-28 19:04:05 UTC 
Created attachment 38986 [details]
proposed patch (2 pixel inset)
Comment 12 pholthuizen 2007-02-28 19:07:05 UTC 
Created attachment 38987 [details]
screenshot with 2 pixel inset
Comment 13 Kirill Sorokin 2007-03-02 08:59:58 UTC 
Could you also post a screenshot when the button with an icon is hovered? The
original issue was about these buttons..
Comment 14 pholthuizen 2007-03-05 13:33:06 UTC 
Created attachment 39167 [details]
as requested
Comment 15 Kirill Sorokin 2007-03-05 14:41:03 UTC 
Thanks. :) Yet this is not exactly what I wanted to see. Take a look at the
first attachment (screenshot.png). The "All" button is pressed and looks OK,
IMO. But the "hovered" button is the rightmost one and it does not look good. 

Can you check whether it looks better with the 2px offset that was implemented?
Comment 16 pholthuizen 2007-03-06 19:01:07 UTC 
Created attachment 39223 [details]
margins in rollover
Comment 17 pholthuizen 2007-03-06 19:03:08 UTC 
You mean it like this?
I'll attach the code if everyone is excited about the new looks. ;-)
Comment 18 Kirill Sorokin 2007-03-07 03:44:53 UTC 
Yeah, I'm almost excited. :) I would be 110% excited if it was possible to move
the icon 1 px to the bottom (see attach).
Comment 19 Kirill Sorokin 2007-03-07 03:46:12 UTC 
Created attachment 39230 [details]
1px-to-the-bottom
Comment 20 Kirill Sorokin 2007-03-07 03:47:12 UTC 
And THANKS for THAT much attention to a P4 btw. ;)
Comment 21 Quality Engineering 2009-12-21 05:41:17 UTC 
This bug was reported against NetBeans IDE 6.0 or an older release, or against a non-maintained module. NetBeans team does not have enough resources to get to this issue, therefore we are closing the issue as a WONTFIX. If you are interested in providing a patch for this bug, please see our NetFIX guidelines for how to proceed. 

We apologize for any inconvenience.


Thank you.
The NetBeans Team