This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Test suite J2EE Functional 5.5.1 , JDK1.6 (b105 / fcs) , Glassfish v2 b33 , WindowsXP64 / Solaris 9 / Linux Test suites Rename and Move are failing since 23.2.2007 (http://test4u.czech/test4u-users/ms113234/results/20070223142257/) with approximatelly 94% probability. All failures look like : org.netbeans.junit.AssertionFileFailedError: Golden file differs at org.netbeans.junit.NbTestCase.assertFile(NbTestCase.java:474) at org.netbeans.test.j2ee.refactoring.LogTestCase.tearDown(LogTestCase.java:195) at org.netbeans.junit.NbTestCase.runBare(NbTestCase.java:321) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at org.netbeans.junit.NbTestCase.run(NbTestCase.java:163) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:169) at org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:124) at org.netbeans.xtest.plugin.ide.MainWithExec.run(MainWithExec.java:85) at org.netbeans.xtest.plugin.ide.Main$3.run(Main.java:299) at java.lang.Thread.run(Thread.java:619) Notice: There's another bug causing failing of performance tests for 5.5.1, starting the same date, so it could be possible this is caused by the same thing.
All failures are caused by latest changes in org.netbeans.junit.diff.LineDiff - mainly hard coded property public static final int CONTEXT = 3; is making troubles. Is there some good reason, why this property is final and why there is no method which takes "CONTEXT" as an argument or at least some boolean in which I can say that I'm not interested in any context?
I merged changes from trunk into release551. I am sorry if it makes some troubles. I think you have to create new golden files. But last changes in LineDiff did Eman Hucka, so he should comment.
I am sorry I did not know that someone depends on the diff's output. I think the LineDiff is created by some factory so you cannot know what diff will be used if you do not use it explicitly. I can set the constant from a system property, e.g. nbjunit.linediff.context. Do you agree?
Yes, that will be useful. Just don't forget to document it. Thanks.
gf fixed, next test runs should be OK. Jardo, verify this, please. Thanks. IDE: [3/6/07 3:33 PM] Committing "rename" started Checking in EjbModTest/testRenameTopicMDB.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameTopicMDB.pass,v <-- testRenameTopicMDB.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameUnusedMsgHandler.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameUnusedMsgHandler.pass,v <-- testRenameUnusedMsgHandler.pass new revision: 1.1.12.1.34.1; previous revision: 1.1.12.1 done Checking in EjbModTest/testRenameQueueMDB.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameQueueMDB.pass,v <-- testRenameQueueMDB.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameWsClass.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameWsClass.pass,v <-- testRenameWsClass.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameCMPLocalHome.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameCMPLocalHome.pass,v <-- testRenameCMPLocalHome.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameCMPBean.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameCMPBean.pass,v <-- testRenameCMPBean.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameClass.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameClass.pass,v <-- testRenameClass.pass new revision: 1.1.12.2.34.1; previous revision: 1.1.12.2 done Checking in EjbModTest/testRenameCMPLocal.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameCMPLocal.pass,v <-- testRenameCMPLocal.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameSessionBean.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameSessionBean.pass,v <-- testRenameSessionBean.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameSessionRemote.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameSessionRemote.pass,v <-- testRenameSessionRemote.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameWsInterface.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameWsInterface.pass,v <-- testRenameWsInterface.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in EjbModTest/testRenameUsedMsgHandler.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameUsedMsgHandler.pass,v <-- testRenameUsedMsgHandler.pass new revision: 1.1.32.1.20.1; previous revision: 1.1.32.1 done Checking in EjbModTest/testRenameSessionRemoteHome.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/EjbModTest/testRenameSessionRemoteHome.pass,v <-- testRenameSessionRemoteHome.pass new revision: 1.2.12.2.34.1; previous revision: 1.2.12.2 done Checking in WebAppTest/testRenameUnusedMsgHandler.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/WebAppTest/testRenameUnusedMsgHandler.pass,v <-- testRenameUnusedMsgHandler.pass new revision: 1.1.12.1.34.1; previous revision: 1.1.12.1 done Checking in WebAppTest/testRenameServlet.pass; /cvs/j2ee/test/qa-functional/data/goldenfiles/org/netbeans/test/j2ee/refactoring/rename/WebAppTest/testRenameServlet.pass,v <-- testRenameServlet.pass new revision: 1.2.12.1.2.1.20.1; previous revision: 1.2.12.1.2.1 done IDE: [3/6/07 3:33 PM] Committing "rename" finished
Some failures still remains in newest testrun.See http://test4u.czech/test4u-users/ms113234/results/20070307094018/ .
Thanks Jardo, all is fixed now.
VERIFIED