Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing
|Summary:||cannot open files from shell if UNC server has a _ (underscore)|
|Status:||CLOSED FIXED||QA Contact:||issues@framework <issues>|
|Priority:||P3||CC:||ahz001, andre.schnabel, carsten.driesner, gkocur, issues, kpalagin, Mathias_Bauer, mdxonefour, michael.cziebalski, mikhail.voytenko, nesshof, stefan.baltzer, stephan.bergmann.secondary, thorsten.martens, tml|
|Version:||OOo 2.0 Beta||Keywords:||oooqa|
|Target Milestone:||OOo 3.2|
|Issue Type:||DEFECT||Latest Confirmation in:||---|
|Issue Depends on:|
Description rvolke 2005-08-10 18:29:23 UTC
We recently came accross a bug where we could not open a file if we navigated directly to the file by UNC name. When you double clicked the file the hourglass thing would go for a sec or so and then would go away, the application never actually fired up. We reproduced this with various files on our LAN. Interestingly enough, if you moved the file to the desktop you could open the file fine with OpenOffice. You can also open the file if you navigate to through a mapped drive or if you use File>Open within OpenOffice.
Comment 1 michael.ruess 2005-08-11 08:48:46 UTC
Comment 2 rvolke 2005-10-11 16:57:12 UTC
I realized that I did not fully clarify the situation in which this even occurred. This problem only occurred with version 109 on an XP machine. Our NT machines with OpenOffice version 109 on them, do not exhibit this problem and can open these same files with no problems. I have currently been unable to test this out with a newer version of OpenOffice.
Comment 3 ralleon 2005-10-12 03:35:04 UTC
Tried OOo 2.0RC1 on Win98SE (on two separate workstations) opening files on network path (on a Windows2000 server) with consistent negative result exactly like this issue#53184. I still get the error 'file did not exist'. But outside of OOo, I can copy and paste said file/s from my Win2kserver to my Win98desktop, and successfully open the same with OOo. If I try to save a file to a network path, OOo 2.0RC1 will give a path error message, but if I check the file on my server, said file is successfully saved. My other concern is that there was another (simililar) issue no. 51026, says it was Resolved, but I dont think so. OOo might quickly dismiss this old issue as resolved; I hope not. Rally de Leon firstname.lastname@example.org
Comment 4 ralleon 2005-10-12 03:38:22 UTC
Tried OOo 2.0RC1 on Win98SE (on two separate workstations) opening files on network path (on a Windows2000 server) with consistent negative result exactly like this issue#53184. I still get the error 'file did not exist'. But outside of OOo, I can copy and paste said file/s from my Win2kserver to my Win98desktop, and successfully open the same with OOo. If I try to save a file to a network path, OOo 2.0RC1 will give a path error message, but if I check the file on my server, said file is successfully saved. My other concern is that there was another (simililar) issue no. 51026, says it was Resolved, but I dont think so. OOo might quickly dismiss this old issue as resolved. Rally de Leon email@example.com
Comment 5 georgewillow 2005-10-25 16:03:43 UTC
I can confirm this issue on Windows 98SE.
Comment 6 aziem 2005-10-28 03:11:43 UTC
Confirm from votes and many recent messages, as follows. * cwchia: Windows XP SP1 and OOo does not work with UNC paths, but mapped drives work * StuartGMC: Windows XP SP2 and OOo 2 does not work with UNC paths (a bit unclear). http://www.oooforum.org/forum/viewtopic.phtml?p=101817 * jcrisman: OOo 2 on Windows 98SE, Windows ME and Windows XP does not work with UNC paths, but mapped drives work. * tyfarquhar: OOo 2 doesn't work, but OOo 1.1.5 does. http://www.oooforum.org/forum/viewtopic.phtml?t=25086 * chreestopher: Winows 98 SE does not work with UNC, but mapped drives works. Also Windows XP does work. http://www.oooforum.org/forum/viewtopic.phtml?t=25705 * Jeff Christiana: "A UNC path to a 2000 server works and A UNC path to a 2003 server Does not." Then it works with mapped drives. http://www.oooforum.org/forum/viewtopic.phtml?t=25958&highlight=
Comment 7 krmc310sunny 2005-10-28 16:22:47 UTC
\\app_srv\CIS_SHARE\CIS_SHARE\Grant This will not open. App_srv is a NT 4 Server \\File_srv\CISOPERA\Allisons courses This will not open. File_Sev is a 2003 server \\bh-srv\BH_DATA\BHADMIN\Administration This will open "Note that BH_Data has an _ But the server name has a - not an underscore In all cases the "-" works fine when opening UNC files All my servers that have _ in them will not alow us to open UNC.. Unless we map a drive and then there is no problem opening UNC files from an _ Looks like if ther is an _ in just the document name it opens fine.
Comment 8 rvolke 2005-10-28 18:26:41 UTC
The server exibiting the problem in my instance is a Netware 5.1 Server (Service pack 5) and it also has an "_" in its name.
Comment 9 rodri_e 2005-11-03 16:07:14 UTC
I have been following this problem since beta versions of OOO 2. Version 1.1.4 CAN open files in unmapped folders on the local network but 2.0 CANNOT. Version 2.0 CAN open files in unmapped folders on the local network when running in WinXP but CANNOT do it in Win98. I've tried with files in Linux and WinXP Pro servers.
Comment 10 murmansk 2005-11-04 14:44:27 UTC
Using Windows XP, OpenOffice 2.0, when I try to open directly \\inf- gris\publico\install.doc using the explorer everything goes ok, if I try \\inf_negro\publico\install.doc it waits for a second or so, and do nothing. I think the problem is in the '_' in the name of the servers. Have similar problems with programs that in some way need that the server`s name accords to DNS system, that does not allows underscores.
Comment 11 rvolke 2005-11-04 16:15:53 UTC
I had the same problem now occur on an NT machine today. And again there was an underscore in the name of the server. This time the file is far more important and easy access is a necessity so I sure hope this issue is resolved in a new version soon.
Comment 12 rvolke 2005-11-04 16:16:21 UTC
I had the same problem now occur on an NT machine today. And again there was an underscore in the name of the server being accessed. This time the file is far more important and easy access is a necessity so I sure hope this issue is resolved in a new version soon.
Comment 13 dewi_griffiths 2005-11-04 17:07:15 UTC
I can confirm this is is an issue for us as well. In fact it it even more grievous for us since we have a samba controlled network environment and use roaming profiles to allow students to login anywhere and access their home drives and application settings. Since many of the OpenOffice preferences refer to networked storage areas, OpenOffice runs like a fat dog in a tarpit. Again it seems to be because our file servers have the "_" character in their names. I have tried changing the file locations to reflect the mapped drive letters in stead of the UNC path, but the options menu seems to have a hard time working with teh "_" in the UNC as well since it will not let me edit preferences which contain our file server UNCs. *** Note *** All our networked drives are mapped to a drive letter, but the preferences still refer to the locations by the full UNC path, so if I could change the prefs values I'm sure OO would run like greased lightning odd a teflon pan. OpenOffice 2.0 final running on Windows XP pro Service pack 2 in a networked SAMBA domain running Samba 4.0.14a off Debian Sarge (stable)
Comment 14 rodri_e 2005-11-04 18:02:26 UTC
I got the error ("file does not exist) in OO 2.0 + Win98 trying to open \\Server\Temporal\temp.sxc and \\Server\Temporal\temp.odt. No spaces or underscore. However, I managed to save a new document in that location without errors.
Comment 15 shlomo_solomon 2005-11-08 07:52:54 UTC
I can confirm that I have the same problem on 2 Win 98 machines which cannot access files on the LINUX Mandrake 10.1 server as already described by several people.
Comment 16 aehrlich 2005-11-09 19:53:38 UTC
And, additionally, OOo 1.9x-2.0 cannot open files on a local Windows (XP) machine by double-clicking it, if the filename contains characters that do not map to the current ANSI charset of Windows (issue#51233), obviously using ...A, not ...W API; using File|Open works, though. Maybe it's somehow related to this UNC issue?
Comment 17 pharoah 2005-11-11 17:20:59 UTC
I am also haveing problems when there are spaces in the file name or path. For example c:\windows\temp\cnh.xls - works c:\windows\temp\cnh worksheet.xls - doesn't c:\windows\temp\cnh-worksheet.xls - does I hope this helps Shane
Comment 18 danielchern 2005-11-12 07:08:13 UTC
I recently installed OOo v.2 on some computers in my office LAN. Server : Win2K server Workstations: win98 and winXP pro 1. PROBLEM: From a win98 workstation, when I try to open an OOo v.1 file residing on the server or an xp machine I get a "file does not exist" error message. a. All file manager functions eg. copy, move, properties etc works and I can open text files(residing on the server or another winXP workstation with notepad from the same win98 workstation. b. Folder permissions are open to EVERYONE-Full Control c. I can open the same file (residing on the server) from another workstation (win98) running OOo v.1.14 or winXP running OOo v.2 d. Same file (residing on win2k server or xp pro workstation) copied to win98 workstation can be opened and works normally. Hope you could let me know how problems 1 (high priority) and 2 can be solved asap as I would like adopt the OpenDocument standard across all my workstations in the office and at home. Thanks. Daniel Chern
Comment 19 lzlz 2005-11-15 03:42:27 UTC
Ours files are stored on Samba server and this issue doesn't happen with Windows 2000 SP4 accessing this file server, but it happen with W98SE machines. To try open doc files with OO 2.0 installed on W98SE this results: "file did not exist". This problem doesn't happen with OO 1.1.2.
Comment 20 andreschnabel 2005-12-24 16:18:50 UTC
some things have been mixed up here. All comments that are related to the "file did not exist" message belong to Issue 51026, which has already been fixed. This issue deals only with UNC path, where the server name has a "_" (underscore) in its name. If this is the case, files cannot be opened form the windows shell (meand windows explorer) by doubleklicking on it. I noticed that on Win98SE und WinXP, using a samba share. That means files like \\sv_01\share\somefile.odt would not be opened by a doupleclick but \\sv01\share\somefile.odt are ok Opening from within OOo (using the Windows-Style FIle Open Dialog) works.
Comment 21 pjentsch 2006-02-02 14:40:45 UTC
I can confirm this issue on Windows XP Professional. The file opens, if I replace the '_' character with '%5f' (url escaped). Still, the file then opens read-only, but this is another issue.
Comment 22 philendrick 2006-02-16 17:09:20 UTC
I can confirm this is an issue on Windows XP SP2 (2600.xpsp_sp2_gdr.050301- 1519) using both the current stable OpenOffice 2.0.1 release and the 2.0.2rc1_060213_Win32 release.
Comment 23 pjentsch 2006-02-16 17:12:36 UTC
Opening files von UNC pathes works great (and allows saving the file after it's open) if the full path doesn't contain *any* underscore. (OOo 2.0.1, Windows XP)
Comment 24 szlevi 2006-03-02 17:43:06 UTC
Same story here: hundred XP SP2 or XP x64 machines, NONE, I repeat, NONE can open ANY Office file directly from UNC path by simply double-clicking on it. This is a HUUUUGE issueu, it shouldn't be unresolved after 8 MONTHS and plenty of posts.
Comment 25 Olaf Felka 2006-03-08 12:37:18 UTC
I've tried to reproduce with OOo 2.0.2 rc4. I've had unc path with underscore to another Windows machine and to a solaris samba drive. I can't reproduce. Is it because of OOo 2.0.2 doesn't have this problem or because the network settings I have don't cause such an error?
Comment 26 pjentsch 2006-03-08 12:57:09 UTC
Tested with OOo_2.0.2rc4_060227_Win32Intel_install_de.exe. Still doesn't work if *servername* has underscores. Works if rest of the path has underscores (which didn't work for me in 2.0.1: documents with '_' in the path (not the servername), where opened read-only. )) The share I'm trying to connect to is on a Windows 2000 Server machine.
Comment 27 Olaf Felka 2006-03-08 13:53:55 UTC
Comment 28 Olaf Felka 2006-03-17 13:03:17 UTC
We can't create servers with underscores in name in our network. Due to timeframe and missing resources I'm retargeting to 2.0.4.
Comment 29 augustoccl 2006-05-03 22:34:51 UTC
I have this same kind of problem. But only when a file, already opened by another user, is reopened. The fileserver used here is Netware 6.0. The expected behavior is to open the file as read-only. Which is achived by opening the file inside the Writer but not using the driver letter mapped by the novell login. I donÂ´t know if someone is having the same issue. By the way, opening any file using the driver letters works normal. The issue is related only to the fact of someone trying to open a already opened file by someone else.
Comment 30 aziem 2006-06-08 16:40:42 UTC
>We can't create servers with underscores in name in our network Perhaps an easy hack is to add the underscored hostname to LMHOSTS with the IP address of an existing server. http://support.microsoft.com/Default.aspx?kbid=150800
Comment 31 thorsten.martens 2006-07-19 08:55:24 UTC
TM->JSK: Please have a look. Do we have the resources to build such an environment ?
Comment 32 andreschnabel 2006-07-19 09:23:51 UTC
andreschnabel->tm: if you ask "us" as a community it should be simple to setup such an environment. Please tell us, if your engineers are able to use any kind of virtual machines (e.g. VMWare). I'm shure, anyy community member could set up a VMWare session with Linux / Samba and a smb-Server name with a underscore. You only need to tell what kind of virtualization and where to upload.
Comment 33 Mathias_Bauer 2006-12-07 13:24:21 UTC
I accidently came across this issue. I don't know why tm didn't answer but let me do it instead: yes, a VMWare image would be fine.
Comment 34 aziem 2006-12-14 00:56:07 UTC
*** Issue 72524 has been marked as a duplicate of this issue. ***
Comment 35 kpalagin 2006-12-18 10:14:14 UTC
I also can reproduce this issue with OO 2.1 on WinXP. I do not have VMware to create virtual machine, but I do have Virtual PC (which is free now). I can create Virtual PC machine image and upload that. Will this help?
Comment 36 carsten.driesner 2006-12-21 14:03:57 UTC
cd->sb: Please take over. HRO and I checked this problem. Hennes was able to reproduce it and we think that's a problem in the INetURLObject::ScanDomain() implementation with NetBIOS names containing a "_" character.
Comment 37 Stephan Bergmann 2006-12-22 09:49:34 UTC
@cd: The (succeeding) test of "file://xxx_yyy/abc" in tools/workben/urltest.cxx:1.36 l. 1153 shows that the problem cannot be a simple failure of INetURLObject. So, as discussed offline, I hand this issue back to you, but let me know when you need any debugging help.
Comment 38 kpalagin 2007-01-04 11:48:53 UTC
Dear developers, any progress with this issue? Thanks a lot!
Comment 39 carsten.driesner 2007-01-09 09:15:52 UTC
cd: I will check this bug as soon as possible, but currently I have many 2.2 tasks to fix. Debugging this problem will need several hours/days as we again don't know where the root cause could be. Therefore we have debug the whole loading code.
Comment 40 carsten.driesner 2007-01-16 14:52:05 UTC
cd->hro: Please take over. You already checked the issue and could reproduce it on the VirtualPC image. As discussed with KSO we should track down this issue as soon as possible. I am busy with other important task.
Comment 41 kpalagin 2007-01-16 15:27:03 UTC
VPC image with underscore in host name is still available upon request. Please do not hesitate to ask (mail me at kpalagin@openoffice). Thanks a lot for your attention.
Comment 42 thorsten.martens 2007-01-31 09:55:39 UTC
*** Issue 73928 has been marked as a duplicate of this issue. ***
Comment 43 kpalagin 2007-02-10 11:20:47 UTC
Issue http://www.openoffice.org/issues/show_bug.cgi?id=64764 describes very simmilar behavior.
Comment 44 mci 2007-02-28 08:42:22 UTC
Hi hro, is there a solution in sight? ---------- added myself to CC
Comment 45 szlevi 2007-02-28 15:21:15 UTC
I highly doubt it - it's a 2+ YEAR OLD ISSUE and still no solution. This is clearly pathetic.
Comment 46 aehrlich 2007-03-01 17:55:22 UTC
Maybe fixing "broken unicode support in the command line" (bug 59251) could solve the issue automagically? The referred regression had also been introduced in 2.0b...
Comment 47 Mathias_Bauer 2007-03-01 22:44:59 UTC
As I see it the reason for this bug is that OOo internally treats all file names as URLs and it parses all URLs in the same way, it doesn't make a difference between file and http URLs. As hro told me, unfortunately underscores in host names are forbidden in URLs. Perhaps we can introduce some special treatment for file URLs wrt. underscores in host names.
Comment 48 tml 2007-03-27 12:53:09 UTC
Sure, underscores are forbidden in DNS hostnames. That doesn't mean such hostnames aren't commonly in use at sites with clueless sysadmins, though. Also, there has not traditionally been any such rule as far as I know for Windows machine names, so there is a lot of historical ballast here that weighs in at many sites. Ever heard the phrase "be liberal in what you accept, strict in what you generate"? It's trivial to fix this bug. One can either make underscore fully equivalent to letters, or use whatever more finesse one feels necessary. Will attach a trivial patch that does the straightforward thing, just treat underscore like a letter... I couldn't be bothered with tracing the workings of urlobj.cxx any closer and do something more refined.
Comment 49 tml 2007-03-27 12:55:33 UTC
Created attachment 43966 [details] Trivial patch, feel free to refine
Comment 50 Mathias_Bauer 2007-03-27 13:29:34 UTC
Thanks for the patch. Both experts for the code (hro, sb) are on vacation currently but they will surely have a look on it when they will be back. But please don't call anything in this area trivial. We can call this an easy fix as the obvious code changes can be written quite fast (as you have proven). But changes in this area can have a lot of side effects and we need some more thinking and also testing. So overall it will be an effort that I wouldn't call "trivial."
Comment 51 krmc310sunny 2007-03-27 13:30:11 UTC
Because of this issue. We have had to pull back all our efforts in going OOo... :-( All because of this stinking underscore problem. I am sorry but we are a Microsoft server site and have hyphens and underscores in lots of servers. And we are not going to change that. I find it absolutely hilarious that this issue cannot be solved. I have been following this since the release of 2.0.....
Comment 52 Mathias_Bauer 2007-03-27 13:49:37 UTC
Well, fortunately this issue *is* going to be fixed. And this is a good thing as meanwhile the demand is visible. But it is not wrong to wait for the demand for a change of code that was written because it is following an established standard. The real problem is how Microsoft treats standards and that users of MS software always see the problems caused by those who follow the standards and not by those who violate them. I like what Paul Tomblin wrote about that: "I love the way Microsoft follows standards. In much the same manner that fish follow migrating caribou." Standards compliance is especially important for cross platform applications like OpenOffice.org. So it is not surprising that we try to follow them as much as possible and deviate from them only if necessary and if considerable demand for doing so has been shown.
Comment 53 kpalagin 2007-04-07 23:17:03 UTC
tml, thank you very much for your patch. It is integrated into version 2.2 of Russian derivative named OpenOffice Pro (http://www.i-rs.ru/download). Testing has revealed that Office running on XP (possibly Vista and Win2000 too) can access server (XP, no other server OS was tested)with underscore in name. If Office is running on WinMe (and possible on Win98) it still can't access server with underscore in name. Please see if you also can fix the problem on Win98/WinMe clients. While at it please also consider http://www.openoffice.org/issues/show_bug.cgi? id=74820. Thanks a lot. WBR, K. Palagin.
Comment 54 kpalagin 2007-04-08 14:40:35 UTC
Correction - patch works just fine on both XP and Win98. Mathias, any chance of integrating this patch in 2.2.1? P.S. Underscore and the like were allowed in NetBIOS names since the very begining (in 1985 or so) and that was not governed by any standard. So this is classic case of having to support legacy even if it is not compliant. This is true for them (they just could not stop supporting strange characters) and us (now we support this too, after years of loosing customers). tml, thank you very much! There is just one problem with UNC left - OpenOffice running on Win98 (WinMe) would not open files from XP (Win2000, WS2003), see issue 74820.
Comment 55 Mathias_Bauer 2007-04-11 16:49:53 UTC
We will have problems to convince the release status committee that this fix can't wait for another 3 months. The criteria for issues with target 2.2.1 are: serious regression, manageable risk and limited QA effort. I doubt that this fix fulfills the last one and it surely doesn't the first.
Comment 56 Mathias_Bauer 2007-05-03 12:23:20 UTC
Hennes, I think we should change the target to 2.3. Do you agree?
Comment 57 kpalagin 2007-05-12 12:26:01 UTC
Attached patch was integrated in OpenOffice 2.2 Pro, released 5th of May. We have at least 40 000 downloads since then and no complaints in this area, which indicates that patch does not break anything. Could it be integrated into master, please?
Comment 58 Mathias_Bauer 2007-05-17 18:47:00 UTC
setting target 2.3
Comment 59 hennes.rohling 2007-06-18 10:22:23 UTC
Scheduled for 2.3
Comment 60 kpalagin 2007-07-25 12:05:45 UTC
Dear developers, with just 10 days left to code freeze attached patch needs to be integrated ASAP. Please state current status of this issue. Thanks a lot.
Comment 61 hennes.rohling 2007-08-01 10:18:40 UTC
Comment 62 jwr 2007-08-03 10:05:33 UTC
The latest entry to this topic has been entered by the developer (hro) himself/herself at 1.8.2007 and is the shortest remark in history. The text does contain nothing more than a period-symbol. I'm just guessing: - the developer does not want to be disturbed (involved in solving the problem). - the developer does not want to be disturbed (reading a magazine). - the case has been closed (problem already solved) - the case has been closed (given up: no solution available) A topic with 47 votes would at least be worth a sentence! Regards -Hans-
Comment 63 hennes.rohling 2007-08-06 10:38:11 UTC
Changed type to patch. @kpalagin: Thx for the patch, looks good. Unfortunately I hadn't enough time to integrate it into 2.3 - you know, it's not just changing some source code lines, testing and quality assurance also has to be done. @jwr: Please stop those dump offending and unqualified comments. Next time you will be banned. I'm not willing to comment on how I spend my time and why there wasn't enough time to integrate this issue in 2.3. If you had a closer look at the task, you would have seen that the target was changed and it's neither closed nor under investigation. The log shows that the target was changed - any need to write this in the comment too ?
Comment 64 kpalagin 2007-08-06 10:49:39 UTC
Hennes, can we integrate this patch into first build of 2.4 please? P.S. The patch is not mine, I am just trying to push it. P.P.S. While at it please also consider http://www.openoffice.org/issues/show_bug.cgi?id=74820 All, due to popular demand I am posting links to OOo build with this patch integrated: Page http://www.i-rs.ru/download Russian language installer ftp://ftp.chg.ru/pub/OpenOffice- RU/2.2.1/ru/OOo_2.2.1_Win32Intel_install_ru_infra_wJRE.exe English language pack http://download.i- rs.ru/pub/openoffice/2.2.1/ru/OOo_2.2.1_Win32Intel_langpack_en-US_infra.exe
Comment 65 hennes.rohling 2007-09-24 10:14:16 UTC
Fixed on CWS hro24
Comment 66 kai.sommerfeld 2008-01-15 16:33:47 UTC
Sorry, but not fixed in CWS hro24. Reopened.
Comment 67 kai.sommerfeld 2008-01-21 14:51:45 UTC
Sorry, no time left to fix this for 2.4 => 3.0
Comment 68 kpalagin 2008-02-02 09:00:51 UTC
Shall we integrate this and fix for http://www.openoffice.org/issues/show_bug.cgi?id=51026 as soon as possible, so that we do not miss 3.0? Thanks a lot for your consideration. WBR, KP.
Comment 69 hennes.rohling 2008-02-13 13:50:41 UTC
Comment 70 hennes.rohling 2008-02-13 14:03:48 UTC
Fixed on CWS hro30
Comment 71 hennes.rohling 2008-02-19 10:35:22 UTC
@tm: Please verify
Comment 72 kpalagin 2008-03-24 13:13:50 UTC
*** Issue 87323 has been marked as a duplicate of this issue. ***
Comment 73 kai.sommerfeld 2008-07-17 08:50:32 UTC
Sorry, no time left to integrate the fix into 3.0 code line. Last CWS integration deadline has passed already. => 3.1
Comment 74 kpalagin 2008-12-04 17:59:42 UTC
So was this patch integrated at some point?
Comment 75 tommy27 2008-12-11 06:56:10 UTC
the issue is FIXED, is it going to be integrated in OOo 3.0.1 or should we wait till 3.1?
Comment 76 kai.sommerfeld 2009-02-19 08:33:48 UTC
Unfortunately we missed the 3.1 code freeze deadline. Bug is fixed, but respective CWS is not approved by QA. Really don't like this, but need to retarget the task to 3.2. Sorry.
Comment 77 kpalagin 2009-03-13 13:38:26 UTC
So could relevant CWS be integrated in, say, m45?
Comment 78 kpalagin 2009-05-13 14:39:31 UTC
Is the fix for this issue already integrated in code?
Comment 79 kai.sommerfeld 2009-07-08 10:48:33 UTC
Taking over... Patch applied to CWS kso32fixes.
Comment 80 Stephan Bergmann 2009-07-08 12:41:04 UTC
@kso: Given that <#desc38> suggests that there never was a problem with INetURLObject handling Windows UNC file URLs with underscores in the server name (like <file://xxx_yyy/abc>) in the first place, I wonder whether applying the attached accept-underscores-in-hostnames.diff patch has any real value. This issue had disappeared from my radar a long time ago. The attached patch is indeed coded rather trivially (see <#desc50>), unnecessarily complicating the code, so it should indeed have been refined. Given how ridiculously old this issue is, I do not want to defer a useful fix any further, but still...
Comment 81 kai.sommerfeld 2009-07-08 14:09:05 UTC
sb: You are right. I missed the important fact that the patch needs to be refined. Thanks for pointing this out. Reopening issue...
Comment 82 kai.sommerfeld 2009-07-08 14:09:53 UTC
sb: Please take over.
Comment 83 Stephan Bergmann 2009-07-08 14:32:23 UTC
@tm (assuming you are the appropriate Sun-internal QA person; if not, please cc whomever else): Can you please make sure you and I have available a suitable test scenario, i.e., some UNC server with an underscore in its name reachable from within Sun? (We will both need that, anyway, to first implement and then verify a fix.)
Comment 84 thorsten.martens 2009-07-09 09:01:49 UTC
@sb: I will forward your request according an unc-server with an underscore in its name to the IT-section.
Comment 85 jms32935 2009-07-10 05:44:32 UTC
In addition to OOo not opening files located on servers which have "_" in their names, it also does not raise any error message when this problem occurs. OOo just closes silently when that happens, leaving the user with no clue as to the nature of the problem. From my employer's point of view, it appeared the product simply didn't work. If I understand you're ready to slip this fix until another release, can you at least try to put up some useful error message when the problem code takes the error path. Thanks.
Comment 87 Stephan Bergmann 2009-07-10 13:30:42 UTC
What I could reproduce with wntmsci12.pro DEV300m52 is as follows: Given the UNC filepath \\vm_gw3\unc_test\testdoc.odt, opening the testdoc.odt in the Windows Explorer either opens an empty OOo writer document (in case OOo quickstarter wass not yet running) or has no visible effect (in case OOo quickstarter was already running). This is consistent with command line behavior, where "C:\Program Files\OpenOffice.org 3\Program\soffice" \\vm_gw3\unc_test\testdoc.odt has the same effect (depending on whether or not OOo quickstarter was already running), while "C:\Program Files\OpenOffice.org 3\Program\soffice" file://vm_gw3/unc_test/testdoc.odt works fine (always opening the requested document). The reason is that when INetURLObject::convertRelToAbs smart-parses input of the form "\\" domain ["\" *UCS4] into an UNC filepath, it erroneously does not accept NetBIOS names (which allows underscores) for the "domain" part. The fix is the attached DEV300m52-tools.patch (containing a corresponding unit test in tools/workben/urltest.cxx), which will be included in CWS kso32fixes (targeting OOo 3.2).
Comment 88 kai.sommerfeld 2009-07-10 14:31:52 UTC
sb: Thanks for the revised patch. I applied it on CWS kso32fixes.
Comment 89 Stephan Bergmann 2009-07-14 08:25:17 UTC
@tm: please verify
Comment 90 thorsten.martens 2009-07-23 12:32:36 UTC
checked and verified in cws kso32fixes -> OK !
Comment 91 ayacopino 2009-12-15 12:54:26 UTC
Any chance to have this before 3.2 version? Thanks a lot.
Comment 92 Stephan Bergmann 2009-12-15 13:47:25 UTC
@ayacopino: The fix got integrated into DEV300_m54. At <http://download.openoffice.org/>, you can either download "the most recent OOo-Dev 3.2.0 build (codeline OOO320)" (currently OOO320_m7) or "the most recent OOo-Dev 3.x build (codeline DEV300)" (currently DEV300_m67), both via the "Get OpenOffice.org Developer Snapshots" link, or wait until an OOo 3.2 RC becomes available (anytime soon now) via the "Get OpenOffice.org Release Candidates" link. Each of those should contain the relevant fix.
Comment 93 cantito 2009-12-18 11:14:39 UTC
Tested in 3.2 RC1 - Win XP: the file \\XP_Test\Test\text.odt (.odt or .ods or .doc etc) is now open, but it is impossible to save the changes because it's locked by "unknown user". Also in the folder \\XP_Test\Test\ the file ".~lock.Text.odt#" is not deleted after closing the document. No problem if I change the server name in XPTest.
Comment 94 jms32935 2009-12-27 09:01:58 UTC
Verified the same problem reported by cantito. My test PC was WinXP-sp2. Tested using OOo_3.2.0rc1_20091217_Win32Intel_install_en-US.exe Tested in directory \\cccb_server\JMS-Testing Test1: Copied an existing Word-97 file... Testing.doc OOo successfully opened the doc, and created file .~lock.Testing.doc# When OOo closed, that lock file was not deleted. Next time, OOo refused to open file because it was locked by unknown user. Word97 opened the file OK, created it's own lock file, and deleted lock when it closed. Test2: Created a new file... Testing2.odt OOo successfully opened the doc, and created a new lockfile I added text to that file and attempted to save it. OOo refused to write to file because it was locked by unknown user. I attempted to save file under a new name, and that failed with similar error. At end of test, lockfiles remained in directory for every file tested. Conclusion... Issue is Not fixed correctly in current OOo_3.2.0rc1.
Comment 95 stefan.baltzer 2010-01-04 18:04:53 UTC
Reopeneing issue according to comments above.
Comment 96 Stephan Bergmann 2010-01-05 14:10:13 UTC
@mav: Can you please verify whether the file locking code has any problems with UNC paths with underscores in the server names, as suggested by <#desc94> and <#desc95>.
Comment 97 mikhail.voytenko 2010-01-07 15:14:33 UTC
mav->sb: Yes, I can reproduce the problem in OOo3.2 rc1. The problem is that INetURLObject( aURL, INET_PROT_FILE ).GetMainURL( INetURLObject::NO_DECODE ) converts "file://comp_name/path/..." to "file:///comp_name/path/..." ( just adds slash that let the computer name be handled as a part of path. This conversion is used in the SimpleFileAccess service implementation for long time ( probably from the very beginning ). And the locking implementation uses SimpleFileAccess service to manipulate the lock file from the very beginning. I assume that any implementation that uses SimpleFileAccess is affected. I would say that the current situation is very dangerous and should be fixed since it is now possible to open documents on such locations. Thus the probability of remaining lock file after unsuccessful saving is very high.
Comment 98 Stephan Bergmann 2010-01-07 16:29:21 UTC
fixed that problem as tools/source/fsys/urlobj.cxx#277881 and tools/workben/urltest.cxx#277881 on SVN CWS fwk135
Comment 99 stefan.baltzer 2010-01-08 10:43:05 UTC
Reassigned to TM.
Comment 100 stefan.baltzer 2010-01-08 10:45:05 UTC
Verified in CWS fwk135. SBA->TM: As discussed, please re-verify after integration of CWS into master and close.
Comment 101 cantito 2010-01-14 13:27:00 UTC
Ok, now works fine! thanks!
Comment 102 jms32935 2010-01-15 03:33:36 UTC
I agree, it works now. Thanks. Used OOo_3.2.0rc2_20100111_Win32Intel_install_wJRE_en-US.exe Tested both with and without Quickstart running.