Issue 96100

Summary: MinGW port for icu 4.0
Product: utilities Reporter: tono <t_ono>
Component: codeAssignee: tono <t_ono>
Status: CLOSED FIXED QA Contact: Unknown <non-migrated>
Severity: Trivial    
Priority: P3 CC: issues, ooo, vladimir.glazounov
Version: DEV300m35   
Target Milestone: OOo 3.1   
Hardware: PC   
OS: Windows, all   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
Patch for icu
none
Patch for solenv/inc/libs.mk
none
Patch for i18npool
none
Patch for vcl
none
Patch for vcl
none
Patch for svtools
none
Patch for binfilter
none
Patch for svx
none
Patch for forms
none
Patch for sw
none
Updated patch for i18npool none

Description tono 2008-11-11 14:55:30 UTC 
Based on discussions with Eike, I have made up my mind to swith to "typedef 
wchar_t UChar" from "typedef unsigned short UChar". With this policy, required 
patches to icu is limited for icu 4.0. I think they are upstreamable to icu 
tickets in the near future.

Instead, we need several reinterpret_cast's in some modules.

The patches follow.
Comment 1 tono 2008-11-11 14:57:33 UTC 
Created attachment 57880 [details]
Patch for icu
Comment 2 tono 2008-11-11 14:58:48 UTC 
Created attachment 57881 [details]
Patch for solenv/inc/libs.mk
Comment 3 tono 2008-11-11 14:59:32 UTC 
Created attachment 57882 [details]
Patch for i18npool
Comment 4 tono 2008-11-11 15:00:16 UTC 
Created attachment 57883 [details]
Patch for vcl
Comment 5 tono 2008-11-11 15:00:33 UTC 
Created attachment 57884 [details]
Patch for vcl
Comment 6 tono 2008-11-11 15:01:37 UTC 
Created attachment 57886 [details]
Patch for svtools
Comment 7 tono 2008-11-11 15:02:56 UTC 
Created attachment 57887 [details]
Patch for binfilter
Comment 8 tono 2008-11-11 15:03:32 UTC 
Created attachment 57888 [details]
Patch for svx
Comment 9 tono 2008-11-11 15:04:29 UTC 
Created attachment 57889 [details]
Patch for forms
Comment 10 tono 2008-11-11 15:05:30 UTC 
Created attachment 57890 [details]
Patch for sw
Comment 11 tono 2008-11-13 12:42:51 UTC 
Fixed in cws mingwport16.
Comment 12 ooo 2008-11-13 17:49:35 UTC 
@tono: Could you please replace the few remaining C-style casts (UChar*) with
C++ casts, so they're more easily identifiable? Btw, does it have to be a
reinterpret_cast? A static_cast doesn't do?
Comment 13 tono 2008-11-21 15:34:07 UTC 
@er: I have updated the patch for i18npool including "(UChar*)NULL". In this 
case static_cast works.
When casting the pointer to sal_Unicode to that to UChar, static_cast does not 
work. GCC treats them as incompatible pointers.
Comment 14 tono 2008-11-21 15:35:23 UTC 
Created attachment 58206 [details]
Updated patch for i18npool
Comment 15 ooo 2008-11-21 16:19:57 UTC 
Fine, thanks.
Comment 16 tono 2008-11-25 14:46:16 UTC 
Reassign for verification.
Comment 17 vg 2009-01-07 12:06:00 UTC 
.
Comment 18 vg 2009-01-07 12:15:22 UTC 
.
Comment 19 tono 2009-01-25 12:22:42 UTC 
Seen in the trunk.